openssh bugs - Sep 2009 - [Bug 1655] New: sftp is unhappy with asterisks in filenames

https://bugzilla.mindrot.org/show_bug.cgi?id=1655

           Summary: sftp is unhappy with asterisks in filenames
           Product: Portable OpenSSH
           Version: 5.2p1
          Platform: Other
        OS/Version: Mac OS X
            Status: NEW
          Severity: normal
          Priority: P2
         Component: sftp
        AssignedTo: unassigned-bugs at mindrot.org
        ReportedBy: vgiffin at apple.com


$ mkdir 'example *' 'example _'
$ sftp localhost
Connecting to localhost...
sftp> cd 'example *'
sftp> ls
                         /private/example _/         
sftp> pwd
Remote working directory: /private/tmp/example *
sftp>

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1655

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
             Blocks|                            |1708

--- Comment #1 from Damien Miller <djm at mindrot.org> 2010-04-09 12:05:58
EST ---
The problem is here:


  1344        case I_LS:
  1345                if (!path1) {
  1346                        do_globbed_ls(conn, *pwd, *pwd, lflag);
  1347                        break;
  1348                }
  1349  
  1350                /* Strip pwd off beginning of non-absolute paths
*/
  1351                tmp = NULL;
  1352                if (*path1 != '/')
  1353                        tmp = *pwd;
  1354  
  1355                path1 = make_absolute(path1, *pwd);
  1356                err = do_globbed_ls(conn, path1, tmp, lflag);
  1357                break;

I think we need to glob-escape the pwd before calling do_globbed_ls().
There might be other instances of this bug in sftp too.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1655

--- Comment #2 from Damien Miller <djm at mindrot.org>  ---
Created attachment 1865
  --> https://bugzilla.mindrot.org/attachment.cgi?id=1865
/home/djm/sftp-unbreak-ls-of-glob.diff

don't try to glob ls of cwd

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1655

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Damien Miller <djm at mindrot.org>  ---
Fix applied - this will be in openssh-5.6. Thanks for the nice
testcase.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1655

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Damien Miller <djm at mindrot.org> 2011-01-24 12:33:47
EST ---
Move resolved bugs to CLOSED after 5.7 release

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.