openssh bugs - Jul 2007 - [Bug 1345] New: closefromtest fails, sometimes

http://bugzilla.mindrot.org/show_bug.cgi?id=1345

           Summary: closefromtest fails, sometimes
           Product: Portable OpenSSH
           Version: 4.6p1
          Platform: amd64
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Miscellaneous
        AssignedTo: bitbucket at mindrot.org
        ReportedBy: David.Leonard at quest.com


sometimes opebsd-compat/regress/closefromtest fails with
   closefrom: closed descriptors it should not have
(On Red Hat EL 3 x86_64)

This is because /dev/null is not being opened for read properly.

--- openssh/openbsd-compat/regress/closefromtest.c      (revision 160)
+++ openssh/openbsd-compat/regress/closefromtest.c      (working copy)
@@ -38,7 +38,7 @@
        char buf[512];

        for (i = 0; i < NUM_OPENS; i++)
-               if ((fds[i] = open("/dev/null", "r")) == -1)
+               if ((fds[i] = open("/dev/null", O_RDONLY)) == -1)
                        exit(0);        /* can't test */
        max = i - 1;


-- 
Configure bugmail: http://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

http://bugzilla.mindrot.org/show_bug.cgi?id=1345


Tim Rice <tim at multitalents.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #1 from Tim Rice <tim at multitalents.net>  2007-07-25
13:55:09 ---
Nice catch. The fix should show up in the next snapshot.


-- 
Configure bugmail: http://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

http://bugzilla.mindrot.org/show_bug.cgi?id=1345


Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at zip.com.au




--- Comment #2 from Darren Tucker <dtucker at zip.com.au>  2007-07-25
14:16:35 ---
(In reply to comment #1)
> Nice catch. The fix should show up in the next snapshot.
In the interests of fairness: Bernard Simon also reported this to me a
while back.  So, credit to him too, and an anti-credit to me for
slacking.


-- 
Configure bugmail: http://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1345


Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added                       
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED                      




--- Comment #3 from Damien Miller <djm at mindrot.org>  2008-04-04
10:00:24 ---
Close resolved bugs after release.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.