openssh bugs - Jun 2007 - [Bug 1236] SCP inappropriate truncate error when copying to FIFO file

http://bugzilla.mindrot.org/show_bug.cgi?id=1236


Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bitbucket at mindrot.org       |djm at mindrot.org
Attachment #1189 is|0                           |1
           obsolete|                            |
   Attachment #1304|                            |ok?
               Flag|                            |




--- Comment #2 from Damien Miller <djm at mindrot.org>  2007-06-12
21:26:30 ---
Created an attachment (id=1304)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1304)
Truncate only for regular files that already existed

I think this patch is a little better - it will skip the truncate if
the file did not already exist or if the target is anything but a
regular file.


-- 
Configure bugmail: http://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

http://bugzilla.mindrot.org/show_bug.cgi?id=1236


Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1289




-- 
Configure bugmail: http://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

http://bugzilla.mindrot.org/show_bug.cgi?id=1236





--- Comment #3 from Tom Wood <wood at xmission.com>  2007-06-13 01:20:02
---
Damien,
   Your fix to this problem

    "if (wrerr == NO && (!exists || S_ISREG(stb.st_mode))
&&
                    ftruncate(ofd, size) != 0) {"

 looks like it will work just fine with a FIFO file target.This logic
 restricts the ftruncate test much more than my fix. As lonk as
 thats appropriate for all mode types, I agrre it is the right thing to 
 do.


Thanks
Tom


-- 
Configure bugmail: http://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

http://bugzilla.mindrot.org/show_bug.cgi?id=1236


Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




--- Comment #4 from Damien Miller <djm at mindrot.org>  2007-06-13
10:21:12 ---
Fix applied, this will be in OpenSSH 4.7 - thanks!


-- 
Configure bugmail: http://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.