openssh bugs - May 2007 - [Bug 1243] Multiple including of paths.h on AIX 5.1 systems.

http://bugzilla.mindrot.org/show_bug.cgi?id=1243


Kieron Curtis <cartmanltd at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cartmanltd at hotmail.com




--- Comment #2 from Kieron Curtis <cartmanltd at hotmail.com>  2007-05-31
17:08:35 ---
PATCH #1243: I believe this bug is due to a typo in the "includes.h"
file.

Line 52 of includes.h checks for definition of macro HAVE_PATHS when it
should in fact be checking for HAVE_PATHS_H
No-where else in the source is any reference made to the the errant
name, only the latter. Using the errant name causes the compiler to
execute the wrong order of include files and macro definitions.

Errant code in includes.h:
    ...
    #ifdef HAVE_PATHS
    # include <paths.h>
    #endif
    ...

When it should be as follows:
    ...
    #ifdef HAVE_PATHS_H
    # include <paths.h>
    #endif
    ...

This fix allows the compilation to proceed without errors.

Note 1: this problem still exists in openssh-4.6p1.

Note 2: the AIX compiler XLC V6 will cause fatal errors when macros are
redefined, whilst XLC V8 will produce warnings. Hence, using later
versions of the compiler may "hide" the problem.


-- 
Configure bugmail: http://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

http://bugzilla.mindrot.org/show_bug.cgi?id=1243





--- Comment #3 from Darren Tucker <dtucker at zip.com.au>  2007-05-31
17:58:26 ---
Created an attachment (id=1299)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1299)
Have configure figure out whether paths.h defines.

Thanks for the info.  You are correct about line 52 being wrong, and
paths.h is probably never pulled in by includes.h.

The question is: since we're trying to move away from includes.h to
per-source-file includes, should we fix paths.h, or, since it's
effectively not used now, remove it entirely and go for an alternative
solution such as this attachment?


-- 
Configure bugmail: http://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

http://bugzilla.mindrot.org/show_bug.cgi?id=1243


Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at zip.com.au
             Blocks|1222, 1274                  |1289, 1305




--- Comment #4 from Darren Tucker <dtucker at zip.com.au>  2007-05-31
17:59:23 ---
Target next release.


-- 
Configure bugmail: http://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

http://bugzilla.mindrot.org/show_bug.cgi?id=1243


Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




--- Comment #5 from Darren Tucker <dtucker at zip.com.au>  2007-06-11
14:48:47 ---
I have applied the change suggested by Kieron in comment #2 since it's
definitely an improvement.  This will be in the next release.

We may do the more involved changes at a later date.

Thanks.


-- 
Configure bugmail: http://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.