openssh bugs - Apr 2007 - [Bug 1306] Spurious : "chan_read_failed for istate 3" errors from sshd

http://bugzilla.mindrot.org/show_bug.cgi?id=1306

           Summary: Spurious : "chan_read_failed for istate 3" errors
from
                    sshd
           Product: Portable OpenSSH
           Version: 4.6p1
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: sshd
        AssignedTo: bitbucket at mindrot.org
        ReportedBy: dtucker at zip.com.au
OtherBugsDependingO 1289,1305
             nThis:


On some platforms (at least Solaris, probably others) sshd in OpenSSH
4.6p1 will log the following error to syslog, but otherwise works OK.

   error: channel 0: chan_read_failed for istate 3

Mentioned on the mailing list:
http://marc.info/?l=openssh-unix-dev&m=117469473826677
http://marc.info/?l=openssh-unix-dev&m=117565843600487

This is a side effect of the changes from the infamous bug #52.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1306


tsi at ualberta.ca changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tsi at ualberta.ca






------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1306





------- Comment #1 from dtucker at zip.com.au  2007-04-10 12:48 -------
Created an attachment (id=1259)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1259&action=view)
Damien's patch from
http://marc.info/?l=openssh-unix-dev&m=117607220603593




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1306


dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #1259 is|0                           |1
           obsolete|                            |




------- Comment #2 from dtucker at zip.com.au  2007-04-10 12:50 -------
Created an attachment (id=1260)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1260&action=view)
Suppress errors when errno==0 instead

This works for me on Solaris 8.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1306





------- Comment #3 from djm at mindrot.org  2007-04-10 13:07 -------
(From update of attachment 1260)
>Index: nchan.c
>==================================================================>RCS
file: /usr/local/src/security/openssh/cvs/openssh/nchan.c,v
>retrieving revision 1.56
>diff -u -p -r1.56 nchan.c
>--- nchan.c	5 Aug 2006 02:39:40 -0000	1.56
>+++ nchan.c	10 Apr 2007 02:41:02 -0000
>@@ -133,17 +133,19 @@ chan_rcvd_oclose1(Channel *c)
> 	}
> }
> void
>-chan_read_failed(Channel *c)
>+chan_read_failed(Channel *c, int err_no)
> {
>-	debug2("channel %d: read failed", c->self);
>+	debug2("channel %d: read failed%s, istate %d", c->self,
>+	    err_no ? "" : " (simulated)", c->istate);
maybe s/simulated/closed/ here
> 	switch (c->istate) {
> 	case CHAN_INPUT_OPEN:
> 		chan_shutdown_read(c);
> 		chan_set_istate(c, CHAN_INPUT_WAIT_DRAIN);
> 		break;
> 	default:
>-		error("channel %d: chan_read_failed for istate %d",
>-		    c->self, c->istate);
>+		if (err_no != 0)
>+			error("channel %d: chan_read_failed for istate %d: %s",
>+			    c->self, c->istate, strerror(errno));
s/errno/err_no/ on this line




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1306


esquire_sithesvaran at dm.gov.ae changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |esquire_sithesvaran at dm.gov.a
                   |                            |e






------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1306





------- Comment #4 from dtucker at zip.com.au  2007-04-10 19:28 -------
Created an attachment (id=1261)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1261&action=view)
Revert the changes that trigger the error messages - patch agains 4.6p1

This patch reverts the changes that trigger the error messages, but
also reintroduces the hang-on-exit bug (#52).

It's intended for people who need a sure fix for the errors now, while
we determine the best long-term fix that doesn't also un-fix #52.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1306





------- Comment #5 from dtucker at zip.com.au  2007-04-10 19:34 -------
(In reply to comment #3)
> >+	debug2("channel %d: read failed%s, istate %d", c->self,
> >+	    err_no ? "" : " (simulated)", c->istate);
> maybe s/simulated/closed/ here
Sure.
> >+			    c->self, c->istate, strerror(errno));
> s/errno/err_no/ on this line
Already spotted and changed that.  Thanks anyway.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1306


jochen.kirn at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jochen.kirn at gmail.com






------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1306


dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #1260 is|0                           |1
           obsolete|                            |




------- Comment #6 from dtucker at zip.com.au  2007-04-14 10:57 -------
Created an attachment (id=1262)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1262&action=view)
Update patch #1260 based on djm's comments




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1306


annisd at schneider.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |annisd at schneider.com






------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.