openssh bugs - Sep 2004 - [Bug 927] Last login displayed even when .hushlogin exists

http://bugzilla.mindrot.org/show_bug.cgi?id=927

           Summary: Last login displayed even when .hushlogin exists
           Product: Portable OpenSSH
           Version: -current
          Platform: Sparc
        OS/Version: Solaris
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: Miscellaneous
        AssignedTo: openssh-bugs at mindrot.org
        ReportedBy: tait+sshbugz at pdx.edu


With OpenSSH_3.5p1, The "Last login: <date> from <host>"
was not displayed if
the user had .hushlogin in their homedir. With OpenSSH_3.9p1, this line is
displayed despite the .hushlogin.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=927

dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://marc.theaimsgroup.com
                   |                            |/?l=openssh-unix-
                   |                            |dev&m=109447341718335
             Status|NEW                         |ASSIGNED



------- Additional Comments From dtucker at zip.com.au  2004-09-11 15:15 -------
Yes, this is a bug introduced with some code intended to display the output of
PAM session modules and was reported recently (see URL).  Will attach a patch.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=927





------- Additional Comments From dtucker at zip.com.au  2004-09-11 15:20 -------
Created an attachment (id=712)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=712&action=view)
Check quietlogin  before displaying last message

As noted in the URL, it would be better to cache the return value of
check_quietlogin(), however this would mean changing some of the platform
independant code.

That would represent more of an ongoing maintenance overhead (ie patches from
OpenBSD won't apply to the changed parts) so as a rule we try to keep the
-portable changes clustered together).



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=927

djm at mindrot.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
    Attachment #712|                            |ok
             Status|                            |



------- Additional Comments From djm at mindrot.org  2004-09-11 18:54 -------
(From update of attachment 712)
This looks OK




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=927

dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From dtucker at zip.com.au  2004-09-11 23:10 -------
Applied, thanks.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.