openssh bugs - Aug 2004 - [Bug 920] Enable client multiplexing to fall back to enhance transparency

http://bugzilla.mindrot.org/show_bug.cgi?id=920

           Summary: Enable client multiplexing to fall back to enhance
                    transparency
           Product: Portable OpenSSH
           Version: -current
          Platform: All
        OS/Version: OpenBSD
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: ssh
        AssignedTo: openssh-bugs at mindrot.org
        ReportedBy: e at molioner.dk


In order to use SSH client session multiplexing, one must manually set up a
ControlMaster which is rather annoying.

I suggest adding a TcpFallback flag which allows the client to fall back to a
regular TCP connection in case the ControlPath control socket doesn't exist.
Furthermore I suggest adding a way to let a ControlMaster ignore an existing
ControlMaster socket by simply becoming a client of it.

These two options should make SSH client multiplexing completely transparently.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=920





------- Additional Comments From e at molioner.dk  2004-08-26 04:55 -------
Created an attachment (id=705)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=705&action=view)
Implementation of the suggested TcpFallback flag.

I sent this to djm at openbsd.org who suggested I added this as a bugreport
here.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=920

e at molioner.dk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
    Attachment #705|Implementation of the       |Implementation of the
        description|suggested TcpFallback flag. |suggested TcpFallback flag.
                   |                            |It is a diff against the
                   |                            |current in-tree OpenSSH as
                   |                            |of August 25th.





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=920





------- Additional Comments From mouring at eviladmin.org  2004-08-26 12:33
-------
+		/*
+	 	* If we return to here, socket could not be opened.
+	 	* Check for TCP fallback and abort if disabled.
+	 	*/
+
+		if (options.tcp_fallback == 0)
+			fatal("Couldn't connect to %s: %s",
+				options.control_path,
+				strerror(errno));

Not sure I like having the strerror(errno) so far away from the origination
point.  Rather
see it inside the control_client();

Either return the error message as part of the char* or  let the function call
run 'error()' then fall out of
the function to let some higher logic decided if other action should be taken.

But I think if one askes to use a pipe and it doesn't exist.  It should
whine a bit louder than this patch if
not create the pipe for future connections to use.

Just something else to consider.

- Ben



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.