openssh bugs - Jun 2004 - [Bug 863] SCP misses copying a file on error

http://bugzilla.mindrot.org/show_bug.cgi?id=863





------- Additional Comments From dtucker at zip.com.au  2004-06-25 18:49 -------
I can't reproduce it here on Linux (with bash).  Maybe the problem is
related to
shell expansion?  What shell are you using at both ends?

Try echoing the command locally and via ssh and see what it expands to:
echo scp -p hosta:/tmp/[a-z]** .
ssh hosta "echo scp -p hosta:/tmp/[a-z]** ."

Does this work as expected?
scp -p 'hosta:/tmp/[a-z]*' .




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=863

dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED



------- Additional Comments From dtucker at zip.com.au  2004-06-25 19:28 -------
OK, I take it back, I can reproduce it thusly:
$ cd /tmp
$ mkdir tmp1 tmp2
$ touch tmp1/test1 tmp1/test2 tmp2/test1
$ sudo chown root tmp2/test1
$ cd tmp2
$ scp -p localhost:/tmp/tmp1/* .
test1                                        100%    0     0.0KB/s   00:00
./test1: set mode: Operation not permitted
./test1: set times: Operation not permitted
$ ls
test1

It looks like the problem is that in this particular path, run_err() gets called
twice, so as soon as the following file transfer starts it get the second of the
error messages.
 



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=863





------- Additional Comments From dtucker at zip.com.au  2004-06-25 19:42 -------
Created an attachment (id=664)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=664&action=view)
set flag to prevent double-error

Please try this patch and see if it solves your problem.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=863

dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |822
              nThis|                            |
           Keywords|                            |openbsd, patch





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=863





------- Additional Comments From dtucker at zip.com.au  2004-06-28 19:40 -------
Created an attachment (id=669)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=669&action=view)
Equivalent patch against OpenBSD




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=863





------- Additional Comments From dtucker at zip.com.au  2004-06-28 19:42 -------
Created an attachment (id=670)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=670&action=view)
Regression test for this problem (against OpenBSD).




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=863





------- Additional Comments From rxanders at srpnet.com  2004-07-08 03:57
-------
Our apps group re-ran the original scripts that detected the problem and scp 
functioned as expected. Thanks for resolving the problem.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=863

dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From dtucker at zip.com.au  2004-07-08 23:22 -------
This is now fixed in -current, and the fix will be in tomorrow's snapshot. 
Thanks for the report.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.