openssh bugs - Jan 2004 - [Bug 764] fully remove product and version information

http://bugzilla.mindrot.org/show_bug.cgi?id=764





------- Additional Comments From kees+bugzilla-mindrot at outflux.net 
2004-01-07 12:49 -------
Created an attachment (id=523)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=523&action=view)
Patch to add configurable version information

This patch provides the following new fields in sshd_config:

ProtoVersionMajor
ProtoVersionMinor
SoftwareVersion
VersionComments

The first three are designed to allow (crazy) administrators to override the
compiled defaults for the software.  The last one is designed to provide
distribution maintainers the ability to tack on additional version information,
if they so choose, instead of patching SSH_VERSION.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=764

kees+bugzilla-mindrot at outflux.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=764

kees+bugzilla-mindrot at outflux.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kees+bugzilla-
                   |                            |mindrot at outflux.net





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=764





------- Additional Comments From floeff at arcor.de  2004-01-07 13:11 -------
Sounds great! Any chance that this will be included in the next OpenSSH release?



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=764





------- Additional Comments From djm at mindrot.org  2004-01-07 13:45 -------
Not a chance in hell. Read comment #1

Protomajor and protominor are useless buttons, they only allow you to break
things.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=764





------- Additional Comments From kees+bugzilla-mindrot at outflux.net 
2004-01-07 13:50 -------
Do you see a problem with SoftwareVersion or VersionComments?  I still don't
see
any harm in just offering all four as configurable options.  Only people who
really wanted to break stuff would use them.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=764





------- Additional Comments From kees+bugzilla-mindrot at outflux.net 
2004-01-07 13:51 -------
Also, I might add, those four options are _only_ for the banner.  They are not
used when examining the client's version information.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=764





------- Additional Comments From markus at openbsd.org  2004-01-07 14:06 -------
4 more useless options, are you kidding? :)

ProtoVersionMajor?
ProtoVersionMinor?




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=764





------- Additional Comments From mouring at eviladmin.org  2004-01-07 14:14
-------
When there are no buggy versions left *COUGH, ya right* I'd rather see
a simple "HideVersion" or "FakeVersion".. Instead of some
insane four
option mess.  Other software packages don't need crap like this. Why are 
you pushing for it here?




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=764

kees+bugzilla-mindrot at outflux.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #523 is|0                           |1
           obsolete|                            |



------- Additional Comments From kees+bugzilla-mindrot at outflux.net 
2004-01-07 14:15 -------
Created an attachment (id=524)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=524&action=view)
Allow software version and version comments to be configurable

Okay, here's a reduced patch that just gives the SoftwareVersion and
VersionComments config items.  I still think it'd be cool to have major and
minor definable too.

Anyway, the reason for this is to get Debian to quit putting their full package
version information on my SSH banner.  The patch openssh (and won't change
it)
to include this in SSH_VERSION, and I think a better option is to make this
configurable.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=764





------- Additional Comments From kees+bugzilla-mindrot at outflux.net 
2004-01-07 14:19 -------
Also, I made them separate options so that ones you didn't want to override
(like, say, the major, minor, and software) could be left alone across upgrades.

Let's say I have just "VersionComments" in my sshd_config, when I
upgrade to
OpenSSH 3.8.1p1, the software version reported by the banner can change.  I
think this is saner than having one big full-banner replacement that has to be
changed when the software changes.

As for other software: this kind of thing exists for sendmail, apache, etc.  I
don't think it's unreasonable.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=764





------- Additional Comments From markus at openbsd.org  2004-01-07 14:24 -------
please add options so i can change the encoding of messages types,
as well. see ssh2.h and ssh1.h



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=764





------- Additional Comments From markus at openbsd.org  2004-01-07 14:25 -------
FYI: there is already an option for protocol-major and minor.

it's called Protocol!



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=764





------- Additional Comments From kees+bugzilla-mindrot at outflux.net 
2004-01-07 14:30 -------
message types: what?
"Protocol" option: I wanted to be able to _lie_ about what was
supported.

Will you accept my 2nd patch?



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.