openssh bugs - Oct 2003 - [Bug 645] Configure mis-identifies setresgid

http://bugzilla.mindrot.org/show_bug.cgi?id=645





------- Additional Comments From dtucker at zip.com.au  2003-10-27 13:43 -------
Created an attachment (id=487)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=487&action=view)
Test setresuid and setresguid for "not implemented"

Please try this patch.	You will need to run "autoreconf" after
applying, then
./configure && make.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=645





------- Additional Comments From tigerwolf at tigerden.com  2003-10-27 14:40
-------
I applied the patch, but the machine dosen't have 'autoreconf" so I
created two
fresh untarred packages and patched only one.  

Both incorrectly set the 'setresgid' define in the resulting config.h
file (diff
says both config.h files are the same).

If autoreconf does some additional magic I can't do, I'd be happy to try
with a
tarred up package wich is ready for configure to be run.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=645





------- Additional Comments From dtucker at zip.com.au  2003-10-27 15:02 -------
Autoreconf (part of the autoconf package) does magic you need.

I have put a complete tarball of -current + this patch temporarily here:
http://dodgynet.dyndns.org/~dtucker/tmp/openssh-uid.tar.gz



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=645





------- Additional Comments From tigerwolf at tigerden.com  2003-10-27 15:27
-------
Ran configure on the test source provided, but the setresgid remained defined. 
Diff with unpached version shows:  

tiger:/archive2/openssh-uid# diff config.h ../openssh-3.7.1p2/config.h
3c3
< /* $Id: acconfig.h,v 1.168 2003/10/15 06:57:57 dtucker Exp $ */
---
> /* $Id: acconfig.h,v 1.166 2003/09/16 01:52:19 dtucker Exp $ */
46,51d45
< /* Define if your setreuid() is broken */
< /* #undef BROKEN_SETRESUID */
< 
< /* Define if your setregid() is broken */
< /* #undef BROKEN_SETRESGID */
< 
100,102d93
< /* Define if you have the basename function. */
< #define HAVE_BASENAME 1
< 
428a420,422
> /* Define if DNS support is to be activated */
> /* #undef DNS */
> 
447a442,444
> /* Define if you have the `basename' function. */
> #define HAVE_BASENAME 1
> 
835,837d831
< /* Define if you have the `strtoul' function. */
< #define HAVE_STRTOUL 1
< 
956c950
< #define HAVE__GETLONG 1
---
> /* #undef HAVE__GETLONG */
962c956
< #define HAVE__GETSHORT 1
---
> /* #undef HAVE__GETSHORT */
If other tests/outputs would be helpful, let me know.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=645





------- Additional Comments From dtucker at zip.com.au  2003-10-27 15:36 -------
Please look in config.log, there will be 2 entries for setres[gu]id.  I'm 
interested in the one that starts with: "checking if setresuid seems to
work"
and the following 10-30 lines up to the "result: [whatever]" line (and
similarly
for the setresgid line).

As far as config.h goes, you only need to show the lines with HAVE_SETRESUID and
BROKEN_SETRESUID (and the same for setresgid).




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=645





------- Additional Comments From tigerwolf at tigerden.com  2003-10-27 17:11
-------
Created an attachment (id=488)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=488&action=view)
Setres config.log extract




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=645

dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #487 is|0                           |1
           obsolete|                            |



------- Additional Comments From dtucker at zip.com.au  2003-10-27 18:19 -------
Created an attachment (id=489)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=489&action=view)
Check setresuid for "not implemented", take 2.
>From the log, it's detecting OK but I got the AC_DEFINEs wrong.  I have
updated
the tarball in comment #11.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=645





------- Additional Comments From tigerwolf at tigerden.com  2003-10-28 02:22
-------
The latest config sets the following:

/* Define if you have the `setresgid' function. */
#define HAVE_SETRESGID 1/*

/* Define if you have the `setresuid' function. */
/* #undef HAVE_SETRESUID */

but also 

/* Define if your setresuid() is broken */
#define BROKEN_SETRESUID 1

/* Define if your setresgid() is broken */
#define BROKEN_SETRESGID 1

(Note I didn't notice if the previoius version set broken defines, as I was
only
expecting to see the setres ones eo be either defined or not.)

I went through a complete compile, and everything seems to work according to a
quick try.

Anything else I need to try or report?



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=645

dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED



------- Additional Comments From dtucker at zip.com.au  2003-10-28 07:38 -------
No, that's fine.  I'll commit the patch unless there are objections.

The BROKEN_* defines weren't set by the earlier patch (you can tell from the
diff you posted).



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.