bugzilla.mindrot.org/show_bug.cgi?id=745 Summary: agent-ptrace.sh fails Product: Portable OpenSSH Version: -current Platform: All OS/Version: OSF/1 Status: NEW Severity: normal Priority: P2 Component: Build system AssignedTo: openssh-bugs at mindrot.org ReportedBy: mmokrejs at natur.cuni.cz This is a minor bug I believe. I get in 3.7.1p2: run test agent-ptrace.sh ... ptrace succeeded?: exit code 1 failed disallow agent ptrace attach make[1]: *** [t-exec] Error 1 make[1]: Leaving directory `/usr/local/scratch/openssh-3.7.1p2/regress' make: *** [tests] Error 2 serow# ptrace bash: ptrace: command not found serow# I believe the test failed because the command does not exist on osf1. You might use /usr/opt/svr4/bin/truss on this platform, if user has installed the package(shown default location). ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
bugzilla.mindrot.org/show_bug.cgi?id=745 dtucker at zip.com.au changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED ------- Additional Comments From dtucker at zip.com.au 2003-10-18 11:16 ------- The test uses gdb to attach to a running agent. ssh-agent on OpenBSD can prevent this but not many (any?) other platforms have this capability. Please tell me what "uname" reports on your system and I'll add it to the list of systems that skip this test. Actually, does anyone know any platforms apart from OpenBSD support this? Maybe we should only run it on the platform(s) that it's know to work on? ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
bugzilla.mindrot.org/show_bug.cgi?id=745 ------- Additional Comments From djm at mindrot.org 2003-10-18 15:05 ------- I thought that disallow ptrace after set[ug]ig was fairly common. Linux does it, in any case. ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
bugzilla.mindrot.org/show_bug.cgi?id=745 ------- Additional Comments From dtucker at zip.com.au 2003-10-18 16:04 ------- Are you sure about Linux? It's on my "skip" list and the test fails on RH8 here when told not to skip: $ PATH=`pwd`:$PATH SUDO=sudo sh ../regress/test-exec.sh `pwd` ../regress/agent- ptrace.sh ptrace succeeded?: exit code 1 failed disallow agent ptrace attach ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
bugzilla.mindrot.org/show_bug.cgi?id=745 ------- Additional Comments From djm at mindrot.org 2003-10-18 18:36 ------- Is the ssh-agent sgid? It needs to be for the ptrace defeat code to work. ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
bugzilla.mindrot.org/show_bug.cgi?id=745 ------- Additional Comments From dtucker at zip.com.au 2003-10-18 19:26 ------- Created an attachment (id=485) --> (bugzilla.mindrot.org/attachment.cgi?id=485&action=view) Set sgid bit on ssh-agent and fix agent test No, there's nothing in the current regression tests to set the sgid bit on the agent. Martin, can you please try this patch? It'll either make ssh-agent sgid root (if SUDO is set) or skip the test. ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
bugzilla.mindrot.org/show_bug.cgi?id=745 dtucker at zip.com.au changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #485 is|0 |1 obsolete| | ------- Additional Comments From dtucker at zip.com.au 2003-10-18 19:29 ------- Created an attachment (id=486) --> (bugzilla.mindrot.org/attachment.cgi?id=486&action=view) Set sgid bit on ssh-agent and fix agent test (minus bogus sshd_config changes) Oops, didn't mean to have those changes to the config files. ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
bugzilla.mindrot.org/show_bug.cgi?id=745 ------- Additional Comments From mmokrejs at natur.cuni.cz 2003-10-20 20:46 ------- uname reports "OSF1" string. ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
bugzilla.mindrot.org/show_bug.cgi?id=745 ------- Additional Comments From mmokrejs at natur.cuni.cz 2003-10-20 21:45 ------- With your patch I get: run test agent-ptrace.sh ... skipped (SUDO not set) and tests happily continue ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
bugzilla.mindrot.org/show_bug.cgi?id=745 dtucker at zip.com.au changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED ------- Additional Comments From dtucker at zip.com.au 2003-10-21 22:30 ------- Patch applied, thanks for the report. The regression tests normally run as a normal user, running with: $ SUDO=sudo make tests will run the appropriate parts as root (assuming you have sudo and it's correctly configured, that is.) ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.