ogg.k.ogg.k at googlemail.com
2008-Sep-09 10:52 UTC
[ogg-dev] oggz-comment hangs on multiple comments with same contents
I haven't investigated this much further for now. Easily seen by adding twice the same comment. This will hang. If listing comments, it will hang too, printing that comment forever (or 2^32-1 times maybe). I might have some time this weekend if nobody's looked at it by then (but no promise).
Conrad Parker
2009-Jun-29 23:35 UTC
[ogg-dev] oggz-comment hangs on multiple comments with same contents
2008/9/9 ogg.k.ogg.k at googlemail.com <ogg.k.ogg.k at googlemail.com>:> I haven't investigated this much further for now. Easily seen by adding twice > the same comment. This will hang. If listing comments, it will hang > too, printing > that comment forever (or 2^32-1 times maybe).Fixed in liboggz HEAD: commit 69ff566f2cb670c96ce63e68da7e0ae61dd072dd Author: Conrad Parker <conrad at metadecks.org> Date: Tue Jun 30 08:30:06 2009 +0900 Handle duplicate comments, with unit test Squash multiple instances of the same comment name=value, don't hang on scanning comment list by value comparison. See http://lists.xiph.org/pipermail/ogg-dev/2008-September/001196.html Conrad.