Christoph Hellwig
2020-Feb-20 15:46 UTC
[Ocfs2-devel] [PATCH v7 14/24] btrfs: Convert from readpages to readahead
On Thu, Feb 20, 2020 at 05:48:49AM -0800, Matthew Wilcox wrote:> btrfs: Convert from readpages to readahead > > Implement the new readahead method in btrfs. Add a readahead_page_batch() > to optimise fetching a batch of pages at once.Shouldn't this readahead_page_batch heper go into a separate patch so that it clearly stands out?
Matthew Wilcox
2020-Feb-20 15:54 UTC
[Ocfs2-devel] [PATCH v7 14/24] btrfs: Convert from readpages to readahead
On Thu, Feb 20, 2020 at 07:46:58AM -0800, Christoph Hellwig wrote:> On Thu, Feb 20, 2020 at 05:48:49AM -0800, Matthew Wilcox wrote: > > btrfs: Convert from readpages to readahead > > > > Implement the new readahead method in btrfs. Add a readahead_page_batch() > > to optimise fetching a batch of pages at once. > > Shouldn't this readahead_page_batch heper go into a separate patch so > that it clearly stands out?I'll move it into 'Put readahead pages in cache earlier' for v8 (the same patch where we add readahead_page())