Ocfs2 devel - Feb 2020 - [PATCH v7 14/24] btrfs: Convert from readpages to readahead

On Thu, Feb 20, 2020 at 09:42:19AM +0000, Johannes Thumshirn
wrote:
> On 19/02/2020 22:03, Matthew Wilcox wrote:
> > From: "Matthew Wilcox (Oracle)" <willy at
infradead.org>
> > 
> > Use the new readahead operation in btrfs.  Add a
> > readahead_for_each_batch() iterator to optimise the loop in the
XArray.
> 
> OK I must admit I haven't followed this series closely, but what 
> happened to said readahead_for_each_batch()?
> 
> As far as I can see it's now:
> 
> [...]
> > +	while ((nr = readahead_page_batch(rac, pagepool))) {
Oops, forgot to update the changelog there.  Yes, that's exactly what it
changed to.  That discussion was here:

https://urldefense.com/v3/__https://lore.kernel.org/linux-fsdevel/20200219144117.GP24185
at
bombadil.infradead.org/__;!!GqivPVa7Brio!NowpsY7jqCHi3nk-7KYRB6OMBhU9RUBOzzoIQZqqy0USKzVxxygQi3ltRqDxPjzhgEcEiw$

... and then Christoph pointed out the iterators weren't really adding
much value at that point, so they got deleted.  New changelog for
this patch:

btrfs: Convert from readpages to readahead
  
Implement the new readahead method in btrfs.  Add a readahead_page_batch()
to optimise fetching a batch of pages at once.

On Thu, Feb 20, 2020 at 05:48:49AM -0800, Matthew Wilcox
wrote:
> btrfs: Convert from readpages to readahead
>   
> Implement the new readahead method in btrfs.  Add a readahead_page_batch()
> to optimise fetching a batch of pages at once.
Shouldn't this readahead_page_batch heper go into a separate patch so
that it clearly stands out?