Ocfs2 devel - Feb 2015 - [PATCH 1/3] ocfs2: remove unneeded variable 'status'

Hi,

I think this patch was already queued. Can I send this patch again
after update changelog?

Thanks.

Regards,
Daeseok Youn

2015-02-27 6:33 GMT+09:00 Andrew Morton <akpm at
linux-foundation.org>:
> On Mon, 23 Feb 2015 19:38:10 +0900 Daeseok Youn <daeseok.youn at
gmail.com> wrote:
>
>> Use 'retval' instead of 'status'.
>>
>
> The patch does a lot more than this.  It causes __ocfs2_add_entry to
> propagate error codes which were previously dropped on the floor.
>
> Please update the changelog to fully explain the functional changes and
> to explain why they are desirable.
>
> After the patch there is still one unchecked call to
> ocfs2_journal_access_di() and one unchecked call to
> ocfs2_journal_access_db().  Probably these are bugs.
>

On Fri, Feb 27, 2015 at 10:27 AM, DaeSeok Youn <daeseok.youn at gmail.com>
wrote:
> Hi,
>
> I think this patch was already queued. Can I send this patch again
> after update changelog?
One thing that is much more important, how did you test this patch? Did you?

-- 
Thanks,
//richard

Hi,

2015-02-27 18:41 GMT+09:00 Richard Weinberger <richard.weinberger at
gmail.com>:
> On Fri, Feb 27, 2015 at 10:27 AM, DaeSeok Youn <daeseok.youn at
gmail.com> wrote:
>> Hi,
>>
>> I think this patch was already queued. Can I send this patch again
>> after update changelog?
>
> One thing that is much more important, how did you test this patch? Did
you?
I couldn't test, actually I don't have the environment for testing
this file system.
just looking this file for cleaning up and found this.

Thanks.

Daeseok Youn.
>
> --
> Thanks,
> //richard