Andrew Morton
2015-Feb-26 21:33 UTC
[Ocfs2-devel] [PATCH 1/3] ocfs2: remove unneeded variable 'status'
On Mon, 23 Feb 2015 19:38:10 +0900 Daeseok Youn <daeseok.youn at gmail.com> wrote:> Use 'retval' instead of 'status'. >The patch does a lot more than this. It causes __ocfs2_add_entry to propagate error codes which were previously dropped on the floor. Please update the changelog to fully explain the functional changes and to explain why they are desirable. After the patch there is still one unchecked call to ocfs2_journal_access_di() and one unchecked call to ocfs2_journal_access_db(). Probably these are bugs.
DaeSeok Youn
2015-Feb-27 09:27 UTC
[Ocfs2-devel] [PATCH 1/3] ocfs2: remove unneeded variable 'status'
Hi, I think this patch was already queued. Can I send this patch again after update changelog? Thanks. Regards, Daeseok Youn 2015-02-27 6:33 GMT+09:00 Andrew Morton <akpm at linux-foundation.org>:> On Mon, 23 Feb 2015 19:38:10 +0900 Daeseok Youn <daeseok.youn at gmail.com> wrote: > >> Use 'retval' instead of 'status'. >> > > The patch does a lot more than this. It causes __ocfs2_add_entry to > propagate error codes which were previously dropped on the floor. > > Please update the changelog to fully explain the functional changes and > to explain why they are desirable. > > After the patch there is still one unchecked call to > ocfs2_journal_access_di() and one unchecked call to > ocfs2_journal_access_db(). Probably these are bugs. >