Ocfs2 devel - Aug 2004 - 2.6 I/O path totally messed up

The second argumentto generic_file_write_nolock is an iovec, not an
actual userbuffer.  The current code doesn't even have the slightest
chance to work.  Maybe it's time to decouple the 2.6 read/write code
from the 2.4 code and implement proper vectored operations everywhere?

(and kill tge O_DIRECT vs O_APPEN hack, and the broken fallback code,
 and..)

On Mon, Aug 30, 2004 at 03:50:22PM +0200, Christoph Hellwig
wrote:
> The second argumentto generic_file_write_nolock is an iovec, not an
> actual userbuffer.  The current code doesn't even have the slightest
> chance to work.  
Yeah, I'm embarrassed to say we missed that in the commit for that code.
I'll be fixing it up asap.
> Maybe it's time to decouple the 2.6 read/write code
> from the 2.4 code and implement proper vectored operations everywhere?
Probably - we've got limited resources, so patches are welcome :)
 
> (and kill tge O_DIRECT vs O_APPEN hack, and the broken fallback code,
>  and..)
No comment :)
	--Mark

--
Mark Fasheh
Software Developer, Oracle Corp
mark.fasheh@oracle.com