Dear Daniele, thanks a lot for your support, i have some things that are not so clear for me: - I can send you the whole sources for our UPSs, do you need only Headers and C files or also other files (i suppose Driver list)? - Seen that we had some problems with the Blazer driver (the battery voltage calculation were not correct for our UPSs) we copied it and modified a bit while changing the name, is this possible or it's a problem for devs? I red the Developer Guide, but due to my inexperience i'm a bit confused, sorry. We have no problems to send you protocols of our UPSs. Thanks in advance Best Regards, Gabriele Taormina UPS Strategic Business Unit Field Application Engineer Phone: +39 0522/207046 Fax: +39 0522/207005 Address: Via Rodano 1 - Reggio Emilia - 42124 - Italy Email: gabriele.taormina at legrand.com<mailto:gabriele.taormina at legrand.com> <mailto:gabriele.taormina at legrand.com>Website: www.ups.legrand.com<http://www.ups.legrand.com/> Website: www.legrand.com<http://www.legrand.com/> [1506322600142_legrand-vector-logo.png] ________________________________ Da: Daniele Pezzini <hyouko at gmail.com> Inviato: sabato 7 luglio 2018 02:07 A: Gabriele TAORMINA Cc: nut-upsdev at alioth-lists.debian.net; Thierry DESTRUEL; Stefano PONGILUPPI Oggetto: Re: [Nut-upsdev] Adding drivers to NUT?> I'm working for Legrand UPS and i would like to know the correct procedure > to send you some drivers source files to be added in the NUT software, this > to extend support also to our UPSs.Either open a pull request on GitHub (https://github.com/networkupstools/nut/), or send the patch (compressed) to this list and we'll do that for you. If you've not already done it, have a look at our developer manual (https://networkupstools.org/docs/developer-guide.chunked/index.html). Also, if it's not one of the common ones, consider releasing the protocol used by your devices and/or giving us permission to publish it in our protocols library (https://networkupstools.org/ups-protocols.html) -- it'll do miracles for future maintenance. ________________________________ Ce message, ainsi que tous les fichiers joints à ce message, peuvent contenir des informations sensibles et/ ou confidentielles ne devant pas être divulguées. Si vous n'êtes pas le destinataire de ce message (ou que vous recevez ce message par erreur), nous vous remercions de le notifier immédiatement à son expéditeur, et de détruire ce message. Toute copie, divulgation, modification, utilisation ou diffusion, non autorisée, directe ou indirecte, de tout ou partie de ce message, est strictement interdite. This e-mail, and any document attached hereby, may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorized, direct or indirect, copying, disclosure, distribution or other use of the material or parts thereof is strictly forbidden. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://alioth-lists.debian.net/pipermail/nut-upsdev/attachments/20180711/3ce09086/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: Outlook-1506322600.png Type: image/png Size: 4655 bytes Desc: Outlook-1506322600.png URL: <http://alioth-lists.debian.net/pipermail/nut-upsdev/attachments/20180711/3ce09086/attachment.png>
> - I can send you the whole sources for our UPSs, do you need only Headers > and C files or also other files (i suppose Driver list)?If you can't generate a patch yourself (either `diff -u` or `git format-patch`, well probably even `git diff`, will do), send any file you've touched and tell us from what you started.> - Seen that we had some problems with the Blazer driver (the battery voltage > calculation were not correct for our UPSs) we copied it and modified a bit > while changing the name, is this possible or it's a problem for devs?Generally speaking, it's not a problem, as long as copyright and license are respected -- it's more a question of opportunity, then: is it worth creating a new driver if the changes are not big? Since you mention the blazer drivers, if your devices use a Q1-like protocol that is not already supported by the nutdrv_qx driver, if feasible, you should add a subdriver to it (or modify an existing one), rather than creating a new driver. See: https://networkupstools.org/docs/developer-guide.chunked/ar01s04.html#nutdrv_qx-subdrivers> We have no problems to send you protocols of our UPSs.Good to hear. If you send this first, we can decide together what's the best solution.
Dear Daniele, I'm trying to create a subdriver for 'nutdrv_qx' instead of modifying the Blazer as you suggested, but i honestly don't understand how to integrate usb-serial devices (some of our UPSs have USB but serial protocol Q1). i understand the serial version but not the USB one. i also checked the "Claim" function, but i can't see drivers that uses the VID and PID to match the device (for nutdrv_qx). if you have the name of a usb driver for nutdrv_qx could be really helpful and i will study on top of it, otherwise if you have any docs regarding this please send me the link! I also checked the nutdrv_qx.c and i found "Krauler subdriver", but i'm not sure how it works. thanks in advance, Best Regards, Gabriele Taormina ________________________________ Da: Daniele Pezzini <hyouko at gmail.com> Inviato: giovedì 12 luglio 2018 02:20 A: Gabriele TAORMINA Cc: nut-upsdev at alioth-lists.debian.net; Thierry DESTRUEL; Stefano PONGILUPPI Oggetto: Re: [Nut-upsdev] Adding drivers to NUT?> - I can send you the whole sources for our UPSs, do you need only Headers > and C files or also other files (i suppose Driver list)?If you can't generate a patch yourself (either `diff -u` or `git format-patch`, well probably even `git diff`, will do), send any file you've touched and tell us from what you started.> - Seen that we had some problems with the Blazer driver (the battery voltage > calculation were not correct for our UPSs) we copied it and modified a bit > while changing the name, is this possible or it's a problem for devs?Generally speaking, it's not a problem, as long as copyright and license are respected -- it's more a question of opportunity, then: is it worth creating a new driver if the changes are not big? Since you mention the blazer drivers, if your devices use a Q1-like protocol that is not already supported by the nutdrv_qx driver, if feasible, you should add a subdriver to it (or modify an existing one), rather than creating a new driver. See: https://networkupstools.org/docs/developer-guide.chunked/ar01s04.html#nutdrv_qx-subdrivers> We have no problems to send you protocols of our UPSs.Good to hear. If you send this first, we can decide together what's the best solution. ________________________________ Ce message, ainsi que tous les fichiers joints à ce message, peuvent contenir des informations sensibles et/ ou confidentielles ne devant pas être divulguées. Si vous n'êtes pas le destinataire de ce message (ou que vous recevez ce message par erreur), nous vous remercions de le notifier immédiatement à son expéditeur, et de détruire ce message. Toute copie, divulgation, modification, utilisation ou diffusion, non autorisée, directe ou indirecte, de tout ou partie de ce message, est strictement interdite. This e-mail, and any document attached hereby, may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorized, direct or indirect, copying, disclosure, distribution or other use of the material or parts thereof is strictly forbidden. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://alioth-lists.debian.net/pipermail/nut-upsdev/attachments/20180718/4ef9eb70/attachment.html>