Nut upsdev - Mar 2018 - R: Nut-upsdev Digest, Vol 152, Issue 5

Hi all,
we should have been found the problem. 
Attach the patch inclusive of this problem and the previous (Riello IDG400 wrong
values & not powering off).

Best regards,

-----Messaggio originale-----
Da: Nut-upsdev [mailto:nut-upsdev-bounces+e.parisi=riello-ups.com at
lists.alioth.debian.org] Per conto di nut-upsdev-request at
lists.alioth.debian.org
Inviato: mercoled? 7 marzo 2018 13:03
A: nut-upsdev at lists.alioth.debian.org
Oggetto: Nut-upsdev Digest, Vol 152, Issue 5

Send Nut-upsdev mailing list submissions to
	nut-upsdev at lists.alioth.debian.org

To subscribe or unsubscribe via the World Wide Web, visit
	https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.alioth.debian.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fnut-upsdev&data=01%7C01%7Ce.parisi%40riello-ups.com%7C2d370b69a0114ab50ffb08d584237aaf%7Cd8fd0d398b2f4760af9e84aadb8587ef%7C0&sdata=iK%2FNnMvk93GPa4amV%2BIcCFzBEg3YTsg6IEN477rKbr4%3D&reserved=0
or, via email, send a message with subject or body 'help' to
	nut-upsdev-request at lists.alioth.debian.org

You can reach the person managing the list at
	nut-upsdev-owner at lists.alioth.debian.org

When replying, please edit your Subject line so it is more specific than
"Re: Contents of Nut-upsdev digest..."


Today's Topics:

   1. Re: [networkupstools/nut] Riello IDG400 wrong values & not
      powering off (#530) (Charles Lepple)


----------------------------------------------------------------------

Message: 1
Date: Tue, 6 Mar 2018 19:26:31 -0500
From: Charles Lepple <clepple at gmail.com>
To: Elio Parisi <e.parisi at riello-ups.com>
Cc: nut-upsdev Nut Developer Mailing List
	<nut-upsdev at lists.alioth.debian.org>
Subject: Re: [Nut-upsdev] [networkupstools/nut] Riello IDG400 wrong
	values & not powering off (#530)
Message-ID: <356B9A74-68AA-4E7E-ABB6-7F8715E249B7 at gmail.com>
Content-Type: text/plain;	charset=us-ascii

On Feb 26, 2018, at 12:06 PM, Elio Parisi <e.parisi at riello-ups.com>
wrote:
> 	-	the second problem I think is related to the first because the shutdown
command that I sent to UPS by NUT monitor works without problems;
Can you please weigh in on the discussion on GitHub?

https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnetworkupstools%2Fnut%2Fissues%2F530%23issuecomment-370947318&data=01%7C01%7Ce.parisi%40riello-ups.com%7C2d370b69a0114ab50ffb08d584237aaf%7Cd8fd0d398b2f4760af9e84aadb8587ef%7C0&sdata=d%2FA2on8WPJpGq3%2BQyIs2reeSMufQBhQ799b976vmBqw%3D&reserved=0


------------------------------

Subject: Digest Footer

_______________________________________________
Nut-upsdev mailing list
Nut-upsdev at lists.alioth.debian.org
https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.alioth.debian.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fnut-upsdev&data=01%7C01%7Ce.parisi%40riello-ups.com%7C2d370b69a0114ab50ffb08d584237aaf%7Cd8fd0d398b2f4760af9e84aadb8587ef%7C0&sdata=iK%2FNnMvk93GPa4amV%2BIcCFzBEg3YTsg6IEN477rKbr4%3D&reserved=0

------------------------------

End of Nut-upsdev Digest, Vol 152, Issue 5
******************************************
-------------- next part --------------
A non-text attachment was scrubbed...
Name: riello.diff.gz
Type: application/x-gzip
Size: 970 bytes
Desc: riello.diff.gz
URL:
<http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20180315/6501cbc4/attachment.bin>

Elio, you flagged 'ups.delay.{shutdown,reboot}' as 'ST_FLAG_RW'
(and
set their maximum length with dstate_setaux()): is the user really
expected to be able to change those vars? If not, don't bother with
flags or length; otherwise, you should also provide a 'upsh.setvar'.

Also, if those vars are actually writable, I would suggest to:
- if they are always numeric and if possible, flag them as
'ST_FLAG_NUMBER' (or, at least, not as 'ST_FLAG_STRING'),
- set their boundaries, if known, with dstate_addenum() or, if
appropriate, with dstate_addrange(),
- if they don't set values in the device, but only in NUT, add (and
document in riello_{ser,usb} man pages) corresponding options to be
set in ups.conf (or using the `-x var=value` command line option),
since the driver, when launched with the `-k` flag or through
`upsdrvctl shutdown`, cannot be aware of any 'transient' change made
previously.

See http://new.networkupstools.org/docs/developer-guide.chunked/ar01s04.html
?4.14-4.17

Lastly, since you are already on GitHub, feel free to open a pull
request there for any proposed change.