Nut upsdev - Jul 2013 - bcmxcp: Now supports more ups variables, help needed on testing on hardware

Hi

I have now done some work to clean up the bcmxcp driver somewhat, and 
then addede support for a number of more
ups variables, so if you have hardware supporting it, you should get 
more output from "upsc" command, for example.

I do not have hardware to test this, so I hope someone do have hardware 
and are willing to test.
The changes should be ok, it is just add new mappings from meter to nut 
variables, but it would be good to know
what hardware supports the different meters, and to check that they 
report correctly.

Do you know what hardware is needed to have support for more than one 
phase on the UPS ?

I have made a pull request for these changes, it is here :
https://github.com/networkupstools/nut/pull/33
The changes are done against the bcmxcp branch in git.

Here are the changes relevant for the new ups variables added
bcmxcp: Add constants for all bcmxmp meter map, and replace magic num?
bcmxcp: Comment which meter map constants are mapped to nut variables
bcmxcp: map ups.date and ups.time to meters.
bcpmxp: Add mapping for output.L<phase>.power.percent to meters
bcpmxp: Add mapping for output.powerfactor and input.powerfactor to meters
bcpmxp: Add mapping for input.power to meters
bcpmxp: Add mapping for ambient.1.temperature to meters
bcpmxp: Add mapping for input.realpower to meters
bcpmxp: Add mapping for battery.current.total to meters
bcpmxp: Add mapping for output.L<phase>.power to meters

Here are some changes related to improved handling of return values from UPS
bcmxcp: Add handling of BCMXCP_RETURN_ACCEPTED_PARAMETER_ADJUST
bcmxcp: Use defined constants in setvar, and handle 
BCMXCP_RETURN_ACCEPTED_PARAMETER_ADJUST
bcmxcp: Only calculate ups.load if the UPS does not report it directly



I have tested my changes on my "POWERWARE UPS 500i", also known as
"PW5110".
Here is the output from "upsc" :
ambient.temperature.high: 221
ambient.temperature.low: 30
battery.charge.low: 11
battery.voltage: 13.5
battery.voltage.low: 10
device.mfr: Eaton
device.model: POWERWARE UPS 500i
device.part: 103004261-5591
device.serial:
device.type: ups
driver.name: bcmxcp_usb
driver.parameter.pollinterval: 2
driver.parameter.port: auto
driver.parameter.shutdown_delay: 50
driver.version: 2.6.5-170-g3f72709
driver.version.internal: 0.28
input.frequency: 49.9
input.frequency.high: 55
input.frequency.low: 45
input.frequency.nominal: 50
input.transfer.boost.high: 207
input.transfer.high: 275
input.transfer.low: 178
input.transfer.trim.low: 250
input.voltage: 238
input.voltage.nominal: 230
output.current: 0.7
output.current.nominal: 1.3
output.frequency: 49.9
output.frequency.nominal: 50
output.phases: 1
output.voltage: 238
output.voltage.nominal: 230
ups.beeper.status: enabled
ups.firmware: Cont:00.50 Inve:01.50
ups.load: 59
ups.mfr: Eaton
ups.model: POWERWARE UPS 500i
ups.power.nominal: 500
ups.serial:
ups.status: OL
ups.test.result: Done and passed


Regards
Alf H?gemark