Nut upsdev - Dec 2007 - Driver for Powercom BNT/KIN/IMP/IMD series

Hello all.

Try this driver (for nut 2.2.0). See attach.
 - Trust, KP625AP, Egys models stay as it was
 - add Powercom's Black Knight Pro model support (
BNT-400/500/600/800/801/1000/1200/1500/2000AP
220-240V )
 - add Powercom's King Pro model support (
KIN-425/525/625/800/1000/1200/1500/1600/2200/3000/5000AP[-RM] 100-120,200-240 V)
 - add Powercom's Imperial model support ( IMP-xxxAP, IMD-xxxAP )

Only for BNT/KIN/IMP/IMD:
power and linevoltage whould detect automatically now
also you don't need any other coefficients in ups.conf
added shutdown.stayoff and shutdown.return commands
start battery.test on driver start

 Tested on: BNT-1200AP

 Known bugs:
 - strange battery level on BNT1200AP ( & may be on other models)
 - can't detect model of IMP/IMD. If anybody will try this driver on
IMP/IMD, tell me please what
your model and what show nut about it

Example of ups.conf:
[<upsname>]
driver = powercom
port = /dev/ttyS0 # or which port you use
type = BNT          # or KIN or IMP (for IMP/IMD) or Trust or Egys or KP625AP, 
your UPS model

Also, i think Trust and Egys - it's just KIN by another manufacturer,
isn't it?
Also, KP625AP - what is it? What full name of this model?

P/S: sorry for my english :)

-- 
Alexey Sidorov
	mailto:alex at reutman.ru
	JID: alex at reutman.ru
	ICQ: 5052225
-------------- next part --------------
A non-text attachment was scrubbed...
Name: powercom.tar.bz2
Type: application/octet-stream
Size: 8675 bytes
Desc: not available
Url :
http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20071224/53218255/attachment.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url :
http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20071224/53218255/attachment.pgp

On Dec 24, 2007 9:04 AM, Alexey Sidorov <alex at reutman.ru>
wrote:
> Only for BNT/KIN/IMP/IMD:
> power and linevoltage whould detect automatically now
> also you don't need any other coefficients in ups.conf
> added shutdown.stayoff and shutdown.return commands
> start battery.test on driver start
>
>  Tested on: BNT-1200AP
Since this has only been tested on one model so far, we should
probably apply it to the SVN trunk first, and backport it to Testing
(which is the branch where 2.2.0 and 2.2.1 came from) after it has
been tested on some other models, or has been proven to be
non-invasive.
> Example of ups.conf:
> [<upsname>]
> driver = powercom
> port = /dev/ttyS0 # or which port you use
> type = BNT          # or KIN or IMP (for IMP/IMD) or Trust or Egys or
KP625AP,  your UPS model
>
> Also, i think Trust and Egys - it's just KIN by another manufacturer,
isn't it?
> Also, KP625AP - what is it? What full name of this model?
It looks like you are adding some possible values for the options -
would you mind updating the documentation for the driver
(man/powercom.8)?

In a similar vein, it's a good idea to write up a summary of your
changes in the same format as the ChangeLog file. This is what helps
us collect the top-level changes that users need to know when they are
upgrading NUT.

Have you been in contact with the original author of this driver? If
you are planning to make other changes to the driver, the simplest
thing might be for you to check out a copy of the trunk from SVN, and
send the output of "svn diff" (which is like the output of "diff
-u")
for easy identification of the changes.

It looks like you changed the name of the nut_shutdown() function back
to "shutdown". The nut_shutdown() name is intentional - there is a C
library function called shutdown() that is used for sockets.

We have convenience functions for setting the flow control pins now:
http://boxster.ghz.cc/projects/nut/changeset/981 . You might be able
to apply that patch (see "Unified diff" link at the bottom of that
page) with a large fuzz factor to your copy of the code, but using SVN
would probably be easier.

-- 
- Charles Lepple

On Dec 24, 2007 9:04 AM, Alexey Sidorov <alex at reutman.ru>
wrote:
> Hello all.
>
> Try this driver (for nut 2.2.0). See attach.
>  - Trust, KP625AP, Egys models stay as it was
>  - add Powercom's Black Knight Pro model support (
BNT-400/500/600/800/801/1000/1200/1500/2000AP
> 220-240V )
>  - add Powercom's King Pro model support (
> KIN-425/525/625/800/1000/1200/1500/1600/2200/3000/5000AP[-RM]
100-120,200-240 V)
>  - add Powercom's Imperial model support ( IMP-xxxAP, IMD-xxxAP )
Also, would you mind adding the models to data/driver.list? You
probably do not need to list every single model number on a separate
line, although it can help if someone uses a web search engine to find
out what software they can use with it.

I neglected to mention this in my first reply, but thank you for
updating the driver!

(I hope all of these suggestions are not too much trouble - it's
things we would probably want to change at some point anyway, but it's
good if we get them fixed before the code goes into the repository.)

-- 
- Charles Lepple

On Jan 9, 2008 5:08 AM, Alexey Sidorov <alex at reutman.ru>
wrote:
> Alexey Sidorov ?????:
> > renew http://www.reutman.ru/files/powercom.tar.bz2
> > - fix detection of KIN-2200AP (was can detected as KIN-2500AP)
> > - add patch for drivers/Makefile.* ( add -lm)
> > - add patch for data/driver.list
> > - add patch for man/powercom.8
> >
> attached powercom.tar.bz2
Thanks, committed to the SVN trunk as r1236. Sorry for the delay.

-- 
- Charles Lepple