Charles Lepple
2007-Mar-20 03:23 UTC
[Nut-upsdev] Re: [nut-commits] svn commit r879 - in trunk: . drivers
Julius: I just realized after committing Michal's patch that you have a more comprehensive patch on the tracker that approaches this piece of code differently. We can go ahead and apply the following patch to the trunk if you still think it's relevant: https://alioth.debian.org/tracker/index.php?func=detail&aid=303719&group_id=30602&atid=411544 If you have a newer version of that patch, let me know and we can add it. On 3/19/07, Charles Lepple <clepple-guest@alioth.debian.org> wrote:> Log: > applied patch from Michal Vaner to correct comparison in gamatronic driver. > [Alioth Bug #304063] > > > Modified: trunk/ChangeLog > =============================================================================> --- trunk/ChangeLog (original) > +++ trunk/ChangeLog Tue Mar 20 03:14:09 2007 > @@ -1,3 +1,8 @@ > +Tue Mar 20 03:11:58 UTC 2007 / Charles Lepple <clepple@gmail.com> > + > + - drivers/gamatronic.c: applied patch from Michal Vaner to correct comparison > + in gamatronic driver. [Alioth Bug #304063] > + > Tue Mar 20 00:10:28 UTC 2007 / Charles Lepple <clepple@gmail.com> > > - */Makefile.am: added various files so that 'make dist' will pick them up. > > Modified: trunk/drivers/gamatronic.c > =============================================================================> --- trunk/drivers/gamatronic.c (original) > +++ trunk/drivers/gamatronic.c Tue Mar 20 03:14:09 2007 > @@ -125,7 +125,7 @@ > void sec_setinfo(int varnum, char *value) > { > > - if (sec_varlist[varnum].setcmd != ""){ > + if (*sec_varlist[varnum].setcmd){/*Not empty*/ > > if (sec_varlist[varnum].flags == FLAG_STRING) { > dstate_setinfo(sec_varlist[varnum].setcmd,"%s", value); > > _______________________________________________ > nut-commits mailing list > nut-commits@lists.alioth.debian.org > http://lists.alioth.debian.org/mailman/listinfo/nut-commits >-- - Charles Lepple
Arnaud Quette
2007-Mar-21 10:06 UTC
[Nut-upsdev] Re: [nut-commits] svn commit r879 - in trunk: . drivers
2007/3/20, Charles Lepple <clepple@gmail.com>:> Julius: I just realized after committing Michal's patch that you have > a more comprehensive patch on the tracker that approaches this piece > of code differently. > > We can go ahead and apply the following patch to the trunk if you > still think it's relevant: > > https://alioth.debian.org/tracker/index.php?func=detail&aid=303719&group_id=30602&atid=411544 > > If you have a newer version of that patch, let me know and we can add it.more generally, and as told previously, don't hesitate to integrate the new sec driver, merging support for gamatronic, into the trunk. it's a development tree, so don't be shy if your work isn't yet finished ;) Arnaud -- Linux / Unix Expert - MGE UPS SYSTEMS - R&D Dpt Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/ Debian Developer - http://people.debian.org/~aquette/ OpenSource Developer - http://arnaud.quette.free.fr/