Andrew Morton
2024-Jul-30 22:25 UTC
+ fsi-add-missing-module_description-macros.patch added to mm-nonmm-unstable branch
The patch titled Subject: fsi: add missing MODULE_DESCRIPTION() macros has been added to the -mm mm-nonmm-unstable branch. Its filename is fsi-add-missing-module_description-macros.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/fsi-add-missing-module_description-macros.patch This patch will later appear in the mm-nonmm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Jeff Johnson <quic_jjohnson at quicinc.com> Subject: fsi: add missing MODULE_DESCRIPTION() macros Date: Tue, 30 Jul 2024 07:43:21 -0700 make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/fsi/fsi-core.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/fsi/fsi-master-hub.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/fsi/fsi-master-aspeed.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/fsi/fsi-master-gpio.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/fsi/fsi-master-ast-cf.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/fsi/fsi-scom.o Add the missing invocations of the MODULE_DESCRIPTION() macro, and fix the copy/paste of the module description comment in fsi-master-ast-cf.c. Link: https://lkml.kernel.org/r/20240730-module_description_orphans-v1-4-7094088076c8 at quicinc.com Signed-off-by: Jeff Johnson <quic_jjohnson at quicinc.com> Reviewed-by: Eddie James <eajames at linux.ibm.com> Cc: Alexandre Torgue <alexandre.torgue at foss.st.com> Cc: Alistar Popple <alistair at popple.id.au> Cc: Andrew Jeffery <andrew at codeconstruct.com.au> Cc: Andy Lutomirski <luto at kernel.org> Cc: Arnd Bergmann <arnd at arndb.de> Cc: Boqun Feng <boqun.feng at gmail.com> Cc: Borislav Petkov <bp at alien8.de> Cc: Christophe Leroy <christophe.leroy at csgroup.eu> Cc: Dave Hansen <dave.hansen at linux.intel.com> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org> Cc: "H. Peter Anvin" <hpa at zytor.com> Cc: Ingo Molnar <mingo at redhat.com> Cc: Jeremy Kerr <jk at ozlabs.org> Cc: Joel Stanley <joel at jms.id.au> Cc: Karol Herbst <karolherbst at gmail.com> Cc: Masami Hiramatsu <mhiramat at kernel.org> Cc: Maxime Coquelin <mcoquelin.stm32 at gmail.com> Cc: Michael Ellerman <mpe at ellerman.id.au> Cc: Naveen N Rao <naveen at kernel.org> Cc: Nicholas Piggin <npiggin at gmail.com> Cc: Nouveau <nouveau at lists.freedesktop.org> Cc: Pekka Paalanen <ppaalanen at gmail.com> Cc: Peter Zijlstra <peterz at infradead.org> Cc: Rafael J. Wysocki <rafael at kernel.org> Cc: Russell King <linux at armlinux.org.uk> Cc: Steven Rostedt (Google) <rostedt at goodmis.org> Cc: Thomas Gleixner <tglx at linutronix.de> Cc: Viresh Kumar <viresh.kumar at linaro.org> Cc: Waiman Long <longman at redhat.com> Cc: Will Deacon <will at kernel.org> Signed-off-by: Andrew Morton <akpm at linux-foundation.org> --- drivers/fsi/fsi-core.c | 1 + drivers/fsi/fsi-master-aspeed.c | 1 + drivers/fsi/fsi-master-ast-cf.c | 3 ++- drivers/fsi/fsi-master-gpio.c | 1 + drivers/fsi/fsi-master-hub.c | 1 + drivers/fsi/fsi-scom.c | 1 + 6 files changed, 7 insertions(+), 1 deletion(-) --- a/drivers/fsi/fsi-core.c~fsi-add-missing-module_description-macros +++ a/drivers/fsi/fsi-core.c @@ -1444,5 +1444,6 @@ static void fsi_exit(void) } module_exit(fsi_exit); module_param(discard_errors, int, 0664); +MODULE_DESCRIPTION("FSI core driver"); MODULE_LICENSE("GPL"); MODULE_PARM_DESC(discard_errors, "Don't invoke error handling on bus accesses"); --- a/drivers/fsi/fsi-master-aspeed.c~fsi-add-missing-module_description-macros +++ a/drivers/fsi/fsi-master-aspeed.c @@ -670,4 +670,5 @@ static struct platform_driver fsi_master }; module_platform_driver(fsi_master_aspeed_driver); +MODULE_DESCRIPTION("FSI master driver for AST2600"); MODULE_LICENSE("GPL"); --- a/drivers/fsi/fsi-master-ast-cf.c~fsi-add-missing-module_description-macros +++ a/drivers/fsi/fsi-master-ast-cf.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0+ // Copyright 2018 IBM Corp /* - * A FSI master controller, using a simple GPIO bit-banging interface + * A FSI master based on Aspeed ColdFire coprocessor */ #include <linux/crc4.h> @@ -1438,5 +1438,6 @@ static struct platform_driver fsi_master }; module_platform_driver(fsi_master_acf); +MODULE_DESCRIPTION("A FSI master based on Aspeed ColdFire coprocessor"); MODULE_LICENSE("GPL"); MODULE_FIRMWARE(FW_FILE_NAME); --- a/drivers/fsi/fsi-master-gpio.c~fsi-add-missing-module_description-macros +++ a/drivers/fsi/fsi-master-gpio.c @@ -892,4 +892,5 @@ static struct platform_driver fsi_master }; module_platform_driver(fsi_master_gpio_driver); +MODULE_DESCRIPTION("A FSI master controller, using a simple GPIO bit-banging interface"); MODULE_LICENSE("GPL"); --- a/drivers/fsi/fsi-master-hub.c~fsi-add-missing-module_description-macros +++ a/drivers/fsi/fsi-master-hub.c @@ -295,4 +295,5 @@ static struct fsi_driver hub_master_driv }; module_fsi_driver(hub_master_driver); +MODULE_DESCRIPTION("FSI hub master driver"); MODULE_LICENSE("GPL"); --- a/drivers/fsi/fsi-scom.c~fsi-add-missing-module_description-macros +++ a/drivers/fsi/fsi-scom.c @@ -625,4 +625,5 @@ static void scom_exit(void) module_init(scom_init); module_exit(scom_exit); +MODULE_DESCRIPTION("SCOM FSI Client device driver"); MODULE_LICENSE("GPL"); _ Patches currently in -mm which might be from quic_jjohnson at quicinc.com are lib-test_objpool-add-missing-module_description-macro.patch crypto-arm-xor-add-missing-module_description-macro.patch x86-mm-add-testmmiotrace-module_description.patch cpufreq-powerpc-add-missing-module_description-macros.patch fsi-add-missing-module_description-macros.patch locking-ww_mutex-test-add-module_description.patch
Apparently Analagous Threads
- [merged] fsi-add-missing-module_description-macros.patch removed from -mm tree
- + locking-ww_mutex-test-add-module_description.patch added to mm-nonmm-unstable branch
- + x86-mm-add-testmmiotrace-module_description.patch added to mm-nonmm-unstable branch
- + crypto-arm-xor-add-missing-module_description-macro.patch added to mm-nonmm-unstable branch
- + cpufreq-powerpc-add-missing-module_description-macros.patch added to mm-nonmm-unstable branch