Nouveau - Dec 2023 - [PATCH] nouveau/gsp: add three notifier callbacks that we see in normal operation

On Tue, 2023-12-05 at 08:55 +1000, Dave Airlie wrote:
> +static int
> +r535_gsp_msg_ucode_libos_print(void *priv, u32 fn, void *repv, u32 repc)
> +{
> +???????/* work out what we should do here. */
> +???????return 0;
> +}
This is part of my logrm debugfs patch. ?It contains the printf log from a
PMU exception.

Do you want me to research the other two RPCs and tell you exactly what they
do?

But if you're not planning on actually doing anything with these RPCs, why
add callbacks? ?Doesn't the driver already ignore RPCs it doesn't
recognize?

On Tue, 5 Dec 2023 at 09:07, Timur Tabi <ttabi at nvidia.com>
wrote:
>
> On Tue, 2023-12-05 at 08:55 +1000, Dave Airlie wrote:
> > +static int
> > +r535_gsp_msg_ucode_libos_print(void *priv, u32 fn, void *repv, u32
repc)
> > +{
> > +       /* work out what we should do here. */
> > +       return 0;
> > +}
>
> This is part of my logrm debugfs patch.  It contains the printf log from a
> PMU exception.
>
> Do you want me to research the other two RPCs and tell you exactly what
they
> do?
>
> But if you're not planning on actually doing anything with these RPCs,
why
> add callbacks?  Doesn't the driver already ignore RPCs it doesn't
recognize?
The current code prints a message when we get a callback we don't
handle, this silences those, but maybe I should just silence them.

Dave.