Nouveau - Aug 2023 - [PATCH (set 1) 00/20] Rid W=1 warnings from GPU

On Thu, 24 Aug 2023, Lee Jones <lee at kernel.org>
wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
The next question is, how do we keep it W=1 clean going forward?

Most people don't use W=1 because it's too noisy, so it's a bit of a
catch-22.

In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our
Makefile. For CI/developer use we also enable kernel-doc warnings by
default.

Should we start enabling some of those warning flags in drm/Makefile to
to keep the entire subsystem warning free?


BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center

On Thu, Aug 24, 2023 at 12:03:20PM +0300, Jani Nikula
wrote:
> On Thu, 24 Aug 2023, Lee Jones <lee at kernel.org> wrote:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> 
> The next question is, how do we keep it W=1 clean going forward?
> 
> Most people don't use W=1 because it's too noisy, so it's a bit
of a
> catch-22.
> 
> In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our
> Makefile. For CI/developer use we also enable kernel-doc warnings by
> default.
> 
> Should we start enabling some of those warning flags in drm/Makefile to
> to keep the entire subsystem warning free?
I think that's a good idea. At least the documentation fixes I just
merged could have been easily caught before submission.

Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20230824/c6b8a28b/attachment.sig>

On Thu, 24 Aug 2023, Jani Nikula wrote:
> On Thu, 24 Aug 2023, Lee Jones <lee at kernel.org> wrote:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> 
> The next question is, how do we keep it W=1 clean going forward?
My plan was to fix them all, then move each warning to W=0.

Arnd recently submitted a set doing just that for a bunch of them.

https://lore.kernel.org/all/20230811140327.3754597-1-arnd at kernel.org/

I like to think a bunch of this is built on top of my previous efforts.

GPU is a particularly tricky though - the warnings seem to come in faster
than I can squash them.  Maybe the maintainers can find a way to test
new patches on merge?
> Most people don't use W=1 because it's too noisy, so it's a bit
of a
> catch-22.
> 
> In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our
> Makefile. For CI/developer use we also enable kernel-doc warnings by
> default.
> 
> Should we start enabling some of those warning flags in drm/Makefile to
> to keep the entire subsystem warning free?
That would we awesome!  We'd just need buy-in.

-- 
Lee Jones [???]