ruanjinjie
2022-Sep-24 07:39 UTC
[Nouveau] [PATCH -next] drm/nouveau/disp: make gv100_disp_core_mthd_base static
The symbol is not used outside of the file, so mark it static. Fixes the following warning: ./drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c:591:1: warning: symbol 'gv100_disp_core_mthd_base' was not declared. Should it be static? Signed-off-by: ruanjinjie <ruanjinjie at huawei.com> --- drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c index 6b9d49270fa7..347c12a1fcb7 100644 --- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c +++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c @@ -587,7 +587,7 @@ gv100_disp_curs = { .user = 73, }; -const struct nvkm_disp_mthd_list +static const struct nvkm_disp_mthd_list gv100_disp_core_mthd_base = { .mthd = 0x0000, .addr = 0x000000, -- 2.25.1
Karol Herbst
2023-Apr-11 14:12 UTC
[Nouveau] [PATCH -next] drm/nouveau/disp: make gv100_disp_core_mthd_base static
Reviewed-by: Karol Herbst <kherbst at redhat.com> On Sat, Sep 24, 2022 at 10:00?AM ruanjinjie <ruanjinjie at huawei.com> wrote:> > The symbol is not used outside of the file, so mark it static. > > Fixes the following warning: > > ./drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c:591:1: warning: > symbol 'gv100_disp_core_mthd_base' was not declared. Should it be static? > > Signed-off-by: ruanjinjie <ruanjinjie at huawei.com> > --- > drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c > index 6b9d49270fa7..347c12a1fcb7 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c > +++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c > @@ -587,7 +587,7 @@ gv100_disp_curs = { > .user = 73, > }; > > -const struct nvkm_disp_mthd_list > +static const struct nvkm_disp_mthd_list > gv100_disp_core_mthd_base = { > .mthd = 0x0000, > .addr = 0x000000, > -- > 2.25.1 >
Reasonably Related Threads
- [PATCH] drm/nouveau/disp/gv100: make gv100_disp_core_mthd_{base, sor} static
- missing firmware report
- [PATCH 2/6] drm/nouveau: fault: Widen engine field
- [PATCH 1/6] drm/nouveau: fault: Store aperture in fault information
- [PATCH] drm/nouveau/kms/gv100-: Re-set LUT after clearing for modesets