Ilia Mirkin
2020-Jul-18 22:53 UTC
[Nouveau] [PATCH 1/2] drmmode: fix screen resize without acceleration
This got broken with commit 86024cee back in 2014! drmmode_pixmap/nouveau_pixmap expect there to be EXA wrapping around the pixmap now, which is not there without accel. Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> --- src/drmmode_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/drmmode_display.c b/src/drmmode_display.c index 89927a4..69421e1 100644 --- a/src/drmmode_display.c +++ b/src/drmmode_display.c @@ -1561,7 +1561,7 @@ drmmode_xf86crtc_resize(ScrnInfoPtr scrn, int width, int height) } ppix = screen->GetScreenPixmap(screen); - if (pNv->AccelMethod >= NONE) + if (pNv->AccelMethod > NONE) nouveau_bo_ref(pNv->scanout, &drmmode_pixmap(ppix)->bo); screen->ModifyPixmapHeader(ppix, width, height, -1, -1, pitch, (pNv->AccelMethod > NONE || pNv->ShadowPtr) ? -- 2.26.2
Ilia Mirkin
2020-Jul-18 22:53 UTC
[Nouveau] [PATCH 2/2] present: don't enable if there's no acceleration
All the present logic relies on EXA being used to wrap everything. Unclear if present could even be used without the other things EXA enables, but better be safe. Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> --- src/nv_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nv_driver.c b/src/nv_driver.c index a63674c..e72a6b6 100644 --- a/src/nv_driver.c +++ b/src/nv_driver.c @@ -1489,7 +1489,7 @@ NVScreenInit(SCREEN_INIT_ARGS_DECL) xf86SetBlackWhitePixels(pScreen); - if (nouveau_present_init(pScreen)) + if (pNv->AccelMethod == EXA && nouveau_present_init(pScreen)) xf86DrvMsg(pScrn->scrnIndex, X_INFO, "Hardware support for Present enabled\n"); else -- 2.26.2
Possibly Parallel Threads
- [PATCH] Add Option "DRI3" to allow to disable DRI3 under EXA.
- [PATCH] Add Option "DRI3" to allow to disable DRI3 under EXA.
- [PATCH] Add Option "DRI3" to allow to disable DRI3 under EXA.
- [PATCH 1/2] present: Fixup return type of nouveau_present_init()
- [PATCH] Add Option "DRI3" to allow to disable DRI3 under EXA.