Nouveau - Nov 2019 - [PATCH v2 02/15] mm/mmu_notifier: add an interval tree notifier

On Thu, Nov 07, 2019 at 08:06:08PM +0000, Jason Gunthorpe
wrote:
> > 
> > enum mmu_range_notifier_event {
> > 	MMU_NOTIFY_RELEASE,
> > };
> > 
> > ...assuming that we stay with "mmu_range_notifier" as a core
name for this
> > whole thing.
> > 
> > Also, it is best moved down to be next to the new MNR structs, so that
all the
> > MNR stuff is in one group.
> 
> I agree with Jerome, this enum is part of the 'struct
> mmu_notifier_range' (ie the description of the invalidation) and it
> doesn't really matter that only these new notifiers can be called with
> this type, it is still part of the mmu_notifier_range.
> 
> The comment already says it only applies to the mmu_range_notifier
> scheme..
In fact the enum is entirely unused.  We might as well just kill it off
entirely.

On Thu, Nov 07, 2019 at 10:33:02PM -0800, Christoph Hellwig
wrote:
> On Thu, Nov 07, 2019 at 08:06:08PM +0000, Jason Gunthorpe wrote:
> > > 
> > > enum mmu_range_notifier_event {
> > > 	MMU_NOTIFY_RELEASE,
> > > };
> > > 
> > > ...assuming that we stay with "mmu_range_notifier" as a
core name for this
> > > whole thing.
> > > 
> > > Also, it is best moved down to be next to the new MNR structs, so
that all the
> > > MNR stuff is in one group.
> > 
> > I agree with Jerome, this enum is part of the 'struct
> > mmu_notifier_range' (ie the description of the invalidation) and
it
> > doesn't really matter that only these new notifiers can be called
with
> > this type, it is still part of the mmu_notifier_range.
> > 
> > The comment already says it only applies to the mmu_range_notifier
> > scheme..
> 
> In fact the enum is entirely unused.  We might as well just kill it off
> entirely.
I had patches to use it, i need to re-post them. I posted them long ago
and i droped the ball. I will re-spin after this.

Cheers,
J?r?me