Nouveau - Nov 2019 - [PATCH v2 08/15] xen/gntdev: Use select for DMA_SHARED_BUFFER

On Mon, Oct 28, 2019 at 05:10:25PM -0300, Jason Gunthorpe
wrote:
> From: Jason Gunthorpe <jgg at mellanox.com>
> 
> DMA_SHARED_BUFFER can not be enabled by the user (it represents a library
> set in the kernel). The kconfig convention is to use select for such
> symbols so they are turned on implicitly when the user enables a kconfig
> that needs them.
> 
> Otherwise the XEN_GNTDEV_DMABUF kconfig is overly difficult to enable.
> 
> Fixes: 932d6562179e ("xen/gntdev: Add initial support for dma-buf
UAPI")
> Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko at epam.com>
> Cc: Boris Ostrovsky <boris.ostrovsky at oracle.com>
> Cc: xen-devel at lists.xenproject.org
> Cc: Juergen Gross <jgross at suse.com>
> Cc: Stefano Stabellini <sstabellini at kernel.org>
> Reviewed-by: Juergen Gross <jgross at suse.com>
> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko at
epam.com>
> Signed-off-by: Jason Gunthorpe <jgg at mellanox.com>
> ---
>  drivers/xen/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
Juergen/Oleksandr/Xen Maintainers:

Would you take this patch through a xen related tree? The only reason
I had in this series is to make it easier to compile-test the gntdev
changes.

Since it is looking like the gntdev rework might not make it this
cycle it is probably best for you to take it.

Thanks,
Jason

On 01.11.19 19:26, Jason Gunthorpe wrote:
> On Mon, Oct 28, 2019 at 05:10:25PM -0300, Jason Gunthorpe wrote:
>> From: Jason Gunthorpe <jgg at mellanox.com>
>>
>> DMA_SHARED_BUFFER can not be enabled by the user (it represents a
library
>> set in the kernel). The kconfig convention is to use select for such
>> symbols so they are turned on implicitly when the user enables a
kconfig
>> that needs them.
>>
>> Otherwise the XEN_GNTDEV_DMABUF kconfig is overly difficult to enable.
>>
>> Fixes: 932d6562179e ("xen/gntdev: Add initial support for dma-buf
UAPI")
>> Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko at epam.com>
>> Cc: Boris Ostrovsky <boris.ostrovsky at oracle.com>
>> Cc: xen-devel at lists.xenproject.org
>> Cc: Juergen Gross <jgross at suse.com>
>> Cc: Stefano Stabellini <sstabellini at kernel.org>
>> Reviewed-by: Juergen Gross <jgross at suse.com>
>> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko at
epam.com>
>> Signed-off-by: Jason Gunthorpe <jgg at mellanox.com>
>> ---
>>   drivers/xen/Kconfig | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Juergen/Oleksandr/Xen Maintainers:
> 
> Would you take this patch through a xen related tree? The only reason
> I had in this series is to make it easier to compile-test the gntdev
> changes.
Yes, I can take it for 5.5.


Juergen