Nouveau - Oct 2019 - [PATCH TRIVIAL v2] gpu: Fix Kconfig indentation

On Mon, Oct 7, 2019 at 7:39 AM Jani Nikula <jani.nikula at
linux.intel.com> wrote:
>
> On Fri, 04 Oct 2019, Krzysztof Kozlowski <krzk at kernel.org> wrote:
> >  drivers/gpu/drm/i915/Kconfig             |  12 +-
> >  drivers/gpu/drm/i915/Kconfig.debug       | 144
+++++++++++------------
>
> Please split these out to a separate patch. Can't speak for others, but
> the patch looks like it'll be conflicts galore and a problem to manage
> if merged in one big lump.
Yes, it would be nice to have the amd patch separate as well.

Alex
>
> BR,
> Jani.
>
>
> --
> Jani Nikula, Intel Open Source Graphics Center
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

On Mon, 7 Oct 2019 at 18:09, Alex Deucher <alexdeucher at gmail.com>
wrote:
>
> On Mon, Oct 7, 2019 at 7:39 AM Jani Nikula <jani.nikula at
linux.intel.com> wrote:
> >
> > On Fri, 04 Oct 2019, Krzysztof Kozlowski <krzk at kernel.org>
wrote:
> > >  drivers/gpu/drm/i915/Kconfig             |  12 +-
> > >  drivers/gpu/drm/i915/Kconfig.debug       | 144
+++++++++++------------
> >
> > Please split these out to a separate patch. Can't speak for
others, but
> > the patch looks like it'll be conflicts galore and a problem to
manage
> > if merged in one big lump.
>
> Yes, it would be nice to have the amd patch separate as well.
I'll split the AMD and i915 although I am not sure if it is sense to
split such trivial patch per each driver.

Best regards,
Krzysztof

On Mon, 07 Oct 2019, Krzysztof Kozlowski <krzk at kernel.org>
wrote:
> On Mon, 7 Oct 2019 at 18:09, Alex Deucher <alexdeucher at gmail.com>
wrote:
>>
>> On Mon, Oct 7, 2019 at 7:39 AM Jani Nikula <jani.nikula at
linux.intel.com> wrote:
>> >
>> > On Fri, 04 Oct 2019, Krzysztof Kozlowski <krzk at
kernel.org> wrote:
>> > >  drivers/gpu/drm/i915/Kconfig             |  12 +-
>> > >  drivers/gpu/drm/i915/Kconfig.debug       | 144
+++++++++++------------
>> >
>> > Please split these out to a separate patch. Can't speak for
others, but
>> > the patch looks like it'll be conflicts galore and a problem
to manage
>> > if merged in one big lump.
>>
>> Yes, it would be nice to have the amd patch separate as well.
>
> I'll split the AMD and i915 although I am not sure if it is sense to
> split such trivial patch per each driver.
Thanks.

See MAINTAINERS, many of the drivers are maintained in the same drm-misc
repo, and it makes no difference to split those.

In general it's, well, trivial to split up patches like this per driver
or repo, but not splitting it up generates extra busywork in managing
conflicts until some common merge/backmerge happens. We just want to
apply the patch and forget about it, instead of dealing with a trivial
whitespace cleanup many times over.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center