Nouveau - Jul 2019 - [Bug 111217] New: compilation of vdpau shaders crashes in handleCVT_CVT

https://bugs.freedesktop.org/show_bug.cgi?id=111217

            Bug ID: 111217
           Summary: compilation of vdpau shaders crashes in handleCVT_CVT
           Product: Mesa
           Version: unspecified
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/nouveau
          Assignee: nouveau at lists.freedesktop.org
          Reporter: imirkin at alum.mit.edu
        QA Contact: nouveau at lists.freedesktop.org

Thread 1 "mplayer" received signal SIGSEGV, Segmentation fault.
nv50_ir::AlgebraicOpt::handleCVT_CVT(nv50_ir::Instruction*) ()
    at ../src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp:2085
2085       if (insn->saturate ||


I don't have the shader because someone decided that DEBUG setting and
optimization level must be linked. And to turn it off by default. Sigh.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20190725/cbb010cd/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=111217

--- Comment #1 from Ilia Mirkin <imirkin at alum.mit.edu> ---
OK, so ... the TGSI shader is semi-buggy. It takes an undefined value and uses
it throughout. nouveau kind of assumes that it's a function parameter (I
guess
this is basically how TGSI functions were originally spec'd out). And I
guess
we have some bugs around handling function parameters.

Simple solution: fix the tgsi.

Longer solution: think about the correct thing to do here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20190726/6f2d721d/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=111217

--- Comment #2 from rcoe at wi.rr.com ---
Is this a dup or a different issue?

Thread 25 "vlc" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffbc1a8700 (LWP 24784)]
0x00007fffaa6ccd4f in nv50_ir::AlgebraicOpt::handleCVT_CVT (this=<optimized
out>, cvt=<optimized out>) at /usr/include/c++/9/bits/stl_deque.h:270
270           _M_set_node(_Map_pointer __new_node) _GLIBCXX_NOEXCEPT
(gdb) where
#0  0x00007fffaa6ccd4f in nv50_ir::AlgebraicOpt::handleCVT_CVT
(this=<optimized
out>, cvt=<optimized out>) at /usr/include/c++/9/bits/stl_deque.h:270
#1  nv50_ir::AlgebraicOpt::visit (this=0x7fffbc1a5370, bb=<optimized out>)
at
../src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp:2351
#2  0x00007fffaa703b37 in nv50_ir::Pass::doRun (this=0x7fffbc1a5370,
func=<optimized out>, ordered=<optimized out>, skipPhi=false) at
../src/gallium/drivers/nouveau/codegen/nv50_ir_bb.cpp:495
#3  0x00007fffaa539145 in nv50_ir::Pass::doRun (skipPhi=false, ordered=false,
prog=0x0, this=0x7fffbc1a5370) at
../src/gallium/drivers/nouveau/codegen/nv50_ir_bb.cpp:466
#4  nv50_ir::Pass::run(nv50_ir::Program*, bool, bool) [clone .constprop.0]
(this=this at entry=0x7fffbc1a5370, prog=prog at entry=0x7fffa00b09c0,
skipPhi=skipPhi at entry=false, ordered=false) at
../src/gallium/drivers/nouveau/codegen/nv50_ir_bb.cpp:457
#5  0x00007fffaa6c341d in nv50_ir::Program::optimizeSSA (this=0x7fffa00b09c0,
level=3) at ../src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp:4005
#6  0x00007fffaa7181f9 in nv50_ir_generate_code (info=0x7fffa0134220) at
../src/gallium/drivers/nouveau/codegen/nv50_ir.cpp:1267
#7  0x00007fffaa6a7369 in nvc0_program_translate (prog=0x7fffa0112ff0,
chipset=<optimized out>, debug=0x7fffa00cebf8) at
../src/gallium/drivers/nouveau/nvc0/nvc0_program.c:638
#8  0x00007fffaa7647d2 in nvc0_cp_state_create (pipe=0x7fffa00ce830,
cso=0x7fffbc1a6150) at ../src/gallium/drivers/nouveau/nvc0/nvc0_context.h:292
#9  0x00007fffaa92bf12 in vl_compositor_cs_create_shader (c=0x7fffa00a8098,
compute_shader_text=<optimized out>) at
../src/gallium/auxiliary/vl/vl_compositor_cs.c:433
#10 0x00007fffaa941467 in init_shaders (c=0x7fffa00a8098) at
../src/gallium/auxiliary/vl/vl_compositor.c:74
#11 vl_compositor_init (pipe=<optimized out>, c=<optimized out>) at
../src/gallium/auxiliary/vl/vl_compositor.c:770
#12 __vaDriverInit_1_4 (ctx=0x7fffa0060240) at
../src/gallium/state_trackers/va/context.c:163

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20190726/dd1d0c8a/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=111217

--- Comment #3 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Nope, this is the same issue.

Patch series at https://patchwork.freedesktop.org/series/64282/ should fix you
right up.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20190726/3f3c5477/attachment-0001.html>

https://bugs.freedesktop.org/show_bug.cgi?id=111217

Ilia Mirkin <imirkin at alum.mit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Ilia Mirkin <imirkin at alum.mit.edu> ---
The various fixes should be pushed out to master now.

Fixed:

1. Codegen to handle CVT(non-insn-sourced-value)
2. TGSI to avoid having a CVT(undefined)
3. Codegen to not consider undefined sources as compute kernel inputs

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20190729/5de6bf3e/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=111217

Ilia Mirkin <imirkin at alum.mit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |madebr at gmail.com

--- Comment #5 from Ilia Mirkin <imirkin at alum.mit.edu> ---
*** Bug 111280 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20190801/1b3442da/attachment-0001.html>