Nouveau - Jul 2019 - [PATCH 20/22] mm: move hmm_vma_fault to nouveau

On Mon, Jul 01, 2019 at 08:20:18AM +0200, Christoph Hellwig
wrote:
> hmm_vma_fault is marked as a legacy API to get rid of, but quite suites
> the current nouvea flow.  Move it to the only user in preparation for
> fixing a locking bug involving caller and callee.
> 
> Signed-off-by: Christoph Hellwig <hch at lst.de>
>  drivers/gpu/drm/nouveau/nouveau_svm.c | 54 ++++++++++++++++++++++++++-
>  include/linux/hmm.h                   | 54 ---------------------------
>  2 files changed, 53 insertions(+), 55 deletions(-)
I was thinking about doing exactly this too, but amdgpu started using
this already obsolete API in their latest driver :(

So, we now need to get both drivers to move to the modern API.

Jason

On Wed, Jul 03, 2019 at 03:03:56PM -0300, Jason Gunthorpe
wrote:
> I was thinking about doing exactly this too, but amdgpu started using
> this already obsolete API in their latest driver :(
> 
> So, we now need to get both drivers to move to the modern API.
Actually the AMD folks fixed this up after we pointed it out to them,
so even in linux-next it just is nouveau that needs fixing.

On Wed, Jul 03, 2019 at 08:05:25PM +0200, Christoph Hellwig
wrote:
> On Wed, Jul 03, 2019 at 03:03:56PM -0300, Jason Gunthorpe wrote:
> > I was thinking about doing exactly this too, but amdgpu started using
> > this already obsolete API in their latest driver :(
> > 
> > So, we now need to get both drivers to move to the modern API.
> 
> Actually the AMD folks fixed this up after we pointed it out to them,
> so even in linux-next it just is nouveau that needs fixing.
Oh, I looked at an older -next, my mistake. Lets do it then.

Jason