Andrew Lunn
2017-Sep-13 12:09 UTC
[Nouveau] [PATCH 05/10] drivers:net: return -ENOMEM on allocation failure.
On Wed, Sep 13, 2017 at 01:02:14PM +0530, Allen Pais wrote:> Signed-off-by: Allen Pais <allen.lkml at gmail.com>Hi Allen Although correct, if you look higher up the call chain, this appears to be not so useful. rlb_initialize() is only called by bond_alb_initialize(), and it propagates the -1. That is only called by bond_open() with: if (bond_alb_initialize(bond, (BOND_MODE(bond) == BOND_MODE_ALB))) return -ENOMEM; So you might want to also modify this code, to return the return value, rather than use the hard coded ENOMEM. Since you code is OK as far as it goes: Reviewed-by: Andrew Lunn <andrew at lunn.ch> Andrew
Allen
2017-Sep-13 13:05 UTC
[Nouveau] [PATCH 05/10] drivers:net: return -ENOMEM on allocation failure.
> propagates the -1. That is only called by bond_open() with: > > if (bond_alb_initialize(bond, (BOND_MODE(bond) == BOND_MODE_ALB))) > return -ENOMEM; > > So you might want to also modify this code, to return the return > value, rather than use the hard coded ENOMEM. >I'll modify the above and send it out a separate patch. Thank you.
Maybe Matching Threads
- [PATCH 05/10] drivers:net: return -ENOMEM on allocation failure.
- [PATCH 01/10] arch:powerpc: return -ENOMEM on failed allocation
- [PATCH 05/10] drivers:net: return -ENOMEM on allocation failure.
- [PATCH 06/10] drivers:ethernet: return -ENOMEM on allocation failure.
- [PATCH 06/10] drivers:ethernet: return -ENOMEM on allocation failure.