Baoyou Xie
2016-Aug-28 07:16 UTC
[Nouveau] [PATCH] fix:nv10_fence: mark symbols static where possible
We get 1 warning about global functions without a declaration in the nouveau nv10_fence driver when building with W=1: drivers/gpu/drm/nouveau/nv10_fence.c:70:1: warning: no previous prototype for 'nv10_fence_context_new' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so this patch marks it 'static'. Signed-off-by: Baoyou Xie <baoyou.xie at linaro.org> --- drivers/gpu/drm/nouveau/nv10_fence.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nv10_fence.c b/drivers/gpu/drm/nouveau/nv10_fence.c index 4e3de34..619f79d 100644 --- a/drivers/gpu/drm/nouveau/nv10_fence.c +++ b/drivers/gpu/drm/nouveau/nv10_fence.c @@ -66,7 +66,7 @@ nv10_fence_context_del(struct nouveau_channel *chan) nouveau_fence_context_free(&fctx->base); } -int +static int nv10_fence_context_new(struct nouveau_channel *chan) { struct nv10_fence_chan *fctx; -- 2.7.4
Apparently Analagous Threads
- [PATCH 2/3] drm/nouveau: mark symbols static where possible
- [PATCH] drm/nouveau: silence warnings reported during builds with W=1
- [PATCH v2 1/2] drm/nouveau: add missing header dependencies
- [PATCH 01/17] drm/nouveau/core: add missing header dependencies
- [RFC PATCH v1 07/16] drm/nouveau: rework to new fence interface