Nouveau - Jul 2016 - [Bug 97065] New: memory leak under Xwayland with old sdl1 applications

https://bugs.freedesktop.org/show_bug.cgi?id=97065

            Bug ID: 97065
           Summary: memory leak under Xwayland with old sdl1 applications
           Product: xorg
           Version: unspecified
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Driver/nouveau
          Assignee: nouveau at lists.freedesktop.org
          Reporter: me at hussam.eu.org
        QA Contact: xorg-team at lists.x.org

Created attachment 125286
  --> https://bugs.freedesktop.org/attachment.cgi?id=125286&action=edit
first memory map.

When running old applications under wayland/nouveau, there is a memory leak in
Xwayland.
Gtk2 applications show but this it is minimal. memory is not freed when the
application exits.
Using sdl1 applications makes the leaks very high, around 300 to 400Kbytes per
minute.
I asked on #wayland on freenode and it was suggested I post memory maps.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20160724/e54460ca/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=97065

--- Comment #1 from Hussam Al-Tayeb <me at hussam.eu.org> ---
Created attachment 125287
  --> https://bugs.freedesktop.org/attachment.cgi?id=125287&action=edit
second memory map after memory increase

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20160724/44a009c8/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=97065

--- Comment #2 from Hussam Al-Tayeb <me at hussam.eu.org> ---
Created attachment 125288
  --> https://bugs.freedesktop.org/attachment.cgi?id=125288&action=edit
third memory map

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20160724/fb3b11b5/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=97065

--- Comment #3 from Hussam Al-Tayeb <me at hussam.eu.org> ---
Created attachment 125289
  --> https://bugs.freedesktop.org/attachment.cgi?id=125289&action=edit
forth memory map of xwayland process

Note that after exiting eveything, memory is not recovered.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20160724/771d040c/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=97065

--- Comment #4 from Hussam Al-Tayeb <me at hussam.eu.org> ---
Firefox nightly 50a1 also causes this but only around 200Kbytes per minute.
Still memory is not freed on closing firefox.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20160724/578c5268/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=97065

--- Comment #5 from Link Mauve <bugs at linkmauve.fr> ---
Hi again Hussam, please also run xrestop and report whether something actually
increases there.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20160724/45c36ea7/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=97065

--- Comment #6 from Hussam Al-Tayeb <me at hussam.eu.org> ---
(In reply to Link Mauve from comment #5)
> Hi again Hussam, please also run xrestop and report whether something
> actually increases there.
I tried that. Xwayland's memory usage increases without an increase in
pixmaps
memory count according to xrestop.
Simply using a sdl1, or gtk2 application or firefox slowly makes Xwayland
memory usage increase.

When I close firefox, the total pixmap memory usage according to xrestop
decreases but xwayland never frees memory. It seems to just use more as I use
my computer.
Switching windows sometimes causes an increase. It even suddenly used 200k more
while I switched between gnome-terminal and firefox.

In either case, the reading according to xrestop seems to be stable. No
increases there unless I open more applications.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20160724/d36dd9fb/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=97065

--- Comment #7 from Michel Dänzer <michel at daenzer.net> ---
The most helpful information would be from running Xwayland in valgrind
--leak-check=full.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20160725/270a98b9/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=97065

--- Comment #8 from Hussam Al-Tayeb <me at hussam.eu.org> ---
(In reply to Michel Dänzer from comment #7)
> The most helpful information would be from running Xwayland in valgrind
> --leak-check=full.
How? if I kill the current Xwayland, gnome exits.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20160725/ddf2288a/attachment-0001.html>

https://bugs.freedesktop.org/show_bug.cgi?id=97065

--- Comment #9 from Michel Dänzer <michel at daenzer.net> ---
There are a few possibilities:

* You can start a second Xwayland instance, e.g. something like

   valgrind --leak-check=full Xwayland :99 -noreset

  and then make clients connect to it by setting the environment variable
  DISPLAY=:99

* Find out how to make gnome-shell launch Xwayland in valgrind

* Do it in weston instead of in GNOME

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20160725/fce4416d/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=97065

--- Comment #10 from Hussam Al-Tayeb <me at hussam.eu.org> ---
(In reply to Michel Dänzer from comment #9)
> There are a few possibilities:
> 
> * You can start a second Xwayland instance, e.g. something like
> 
>    valgrind --leak-check=full Xwayland :99 -noreset
> 
>   and then make clients connect to it by setting the environment variable
>   DISPLAY=:99
> 
> * Find out how to make gnome-shell launch Xwayland in valgrind
> 
> * Do it in weston instead of in GNOME
I asked on irc yesterday if it is possible to start a second Xwayland instance
and I was told no.
Now I am glad it is possible to do so.
Thank you. I will try that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20160725/fa3b9d48/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=97065

--- Comment #11 from Hussam Al-Tayeb <me at hussam.eu.org> ---
Created attachment 125446
  --> https://bugs.freedesktop.org/attachment.cgi?id=125446&action=edit
valgrind log

Not very useful as I still need to recompile arch linux's packages with
debug
symbols but this is the valgrind log.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20160731/ebe059f0/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=97065

Michel Dänzer <michel at daenzer.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125446|application/octet-stream    |application/gzip
          mime type|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20160801/6324b0fd/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=97065

Michel Dänzer <michel at daenzer.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Driver/nouveau              |XWayland
            Product|xorg                        |Wayland
           Assignee|nouveau at lists.freedesktop.o |wayland-bugs at
lists.freedesk
                   |rg                          |top.org

--- Comment #12 from Michel Dänzer <michel at daenzer.net> ---
Looks like there's a leak between Xwayland and libwayland-client:

==6371== 803,664 bytes in 11,162 blocks are definitely lost in loss record
3,443 of 3,443
==6371==    at 0x4C2CA4A: calloc (in
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==6371==    by 0x5568B72: ??? (in /usr/lib/libwayland-client.so.0.3.0)
==6371==    by 0x5569094: wl_proxy_marshal_array_constructor_versioned (in
/usr/lib/libwayland-client.so.0.3.0)
==6371==    by 0x55693B9: wl_proxy_marshal_constructor (in
/usr/lib/libwayland-client.so.0.3.0)
==6371==    by 0x423BDC: ??? (in /usr/bin/Xwayland)
==6371==    by 0x5576A0: BlockHandler (in /usr/bin/Xwayland)
==6371==    by 0x586DBA: WaitForSomething (in /usr/bin/Xwayland)
==6371==    by 0x552A3D: ??? (in /usr/bin/Xwayland)
==6371==    by 0x556C62: ??? (in /usr/bin/Xwayland)
==6371==    by 0x6F0C740: (below main) (in /usr/lib/libc-2.23.so)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20160801/4e42c836/attachment.html>