Nouveau - Mar 2016 - [Bug 94727] New: nouveau/pushbuf.c:238: pushbuf_krel: Assertion `bkref` failed.

https://bugs.freedesktop.org/show_bug.cgi?id=94727

            Bug ID: 94727
           Summary: nouveau/pushbuf.c:238: pushbuf_krel: Assertion `bkref`
                    failed.
           Product: Mesa
           Version: unspecified
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/nouveau
          Assignee: nouveau at lists.freedesktop.org
          Reporter: pappadeux at gmail.com
        QA Contact: nouveau at lists.freedesktop.org

Linux, Lubuntu 16.04 beta2, x64 on Intel CPU, NVIDIA Quadro 1500M

Multithreaded OpenGL application (C++, Geant4 toolkit, 3D visualisation)

Failed to start with the message in Subj. Application is working in VMware,
same Linux version,  on top of Windows 10

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20160328/870b958b/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=94727

--- Comment #1 from Ilia Mirkin <imirkin at alum.mit.edu> ---
nouveau doesn't handle multithreaded GL usage (even if it's done by
having
separate contexts per thread). If the application has a mode which adds an
interlock to GL calls, please try enabling it. (The issue isn't with
multiple
contexts, but with concurrent use of multiple contexts.)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20160328/55dccfef/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=94727

--- Comment #2 from Mathieu Malaterre <mathieu.malaterre at gmail.com> ---
Apparently it also affects some KDE applications:
https://bugs.debian.org/822220#55

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20160525/43483402/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=94727

--- Comment #3 from Ian Whyman <thev00d00 at gentoo.org> ---
This makes any qt app using qtwebengine which "integrates chromium's
fast
moving web capabilities into Qt." crash.

Affecting me by making kmail unusable.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20160927/6cb670a5/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=94727

--- Comment #4 from Mingcong Bai <jeffbai at aosc.xyz> ---
I was also able to reproduce this issue on my PowerMac G5 with GeForce 6600LE,
but the crash was pretty random, in most of the cases this crash happened while
I was using Linthesia.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20161107/f3998032/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=94727

--- Comment #5 from Olivier Fourdan <fourdan at xfce.org> ---
This is affecting Xwayland as well, as reported downstream in Fedora 25:

    https://bugzilla.redhat.com/show_bug.cgi?id=1372878

wrt comment 1, Xwayland is not using multithreaded GL, even through glamor, is
it?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20161202/1c087dfd/attachment-0001.html>

https://bugs.freedesktop.org/show_bug.cgi?id=94727

--- Comment #6 from Olivier Fourdan <fourdan at xfce.org> ---
A full backtrace of Xwayland that led to this abort() is found in the
downstream bug here:

   https://bugzilla.redhat.com/attachment.cgi?id=1197379

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20161202/e44eb5a5/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=94727

--- Comment #7 from Ilia Mirkin <imirkin at alum.mit.edu> ---
(In reply to Olivier Fourdan from comment #5)
> This is affecting Xwayland as well, as reported downstream in Fedora 25:
> 
>     https://bugzilla.redhat.com/show_bug.cgi?id=1372878
> 
> wrt comment 1, Xwayland is not using multithreaded GL, even through glamor,
> is it?
Oh dear. That's using glamor on a nv30 (or nv40) board. The nv30 driver is
...
erm ... imperfect.

And looking back at the first comments, the Quadro 1500M appears to be a G71,
and the 6600LE is obviously some nv4x as well.

In which case these issues are just as likely to not be caused by the
multithreading stuff at all.

But you're in (limited) luck - I have a NV34 plugged in. If you can send me
an
apitrace I can replay to cause this to happen, I can investigate [and the NV34
doesn't support as much stuff as a NV4x, but I can fake it]. I'll also
stare at
the nv30_resource_copy_region code to see what it's missing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20161206/462004ad/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=94727

Ilia Mirkin <imirkin at alum.mit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|nouveau/pushbuf.c:238:      |[NV30/NV40]
                   |pushbuf_krel: Assertion     |nouveau/pushbuf.c:238:
                   |`bkref` failed.             |pushbuf_krel: Assertion
                   |                            |`bkref` failed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20161206/c2eb698f/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=94727

--- Comment #8 from Ilia Mirkin <imirkin at alum.mit.edu> ---
OK, well staring at the code didn't do me much good.

bkref == NULL means that the pushbuf thing doesn't know about the bo
we're
trying to reloc. However just a few lines above in nv30_transfer_rect_m2mf we
do

nouveau_pushbuf_refn (push, refs, 2)

which should tell it about the src/dst bo's. So either there's
concurrency
going on, or something's not working as advertised. In the no-concurrency
case,
I'd need repro steps (that can't start with "install tons of
software").

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20161206/149397b1/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=94727

--- Comment #9 from Olivier Fourdan <fourdan at xfce.org> ---
Created attachment 128368
  --> https://bugs.freedesktop.org/attachment.cgi?id=128368&action=edit
Backtrace of Xwayland on a G71

Thanks for pointing out that it was on a G71, I have been able to reproduce
using my own old G71 (Dell m1710) with Fedora 25!

Didn't have much luck trying to run Xwayland through apitrace, but I have a
corefile of Xwayland, backtrace attached, if that's of any help...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20161207/6c931ba6/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=94727

--- Comment #10 from Olivier Fourdan <fourdan at xfce.org> ---
(In reply to Ilia Mirkin from comment #7)
> [...] If you can send me an apitrace I can replay to cause this to happen,
> I can investigate [and the NV34 doesn't support as much stuff as a
NV4x,
> but I can fake it]. [...]
Ah! I managed to reproduce with apitrace \o/

   Xwayland: pushbuf.c:238: pushbuf_krel: Assertion `bkref' failed.
   apitrace: warning: caught signal 6
   apitrace: flushing trace due to an exception
   /usr/bin/../lib64/apitrace/wrappers/glxtrace.so+0x224c8c
   [...]
   apitrace: info: taking default action for signal 6

The capture is there:

https://people.freedesktop.org/~ofourdan/xwayland-apitrace.bz2

Please let me know if that helps!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20161208/190867a5/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=94727

Tomasz Paweł Gajc <tpgxyz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |98039

--- Comment #11 from Tomasz Paweł Gajc <tpgxyz at gmail.com> ---
Looks like this is very similiar to #98039


Referenced Bugs:

https://bugs.freedesktop.org/show_bug.cgi?id=98039
[Bug 98039] KMail crash on starting (nouveau-related)
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20161210/99b5d880/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=94727

Ilia Mirkin <imirkin at alum.mit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|98039                       |


Referenced Bugs:

https://bugs.freedesktop.org/show_bug.cgi?id=98039
[Bug 98039] KMail crash on starting (nouveau-related)
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20161211/8d3303a4/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=94727

--- Comment #12 from Olivier Fourdan <fourdan at xfce.org> ---
(In reply to Tomasz Paweł Gajc from comment #11)
> Looks like this is very similiar to #98039
Eventually, the assertion hit is the same, but it doesn't mean it's the
same
problem/root cause.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20161212/e6e78385/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=94727

--- Comment #13 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Olivier, can you see if this patch with mesa helps?

https://patchwork.freedesktop.org/patch/132414/

It helped in the repro of bug #99354.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20170111/871562ef/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=94727

--- Comment #14 from Olivier Fourdan <fourdan at xfce.org> ---
(In reply to Ilia Mirkin from comment #13)
> Olivier, can you see if this patch with mesa helps?
> 
> https://patchwork.freedesktop.org/patch/132414/
> 
> It helped in the repro of bug #99354.
Sure! Thanks IIlia!

The patch did not apply cleanly on top of 13.0.3 nor master though (in
src/gallium/drivers/nouveau/nvc0/nvc0_query_hw.c line 406 [1]) so I changed
"nouveau_pushbuf_space(push, 16, 2, 0);" to
"nouveau_pushbuf_space(push, 32, 3,
0);" to match the content of your patch, I hope this is right (sorry,
I'm not
familiar with this code).

But the issue is quite random and rather hard to reproduce at will, so I'll
run
with this for some time see if the issue reoccurs.

I shall also prepare a test package for Fedora downstream with the (modified)
patch included so that the original reporter can give it a try as well.


[1]
https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/drivers/nouveau/nvc0/nvc0_query_hw.c#n406
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1372878

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20170111/49ef1626/attachment-0001.html>

https://bugs.freedesktop.org/show_bug.cgi?id=94727

--- Comment #15 from Ilia Mirkin <imirkin at alum.mit.edu> ---
(In reply to Olivier Fourdan from comment #14)
> The patch did not apply cleanly on top of 13.0.3 nor master though (in
> src/gallium/drivers/nouveau/nvc0/nvc0_query_hw.c line 406 [1]) so I changed
> "nouveau_pushbuf_space(push, 16, 2, 0);" to
"nouveau_pushbuf_space(push, 32,
> 3, 0);" to match the content of your patch, I hope this is right
(sorry, I'm
> not familiar with this code).
Ah yeah, that sounds right. I have some local changes trying to fix that code
(unsuccessfully). But that in no way affects your situation - the issue there
is a functional one, not a crashing one.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20170111/911ad431/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=94727

--- Comment #16 from Olivier Fourdan <fourdan at xfce.org> ---
Haven't heard back from the original reporter downstream, but FAF (Fedora
Analysis Framework) reports thousands (literally) of similar bugs:

https://retrace.fedoraproject.org/faf/problems/2833836/

I see the patch in comment 13 has landed and is included in mesa-13.0.4, and
Fedora has an updated mesa package for 13.0.4 and, interestingly, I don't
see
any mention of 13.0.4 in the FAF report, so it could be that this patch indeed
fixes the issue with glamor/Xwayland on nv30.

Thanks again for your help, Ilia!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20170228/49daa7e7/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=94727

GitLab Migration User <gitlab-migration at fdo.invalid> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |MOVED

--- Comment #17 from GitLab Migration User <gitlab-migration at
fdo.invalid> ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/1099.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20190918/5dd7604c/attachment.html>