Nouveau - May 2014 - [Bug 78439] New: Display corruption when DP connector is reattached

https://bugs.freedesktop.org/show_bug.cgi?id=78439

          Priority: medium
            Bug ID: 78439
          Assignee: nouveau at lists.freedesktop.org
           Summary: Display corruption when DP connector is reattached
        QA Contact: xorg-team at lists.x.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: andrius at stikonas.eu
          Hardware: Other
            Status: NEW
           Version: unspecified
         Component: Driver/nouveau
           Product: xorg

Created attachment 98687
  --> https://bugs.freedesktop.org/attachment.cgi?id=98687&action=edit
dmesg

When I unplug and replug DP connector the screen becomes corrupted (until I
restart X).

I attached dmesg file. At 266s I plug DP connector, so that part of dmesg
corresponds to screen corruption. Then at 386s I restart X, so that part
corresponds to the working state.

I suppose nouveau DDX is doing something wrong because this only happens with
X. E.g. everything is fine if I start Wayland.

I'm running:
Linux kernel:        3.14.1
xf86-video-nouveau:    1.0.10
xorg-server:        1.15.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140508/4e4d018f/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

--- Comment #1 from Andrius ?tikonas <andrius at stikonas.eu> ---
Created attachment 98688
  --> https://bugs.freedesktop.org/attachment.cgi?id=98688&action=edit
vbios.rom

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140508/2095f42d/attachment-0001.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

--- Comment #2 from Andrius ?tikonas <andrius at stikonas.eu> ---
Created attachment 98689
  --> https://bugs.freedesktop.org/attachment.cgi?id=98689&action=edit
Photo of the screen.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140508/da6f4469/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

Ilia Mirkin <imirkin at alum.mit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Display corruption when DP  |[NVC1] Display corruption
                   |connector is reattached     |when DP connector is
                   |                            |reattached

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140508/f2089f64/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

--- Comment #3 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Does it fix itself if you do a suspend/resume cycle?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140521/f28067da/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

--- Comment #4 from Andrius ?tikonas <andrius at stikonas.eu> ---
I can't test with suspend to RAM. My laptop only partially suspends and then
it
is stuck in that state.

I tried it with suspend to disk. The laptop also fails to suspend, however this
time it aborts the suspend and returns to the working state with no screen
corruption. Moreover, the corruption is completely gone till the next reboot,
i.e. I can reattach connector and the display is still fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140521/6e962b5c/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

--- Comment #5 from Ilia Mirkin <imirkin at alum.mit.edu> ---
There is a substantial DP rework bound for 3.16. Can you give
http://cgit.freedesktop.org/~airlied/linux/log/?h=drm-next a shot?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140611/735a54bc/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

--- Comment #6 from Andrius ?tikonas <andrius at stikonas.eu> ---
(In reply to comment #5)
> There is a substantial DP rework bound for 3.16. Can you give
> http://cgit.freedesktop.org/~airlied/linux/log/?h=drm-next a shot?
Completely broken. Does not even start DP screen.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140612/f492bc1e/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

--- Comment #7 from Andrius ?tikonas <andrius at stikonas.eu> ---
Created attachment 100920
  --> https://bugs.freedesktop.org/attachment.cgi?id=100920&action=edit
dmesg (drm-next for 3.16)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140612/51240a44/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

--- Comment #8 from Ilia Mirkin <imirkin at alum.mit.edu> ---
That's unfortunate... would you mind providing a dmesg from a boot with

nouveau.debug=PDISP=trace,VBIOS=trace,I2C=trace,DRM=trace

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140612/45b7ab44/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

Andrius ?tikonas <andrius at stikonas.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100920|0                           |1
        is obsolete|                            |

--- Comment #9 from Andrius ?tikonas <andrius at stikonas.eu> ---
Created attachment 100923
  --> https://bugs.freedesktop.org/attachment.cgi?id=100923&action=edit
dmesg (3.16) with debug info

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140612/bfacada9/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

Andrius ?tikonas <andrius at stikonas.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100923|0                           |1
        is obsolete|                            |

--- Comment #10 from Andrius ?tikonas <andrius at stikonas.eu> ---
Created attachment 100924
  --> https://bugs.freedesktop.org/attachment.cgi?id=100924&action=edit
dmesg (3.16) with debug info

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140612/3a4667a2/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

--- Comment #11 from Ben Skeggs <skeggsb at gmail.com> ---
Would you be able to bisect nouveau between 3.15 and current -next to find
where it got worse?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140613/6a8a97c3/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

--- Comment #12 from Andrius ?tikonas <andrius at stikonas.eu> ---
(In reply to comment #11)
> Would you be able to bisect nouveau between 3.15 and current -next to find
> where it got worse?
I think so. But it might have to wait till Friday afternoon or Saturday (I
can't do this from home now).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140613/56cb7a36/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

--- Comment #13 from Andrius ?tikonas <andrius at stikonas.eu> ---
I didn't have enough time to finish bisection today but I managed to narrow
it
down, so it might already be useful. There are just two untested revisions
left.


Bad revision is 8894f4919bc43f821775db2cfff4b917871b2102
ebd6acbb068b6558735eb80aabce1e7af9e78e1e
55f083c33feb7231c7574a64cd01b0477715a370
Good revision is 13a61757db124b16cef9b8f9b60ff7337a01b398

I will finish bisecting on Monday.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140614/98550ef9/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

--- Comment #14 from Andrius ?tikonas <andrius at stikonas.eu> ---
55f083c33feb7231c7574a64cd01b0477715a370 is the first bad commit which makes
the problem worse.
    drm/nouveau/disp/dp: maintain link in response to hpd signal

    This previously worked for the most part due to userspace doing a
    modeset in response to HPD interrupts.  This will allow us to
    properly handle cases where sync is lost for other reasons, or if
    userspace isn't caring.

Also, I noticed that the original problem is only present if just DP screen is
active. If I have both DP and LVDS screens active then unplugging and plugging
back DP cable does not result in display corruption.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140616/561aa981/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

--- Comment #15 from Ben Skeggs <skeggsb at gmail.com> ---
Thanks for that.  Can I grab the same debug log, but from the (working) commit
before it too.

Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140616/4ed4f9f6/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

--- Comment #16 from Andrius ?tikonas <andrius at stikonas.eu> ---
Created attachment 101180
  --> https://bugs.freedesktop.org/attachment.cgi?id=101180&action=edit
dmesg_good

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140616/33bdda43/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

--- Comment #17 from Ben Skeggs <skeggsb at gmail.com> ---
Created attachment 101204
  --> https://bugs.freedesktop.org/attachment.cgi?id=101204&action=edit
test patch

Are you able to test whether this helps at all?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140617/cc427d2d/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

--- Comment #18 from Andrius ?tikonas <andrius at stikonas.eu> ---
Yes it helps. DP screen is no longer black.

The original issue has diminished too. The corrupted portion of the display is
three times narrower. But I haven't tested whether this patch helps or one
of
the patches after that "bad revision"
8894f4919bc43f821775db2cfff4b917871b2102.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140617/21d4c966/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

--- Comment #19 from Ben Skeggs <skeggsb at gmail.com> ---
(In reply to comment #18)
> Yes it helps. DP screen is no longer black.
> 
> The original issue has diminished too. The corrupted portion of the display
> is three times narrower. But I haven't tested whether this patch helps
or
> one of the patches after that "bad revision"
> 8894f4919bc43f821775db2cfff4b917871b2102.
Well, the interesting thing is that the "bad" patch is doing nothing
wrong.
There is a change in behaviour in that we train the link at the highest rate
supported between the display and the GPU instead of the bare minimum required
to support the mode (something which is sensible for supporting MST, and which
the NVIDIA binary driver also does).

I've seen some odd behaviour on my GF108 with one particular DP->VGA
adapter at
the high bit rate too, which the NVIDIA binary driver is also effected by,
however, I'm not sure it's the same as you're seeing.  Mine is
random, and
works a lot of the time.  The bad log *does* look like the same symptoms (the
link trains successfully, but continually drops out afterwards).

Would it be at all possible for you to try NVIDIA's driver, and see how it
does?  And, if it works, get a trace[1] of it initialising the screen? 
Hopefully in your case it works perfectly fine, and I can find something
we're
doing wrong for the high link rate.

[1] http://nouveau.freedesktop.org/wiki/MmioTrace/

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140617/e8201ce4/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

--- Comment #20 from Andrius ?tikonas <andrius at stikonas.eu> ---
I sent mmiotrace to the usual address.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140617/fd8b11de/attachment-0001.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

Andrius ?tikonas <andrius at stikonas.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98687|0                           |1
        is obsolete|                            |

--- Comment #21 from Andrius ?tikonas <andrius at stikonas.eu> ---
Created attachment 101299
  --> https://bugs.freedesktop.org/attachment.cgi?id=101299&action=edit
dmesg_dont_touch_link

dmesg with "drm/nouveau/disp/dp: don't touch link config after
success" patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140618/489156e1/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

--- Comment #22 from Andrius ?tikonas <andrius at stikonas.eu> ---
(In reply to comment #21)
> Created attachment 101299 [details]
> dmesg_dont_touch_link
> 
> dmesg with "drm/nouveau/disp/dp: don't touch link config after
success" patch
I forgot to mention that the screen is not working even with this patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140618/adaa292a/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

--- Comment #23 from Andrius ?tikonas <andrius at stikonas.eu> ---
I retested this with the newest kernel (drm-fixes branch) but the screen is
still black.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20141024/113c8379/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

Andrius Štikonas <andrius at stikonas.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100924|0                           |1
        is obsolete|                            |
 Attachment #101299|0                           |1
        is obsolete|                            |

--- Comment #24 from Andrius Štikonas <andrius at stikonas.eu> ---
Created attachment 115643
  --> https://bugs.freedesktop.org/attachment.cgi?id=115643&action=edit
dmesg.txt (higher modes)

Ilia asked to create dmesg with the following nouveau_dp_rates[] enabled:

{  648000, 0x06, 4 },
{  324000, 0x06, 2 },
{  162000, 0x06, 1 },

In this 648 mode the whole screen flickers a lot (no reattaching is necessary
to reproduce it, it happens immediately)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150508/cf132204/attachment-0001.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

--- Comment #25 from Andrius Štikonas <andrius at stikonas.eu> ---
Created attachment 115644
  --> https://bugs.freedesktop.org/attachment.cgi?id=115644&action=edit
dmesg.txt.xz (lower modes, reattaching)

only the lower modes are enabled:

{  324000, 0x06, 2 },
{  162000, 0x06, 1 }

When booting, everything starts fine. After reattaching DP connector, the right
side of the screen flickers. (Note that flickering in 648 mode is more severe,
affects the whole screen and even causes blinking of the screen)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150508/de7447f1/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

--- Comment #26 from Andrius Štikonas <andrius at stikonas.eu> ---
The screen that I used in this bug is now broken. I can't test this bug
right
now because the replacement screen that I was given does not have DP connector.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150921/5893ab42/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=78439

Andrius Štikonas <andrius at stikonas.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|NEW                         |RESOLVED

--- Comment #27 from Andrius Štikonas <andrius at stikonas.eu> ---
I'll close this because I don't have hardware any more  and nobody else
was
able to reproduce it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20160920/ebcc9e9f/attachment-0001.html>