Nouveau - Aug 2013 - [Bug 68402] New: Some elements are only rendered in top-left area

https://bugs.freedesktop.org/show_bug.cgi?id=68402

          Priority: medium
            Bug ID: 68402
          Assignee: nouveau at lists.freedesktop.org
           Summary: Some elements are only rendered in top-left area
          Severity: normal
    Classification: Unclassified
                OS: Linux (All)
          Reporter: janmlynek0 at gmail.com
          Hardware: All
            Status: NEW
           Version: git
         Component: Drivers/DRI/nouveau
           Product: Mesa

Created attachment 84412
  --> https://bugs.freedesktop.org/attachment.cgi?id=84412&action=edit
dmesg log

Ubuntu 13.04 64-bit (affects both x86 and x86_64)
Kernel - from nouveau/linux-2.6 repo - HEAD is
3b56bba6abaa70d629fccdcf8490e087ea3a1ab4
X.Org X Server 1.13.4
Mesa version e6013e4bee7ebff6b7bd2f3b95eb16e8949e228c
Family: NVC0
Chipset: GF116 (NVCF) (GTX 550 Ti)

Some elements are only rendered in top-left area of the window (screenshot to
be included). This affects both Portal and Team Fortress 2.

I've done a bisection and this is the result:

2149ce41ed6b10f7bff65d7b3f23fd03b89753e3 is the first bad commit
commit 2149ce41ed6b10f7bff65d7b3f23fd03b89753e3
Author: Christoph Bumiller <e0425955 at student.tuwien.ac.at>
Date:   Sun Sep 30 22:59:34 2012 +0200

    nv50,nvc0: fix 3d engine blit for nvc0

:040000 040000 e0f165f869fed658f574a2719d0e841dda95139e
013265106fe6e2f2dab6b20811566fa5ba1106f3 M    src

There is nothing related to this issue in dmesg, but I'll include it anyway.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130821/511e261d/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=68402

--- Comment #1 from J?n Mlynek <janmlynek0 at gmail.com> ---
Created attachment 84413
  --> https://bugs.freedesktop.org/attachment.cgi?id=84413&action=edit
screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130821/65e3c49d/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=68402

--- Comment #2 from Emil Velikov <emil.l.velikov at gmail.com> ---
Thanks for the bisect J?n

Bit short on hardware atm, so can you confirm hunk of the commit causes the
issue? I'm suspecting the last one, although there is a small chance that
it's
the second to last.

Cheers
Emil

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130821/1f2861f5/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=68402

--- Comment #3 from J?n Mlynek <janmlynek0 at gmail.com> ---
It's the last hunk that causes the issue:

BEGIN_NVC0(push, NVC0_3D(VIEWPORT_HORIZ(0)), 2);
PUSH_DATA (push, nvc0->framebuffer.width << 16);
PUSH_DATA (push, nvc0->framebuffer.height << 16);

Removing it solved the issue, so I tried to do the same thing in
current(master) code.
After removing 2 of these hunks (there is another one in commit
443b247878edd6a67adc073b0c36e2941436b9a0), the bug is not present.

I have no idea what I've broken in the process, though. :-)

-J?n

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130821/3f84d1d0/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=68402

--- Comment #4 from Emil Velikov <emil.l.velikov at gmail.com> ---
You're a star J?n

Just had a word with our main dev and he suggested that
viewport transformation is optional, whereas viewport clip rectangle must be
set before and after 3d_blit().

With that said, here is what can be done to double-check/fix this - note a
quick piglit [1] test before and after each one, plus testing of other games/gl
apps is essential.

* nuke the viewport clip rectangle (despite all odds)
* change the viewport clip rectangle - traceback and use the original values
(the ones saved at the begingin on 3d_blit() and restored at the end)
* nuke the viewport transformation
* add the conditional NV50_TIC_5_LAST_LEVEL__MASK on tic[5] in
nvc0_create_texture_view (compare vs nv50_create_texture_view)

I'm hoping that one of the last two will do the job, although chances are
that
it may be one of the first two. Either way a piglit and further testing will
prove which solution is the most appropriate.

Feel free to give it a shot yourself, as it will take a some time until I get
to it(apart from the lack of HW).

Note: depending on your luck(and other unknown to me factors) piglit may lockup
X and your system. Normally a s2r cycle is sufficient to get it back into
shape, otherwise a reboot is needed.

Cheers,
Emil

[1] http://cgit.freedesktop.org/piglit/

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130823/2eebe6df/attachment-0001.html>

https://bugs.freedesktop.org/show_bug.cgi?id=68402

Emil Velikov <emil.l.velikov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Emil Velikov <emil.l.velikov at gmail.com> ---
The issue should be resolved by commit ad4dc7723(nvc0: restore viewport after
blit), which will make it's way into the next 9.1 and 9.2 mesa release.

Feel free to reopen if above commit does not resolve the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130902/1c2d2374/attachment.html>