Nouveau - Aug 2013 - [Bug 67628] New: [BISECTED] Monitor on Display port shows distortions

https://bugs.freedesktop.org/show_bug.cgi?id=67628

          Priority: medium
            Bug ID: 67628
          Assignee: nouveau at lists.freedesktop.org
           Summary: [BISECTED] Monitor on Display port shows distortions
        QA Contact: xorg-team at lists.x.org
          Severity: major
    Classification: Unclassified
                OS: Linux (All)
          Reporter: torsten.wagner at gmail.com
          Hardware: x86-64 (AMD64)
            Status: NEW
           Version: unspecified
         Component: Driver/nouveau
           Product: xorg

Created attachment 83446
  --> https://bugs.freedesktop.org/attachment.cgi?id=83446&action=edit
Kernel bisect

Updating to a kernel > 3.8, the monitor connected via display port shows
heavy
colour distortions (see attached image). 
I bisect the kernel and it came down to patch 

5cc027f6b1ec651c18a4322ed3e30c6e9cf01e96
(drm/nv50-/disp: move DP link training to core and train from supervisor)

This makes sens, since this patch deals with display port functions. 

The problem appears during boot and hence I guess it is part of the DRM resp.
KMS part.

Attached are dmesg outputs for a working and a non-working kernel.
An image which shows the kind of distortions and the kernel bisect log.

Relevant system infos:

01:00.0 VGA compatible controller: NVIDIA Corporation GF108GL [Quadro 600] (rev
a1)
Display: DELL U2410

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130801/17db5657/attachment-0001.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #1 from Torsten Wagner <torsten.wagner at gmail.com> ---
Created attachment 83447
  --> https://bugs.freedesktop.org/attachment.cgi?id=83447&action=edit
dmesg of a working kernel

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130801/bc5e3e27/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #2 from Torsten Wagner <torsten.wagner at gmail.com> ---
Created attachment 83448
  --> https://bugs.freedesktop.org/attachment.cgi?id=83448&action=edit
dmesg of a kernel with colour problem

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130801/08576a0a/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #3 from Torsten Wagner <torsten.wagner at gmail.com> ---
Created attachment 83449
  --> https://bugs.freedesktop.org/attachment.cgi?id=83449&action=edit
image of the monitor distortion

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130801/4546ac58/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

Emil Velikov <emil.l.velikov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83449|text/plain                  |image/jpeg
          mime type|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130801/d8aa4c44/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #4 from Per Arnold Blaasmo <per.arnold at blaasmo.no> ---
I have the same problem with dual screen and displayport.
I have described it in bug #66129.

Bug #66129 was resolved for VGA displays, but not for displayport.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130830/ccf50d7e/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #5 from Ben Skeggs <skeggsb at gmail.com> ---
I wasn't able to reproduce your problem exactly, even on the same GPU. 
However, I did note additional issues which could be related.  I'll keep you
posted once I get around to looking at a fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20131031/e315e433/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #6 from Torsten Wagner <torsten.wagner at gmail.com> ---
Hi,
thanks for the info. If there is anything I could provide or test,
please let me know.
I hope it is not a monitor issue... will test this.



On 31 October 2013 05:32,  <bugzilla-daemon at freedesktop.org>
wrote:
> Comment # 5 on bug 67628 from Ben Skeggs
>
> I wasn't able to reproduce your problem exactly, even on the same GPU.
> However, I did note additional issues which could be related.  I'll
keep you
> posted once I get around to looking at a fix.
>
> ________________________________
> You are receiving this mail because:
>
> You reported the bug.
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20131031/ed4db2b4/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

Ilia Mirkin <imirkin at alum.mit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[BISECTED] Monitor on       |[NVC1] [BISECTED] Monitor
                   |Display port shows          |on Display port shows
                   |distortions                 |distortions

--- Comment #7 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Please try the kernel at nouveau/master
(http://cgit.freedesktop.org/nouveau/linux-2.6/), or drm-next. This includes a
fix for a particularly nasty bug for NVC1 specifically, which could manifest
itself in a wide variety of ways (since 3.11), as well as a few DP-related
fixes, e.g.
http://cgit.freedesktop.org/nouveau/linux-2.6/commit/?id=fa95062e052723fdeaede16af736c2bcc4cd1537
(and a couple others).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20131109/4c3ded4a/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #8 from Torsten Wagner <torsten.wagner at gmail.com> ---
Hi,

sorry for the late reply. It took me some time to test it. Unfortunately,
my test a week ago from the current git did not show any improvement. Still
the same distortion on the display connected via DisplayPort.
The only think I could think of to help now would be to connect another
monitor via display port to see whether it is just a bad combination of
display manufacture and GPU/driver.
Will try to do this within the next days.

Thanks for the help and support.

Torsten


On 9 November 2013 22:01, <bugzilla-daemon at freedesktop.org> wrote:
>  Ilia Mirkin <imirkin at alum.mit.edu> changed bug
67628<https://bugs.freedesktop.org/show_bug.cgi?id=67628>
>  What Removed Added  Summary [BISECTED] Monitor on Display port shows
> distortions [NVC1] [BISECTED] Monitor on Display port shows distortions
>
>  *Comment # 7 <https://bugs.freedesktop.org/show_bug.cgi?id=67628#c7>
on
> bug 67628 <https://bugs.freedesktop.org/show_bug.cgi?id=67628> from
Ilia
> Mirkin <imirkin at alum.mit.edu> *
>
> Please try the kernel at nouveau/master
> (http://cgit.freedesktop.org/nouveau/linux-2.6/), or drm-next. This
includes a
> fix for a particularly nasty bug for NVC1 specifically, which could
manifest
> itself in a wide variety of ways (since 3.11), as well as a few DP-related
> fixes,
e.g.http://cgit.freedesktop.org/nouveau/linux-2.6/commit/?id=fa95062e052723fdeaede16af736c2bcc4cd1537
> (and a couple others).
>
>  ------------------------------
> You are receiving this mail because:
>
>    - You reported the bug.
>
>
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20131126/d22c89bf/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #9 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Can you post boot logs of kernels with and without the problem booted with

nouveau.debug=trace drm.debug=0xe

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140205/1fde9e32/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #10 from Torsten Wagner <torsten.wagner at gmail.com> ---
Hi Ilia,
thanks for the feedback. Attached you will find the kernel log of an
working and non-working kernel.
A quick look showed that the non-working kernel reads in (or simply
log) much more data from the display port init.
The lines below can be found in the NON working kernel but not in the
working one

NOT WORKING KERNEL: (grep DP)

[    1.742406] nouveau T[   VBIOS][0000:01:00.0] 0x57ab[1]:
DP_CONDITION    0x05 0x15
[    1.742584] nouveau T[   VBIOS][0000:01:00.0] 0x591d[ ]:
DP_CONDITION    0x00 0x08
[    1.742589] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342: 2 lanes
at 270000 KB/s
[    1.742772] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342:
training pattern 1
[    1.743115] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342: config lane 0 00
[    1.743122] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342: config lane 1 00
[    1.743796] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342: status
00 00 00 00 cc cc
[    1.743797] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342: config lane 0 38
[    1.743807] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342: config lane 1 38
[    1.744478] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342: status
11 00 00 00 cc cc
[    1.744479] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342:
training pattern 2
[    1.745486] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342: status
11 00 00 00 cc cc
[    1.745487] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342: config lane 0 38
[    1.745493] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342: config lane 1 38
[    1.746432] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342: status
11 00 00 00 88 88
[    1.746432] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342: config lane 0 10
[    1.746443] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342: config lane 1 10
[    1.747381] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342: status
11 00 00 00 44 44
[    1.747382] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342: config lane 0 08
[    1.747390] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342: config lane 1 08
[    1.748330] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342: status
11 00 00 00 00 00
[    1.748331] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342: config lane 0 00
[    1.748340] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342: config lane 1 00
[    1.749301] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342: status
11 00 00 00 44 44
[    1.749301] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342: config lane 0 08
[    1.749308] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342: config lane 1 08
[    1.750265] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342: status
77 00 01 00 44 44
[    1.750265] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342: config lane 0 08
[    1.750272] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342: config lane 1 08
[    1.750596] nouveau D[   PDISP][0000:01:00.0] DP:0006:0342:
training pattern 0
[    1.751350] nouveau T[   VBIOS][0000:01:00.0] 0x58fd[0]:
DP_CONDITION    0x00 0x11


vs.

WORKING KERNEL (grep DP)

[    5.677400] nouveau T[   VBIOS][0000:01:00.0] 0x57ab[1]:
DP_CONDITION    0x05 0x15
[    5.677577] nouveau T[   VBIOS][0000:01:00.0] 0x591d[ ]:
DP_CONDITION    0x00 0x08
[    5.686368] nouveau T[   VBIOS][0000:01:00.0] 0x58fd[0]:
DP_CONDITION    0x00 0x11

As you can see, the entire PDISP part is missing not sure it is simply
not logged or it is a new feature which creates the problem.

Thanks for looking into this....


On 5 February 2014 04:21,  <bugzilla-daemon at freedesktop.org>
wrote:
> Comment # 9 on bug 67628 from Ilia Mirkin
>
> Can you post boot logs of kernels with and without the problem booted with
>
> nouveau.debug=trace drm.debug=0xe
>
> ________________________________
> You are receiving this mail because:
>
> You reported the bug.
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140205/9d2be99e/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

Michael Gulick <mgulick at mathworks.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mgulick at mathworks.com

--- Comment #12 from Michael Gulick <mgulick at mathworks.com> ---
*** Bug 74815 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140212/0e6a79ca/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #13 from Ilia Mirkin <imirkin at alum.mit.edu> ---
One thing to note, the initial comment is VERY misleading, since it lists the
wrong hash! [but the right description, which no one looks at] The correct
commit that was bisected as the cause is:

commit 0a0afd282fd715dd63d64b243299a64da14f8e8d
Author: Ben Skeggs <bskeggs at redhat.com>
Date:   Mon Feb 18 23:17:53 2013 -0500

    drm/nv50-/disp: move DP link training to core and train from supervisor

    We need to be able to do link training for PIOR-connected ANX9805 from
    the third supervisor handler (due to script ordering in the bios, can't
    have the "user" call train because some settings are overwritten
from
    the modesetting bios scripts).

    This moves link training for SOR-connected DP encoders to the second
    supervisor interrupt, *before* we call the modesetting scripts (yes,
    different ordering from PIOR is necessary).  This is useful since we
    should now be able to remove some hacks to workaround races between
    the supervisor and link training paths.

    Signed-off-by: Ben Skeggs <bskeggs at redhat.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140212/2e186d3e/attachment-0001.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #14 from Michael Gulick <mgulick at mathworks.com> ---
I have found a similar issue with the same commit, however in my case the
display port output is blank (monitor doesn't sync).  As mentioned in bug
#74815, this issue occurred on both Quadro 400 (GT216GL) and Quadro 600
(GF108FL).

Let me know if there is any additional information I can provide to help
diagnose this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140212/6e0ad424/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #15 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Please upload your VBIOS (for both cards, if it's not difficult). You can
get
it from /sys/kernel/debug/dri/0/vbios.rom

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140212/c8184c21/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #16 from Michael Gulick <mgulick at mathworks.com> ---
Created attachment 93949
  --> https://bugs.freedesktop.org/attachment.cgi?id=93949&action=edit
quadro 400 (gt216gl) vbios.rom

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140212/cf75f4fa/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #17 from Michael Gulick <mgulick at mathworks.com> ---
Created attachment 93950
  --> https://bugs.freedesktop.org/attachment.cgi?id=93950&action=edit
Quadro 600 (GF108GL) vbios.rom

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140212/fe2fa6d6/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #18 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Looking at the earlier vbios execution logs:

working:

[    5.517869] nouveau D[   PDISP][0000:01:00.0] supervisor 0x00000010
0x000002a0
[    5.517885] nouveau T[   VBIOS][0000:01:00.0] 0x568f[0]: DONE
[    5.539255] nouveau D[   PDISP][0000:01:00.0] supervisor 0x00000020
0x000002b0
[    5.539272] nouveau T[   VBIOS][0000:01:00.0] 0x5690[0]: NV_REG   
R[0x4061c00c] &= 0xfffffffe |= 0x00000001
[    5.539276] nouveau T[   VBIOS][0000:01:00.0] 0x569d[0]: NV_REG   
R[0x4061c014] &= 0xff3fffff |= 0x00c00000
[    5.539279] nouveau T[   VBIOS][0000:01:00.0] 0x56aa[0]: DONE
[    5.539332] nouveau D[   PDISP][0000:01:00.0] supervisor 0x00000040
0x000002b0

non-working:

[    1.679797] nouveau D[   PDISP][0000:01:00.0] supervisor 0x00000010
0x000002a0
[    1.679816] nouveau T[   VBIOS][0000:01:00.0] 0x568f[0]: DONE
[    1.707114] nouveau D[   PDISP][0000:01:00.0] supervisor 0x00000020
0x000002b0
[    1.707128] nouveau T[   VBIOS][0000:01:00.0] 0x5690[0]: NV_REG   
R[0x4061c00c] &= 0xfffffffe |= 0x00000001
[    1.707133] nouveau T[   VBIOS][0000:01:00.0] 0x569d[0]: NV_REG   
R[0x4061c014] &= 0xff3fffff |= 0x00c00000
[    1.707136] nouveau T[   VBIOS][0000:01:00.0] 0x56aa[0]: DONE
[    1.707162] nouveau T[   VBIOS][0000:01:00.0] 0x53c8[0]: ZM_REG_SEQUENCE   
0x04
[    1.707163] nouveau T[   VBIOS][0000:01:00.0] 0x53ce[0]:         R[0x61c00c]
= 0x01000000
[    1.707164] nouveau T[   VBIOS][0000:01:00.0] 0x53d2[0]:         R[0x61c010]
= 0x00101500
[    1.707165] nouveau T[   VBIOS][0000:01:00.0] 0x53d6[0]:         R[0x61c014]
= 0x00000000
[    1.707166] nouveau T[   VBIOS][0000:01:00.0] 0x53da[0]:         R[0x61c018]
= 0x00245af8
[    1.707166] nouveau T[   VBIOS][0000:01:00.0] 0x53de[0]: ZM_REG_SEQUENCE   
0x02
[    1.707167] nouveau T[   VBIOS][0000:01:00.0] 0x53e4[0]:         R[0x61c118]
= 0x27272727
[    1.707168] nouveau T[   VBIOS][0000:01:00.0] 0x53e8[0]:         R[0x61c11c]
= 0x00000027
[    1.707169] nouveau T[   VBIOS][0000:01:00.0] 0x53ec[0]: ZM_REG_SEQUENCE   
0x02
[    1.707169] nouveau T[   VBIOS][0000:01:00.0] 0x53f2[0]:         R[0x61c198]
= 0x27272727
[    1.707170] nouveau T[   VBIOS][0000:01:00.0] 0x53f6[0]:         R[0x61c19c]
= 0x00000027
[    1.707171] nouveau T[   VBIOS][0000:01:00.0] 0x53fa[0]: NV_REG   
R[0x61c120] &= 0xffffffff |= 0x00000000
[    1.707175] nouveau T[   VBIOS][0000:01:00.0] 0x5407[0]: NV_REG   
R[0x61c1a0] &= 0xffffffff |= 0x00000000
[    1.707178] nouveau T[   VBIOS][0000:01:00.0] 0x5414[0]: SUB_DIRECT   
0x5cb0
[    1.707179] nouveau T[   VBIOS][0000:01:00.0] 0x5cb0[1]: DONE
[    1.707180] nouveau T[   VBIOS][0000:01:00.0] 0x5417[0]: SUB_DIRECT   
0x546e
[    1.707180] nouveau T[   VBIOS][0000:01:00.0] 0x546e[1]: SUB_DIRECT   
0x4f5c
[    1.707181] nouveau T[   VBIOS][0000:01:00.0] 0x4f5c[2]: SUB_DIRECT   
0x56ab
[    1.707182] nouveau T[   VBIOS][0000:01:00.0] 0x56ab[3]: ZM_REG_SEQUENCE   
0x10
[    1.707183] nouveau T[   VBIOS][0000:01:00.0] 0x56b1[3]:        
R[0x4061c040] = 0x1f0b0000
[    1.707184] nouveau T[   VBIOS][0000:01:00.0] 0x56b5[3]:        
R[0x4061c044] = 0x1f0a0000
[    1.707184] nouveau T[   VBIOS][0000:01:00.0] 0x56b9[3]:        
R[0x4061c048] = 0x1e080000
[    1.707185] nouveau T[   VBIOS][0000:01:00.0] 0x56bd[3]:        
R[0x4061c04c] = 0x1e042000
[    1.707186] nouveau T[   VBIOS][0000:01:00.0] 0x56c1[3]:        
R[0x4061c050] = 0x00008000
[    1.707187] nouveau T[   VBIOS][0000:01:00.0] 0x56c5[3]:        
R[0x4061c054] = 0x00008000
[    1.707188] nouveau T[   VBIOS][0000:01:00.0] 0x56c9[3]:        
R[0x4061c058] = 0x00008000
[    1.707188] nouveau T[   VBIOS][0000:01:00.0] 0x56cd[3]:        
R[0x4061c05c] = 0x00008000
[    1.707189] nouveau T[   VBIOS][0000:01:00.0] 0x56d1[3]:        
R[0x4061c060] = 0x00002000
[    1.707190] nouveau T[   VBIOS][0000:01:00.0] 0x56d5[3]:        
R[0x4061c064] = 0x1f002000
[    1.707191] nouveau T[   VBIOS][0000:01:00.0] 0x56d9[3]:        
R[0x4061c068] = 0x1f0c0000
[    1.707191] nouveau T[   VBIOS][0000:01:00.0] 0x56dd[3]:        
R[0x4061c06c] = 0x1f0a0000
[    1.707192] nouveau T[   VBIOS][0000:01:00.0] 0x56e1[3]:        
R[0x4061c070] = 0x1f0b8000
[    1.707193] nouveau T[   VBIOS][0000:01:00.0] 0x56e5[3]:        
R[0x4061c074] = 0x1f0b8000
[    1.707194] nouveau T[   VBIOS][0000:01:00.0] 0x56e9[3]:        
R[0x4061c078] = 0x1f0b8000
[    1.707195] nouveau T[   VBIOS][0000:01:00.0] 0x56ed[3]:        
R[0x4061c07c] = 0x1f0b8000
[    1.707195] nouveau T[   VBIOS][0000:01:00.0] 0x56f1[3]: DONE
[    1.707196] nouveau T[   VBIOS][0000:01:00.0] 0x4f5f[2]: NV_REG   
R[0x4061c130] &= 0xffbf00ff |= 0x00400600
[    1.707201] nouveau T[   VBIOS][0000:01:00.0] 0x4f6c[2]: NV_REG   
R[0x4061c1b0] &= 0xffbf00ff |= 0x00400600
[    1.707205] nouveau T[   VBIOS][0000:01:00.0] 0x4f79[2]: NV_REG   
R[0x40614300] &= 0xfcf3ffff |= 0x00040000
[    1.707207] nouveau T[   VBIOS][0000:01:00.0] 0x4f86[2]: DONE
[    1.707208] nouveau T[   VBIOS][0000:01:00.0] 0x5471[1]: DONE
[    1.707209] nouveau T[   VBIOS][0000:01:00.0] 0x541a[0]: DONE
[    1.707486] nouveau D[   PDISP][0000:01:00.0] supervisor 0x00000040
0x000002b0
[    1.707505] nouveau T[   VBIOS][0000:01:00.0] 0x4f87[0]: SUB_DIRECT   
0x4f9c
[    1.707506] nouveau T[   VBIOS][0000:01:00.0] 0x4f9c[1]: CONDITION_TIME   
0x05 0xff
[    1.707508] nouveau T[   VBIOS][0000:01:00.0] 0x4f9f[1]:     [0x05]
(R[0x4061c030] & 0x10000000) == 0x00000000
[    1.707511] nouveau T[   VBIOS][0000:01:00.0] 0x4f9f[1]: RESUME
[    1.707512] nouveau T[   VBIOS][0000:01:00.0] 0x4fa0[1]: DONE
[    1.707512] nouveau T[   VBIOS][0000:01:00.0] 0x4f8a[0]: SUB_DIRECT   
0x4fa1
[    1.707513] nouveau T[   VBIOS][0000:01:00.0] 0x4fa1[1]: NV_REG   
R[0x4061c10c] &= 0xfffffffe |= 0x00000000
[    1.707516] nouveau T[   VBIOS][0000:01:00.0] 0x4fae[1]: DONE
[    1.707517] nouveau T[   VBIOS][0000:01:00.0] 0x4f8d[0]: DONE


And also the non-working one happens later in the driver load process... I
think. (Also the commit description mentions something about that, so not
unexpected.) What _is_ unexpected is that the non-working one executes a
boatload more scripts. Will compare the script dispatch mechanisms... perhaps
the new code is missing a 'break' somewhere.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140213/b8497d1a/attachment-0001.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #19 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Hmm... nothing _obvious_ in the code...

Torsten, could you upload your vbios? It seems like your Quadro 600 doesn't
quite line up with Michael's vbios (why would it, not like they're
identical
cards... ugh).

Alternatively, Michael, mind giving me a dmesg from before & after with

nouveau.debug=PDISP=debug,VBIOS=trace drm.debug=0xe

(and make sure to mention which machine it's on)

If it's not _too_ difficult, the before & after should be from
0a0afd282f^ and
0a0afd282f, to minimize differences due to other changes that were made.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140213/3b2bb3de/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #20 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Hmmm... the additional vbios seems to be coming from a

exec_clkcmp(priv, head, 0, pclk, &outp);

which the bad commit moved around in core/engine/disp/nv50.c, but it isn't
actually new... just moved a tad. Which begs the question... how did the old
code get out of executing exec_clkcmp (looks like no one was claiming
responsibility for generating the interrupt?), and whether it actually matters.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140213/40846a7b/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #21 from Michael Gulick <mgulick at mathworks.com> ---
Created attachment 94025
  --> https://bugs.freedesktop.org/attachment.cgi?id=94025&action=edit
dmesg - working dp - linux git 0a0afd28^

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140213/7ddd8cbd/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #22 from Michael Gulick <mgulick at mathworks.com> ---
Created attachment 94026
  --> https://bugs.freedesktop.org/attachment.cgi?id=94026&action=edit
dmesg - broken dp - linux git 0a0afd28

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140213/6a26985a/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #23 from Ilia Mirkin <imirkin at alum.mit.edu> ---
OK, those two boots are WAY more similar. Which makes the differences stand
out.

working:

[    4.217706] nouveau  [     DRM] 4 lanes at 270000 KB/s
[    4.217708] nouveau T[   VBIOS][0000:03:00.0] 0x577f[0]: ZM_REG   
R[0x4061c00c] = 0x01000300
[    4.217709] nouveau T[   VBIOS][0000:03:00.0] 0x5788[0]: DONE
[    4.218118] nouveau  [     DRM] training pattern 1
[    4.218991] nouveau  [     DRM] config lane 0 00
[    4.219000] nouveau  [     DRM] config lane 1 00
[    4.219007] nouveau  [     DRM] config lane 2 00
[    4.219014] nouveau  [     DRM] config lane 3 00
[    4.219980] nouveau  [     DRM] status 00 00 80 02 22 22
[    4.219981] nouveau  [     DRM] config lane 0 02
[    4.219990] nouveau  [     DRM] config lane 1 02
[    4.219999] nouveau  [     DRM] config lane 2 02
[    4.220008] nouveau  [     DRM] config lane 3 02
[    4.220995] nouveau  [     DRM] status 11 11 80 02 22 22
[    4.220996] nouveau  [     DRM] training pattern 2
[    4.222708] nouveau  [     DRM] status 11 11 80 02 66 66
[    4.222708] nouveau  [     DRM] config lane 0 0a
[    4.222717] nouveau  [     DRM] config lane 1 0a
[    4.222723] nouveau  [     DRM] config lane 2 0a
[    4.222730] nouveau  [     DRM] config lane 3 0a
[    4.223994] nouveau  [     DRM] status 77 77 81 02 66 66
[    4.223994] nouveau  [     DRM] config lane 0 0a
[    4.224001] nouveau  [     DRM] config lane 1 0a
[    4.224008] nouveau  [     DRM] config lane 2 0a
[    4.224015] nouveau  [     DRM] config lane 3 0a
[    4.224440] nouveau  [     DRM] training pattern 0

non-working:

[    4.371173] nouveau D[   PDISP][0000:03:00.0] DP:0006:0342: 2 lanes at
270000 KB/s
[    4.371589] nouveau T[   VBIOS][0000:03:00.0] 0x577f[0]: ZM_REG   
R[0x4061c00c] = 0x01000300
[    4.371590] nouveau T[   VBIOS][0000:03:00.0] 0x5788[0]: DONE
[    4.371596] nouveau D[   PDISP][0000:03:00.0] DP:0006:0342: training pattern
1
[    4.372470] nouveau D[   PDISP][0000:03:00.0] DP:0006:0342: config lane 0 00
[    4.372478] nouveau D[   PDISP][0000:03:00.0] DP:0006:0342: config lane 1 00
[    4.373451] nouveau D[   PDISP][0000:03:00.0] DP:0006:0342: status 00 00 80
02 22 00
[    4.373465] nouveau D[   PDISP][0000:03:00.0] DP:0006:0342: config lane 0 02
[    4.373473] nouveau D[   PDISP][0000:03:00.0] DP:0006:0342: config lane 1 02
[    4.374475] nouveau D[   PDISP][0000:03:00.0] DP:0006:0342: status 11 00 80
02 22 00
[    4.374476] nouveau D[   PDISP][0000:03:00.0] DP:0006:0342: training pattern
2
[    4.376205] nouveau D[   PDISP][0000:03:00.0] DP:0006:0342: status 11 00 80
02 66 00
[    4.376207] nouveau D[   PDISP][0000:03:00.0] DP:0006:0342: config lane 0 0a
[    4.376218] nouveau D[   PDISP][0000:03:00.0] DP:0006:0342: config lane 1 0a
[    4.377498] nouveau D[   PDISP][0000:03:00.0] DP:0006:0342: status 77 00 81
02 66 00
[    4.377499] nouveau D[   PDISP][0000:03:00.0] DP:0006:0342: config lane 0 0a
[    4.377508] nouveau D[   PDISP][0000:03:00.0] DP:0006:0342: config lane 1 0a
[    4.377934] nouveau D[   PDISP][0000:03:00.0] DP:0006:0342: training pattern
0

Note the difference in the quantity of lanes detected. No idea if this actually
matters. But that's the only difference of any significance that I can see.

Could you just fudge your nouveau_dp_train function to determine that you need
4 lanes and see if that helps?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140213/c134a32e/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #24 from Michael Gulick <mgulick at mathworks.com> ---
It looks like that function is in
drivers/gpu/drm/nouveau/core/engine/disp/dport.c, but I can't figure out how
it
should be modified to set the lane count.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140213/32d55d3a/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #25 from Ilia Mirkin <imirkin at alum.mit.edu> ---
(In reply to comment #24)
> It looks like that function is in
> drivers/gpu/drm/nouveau/core/engine/disp/dport.c, but I can't figure
out how
> it should be modified to set the lane count.
Change

        dp->link_nr = dp->dpcd[2] & DPCD_RC02_MAX_LANE_COUNT;
        while ((dp->link_nr >> 1) * link_bw[0] > datarate)
            dp->link_nr >>= 1;

To

dp->link_nr = 4;

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140213/ec4a73f3/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #26 from Michael Gulick <mgulick at mathworks.com> ---
(In reply to comment #25)
Yes, after making that change, the displayport output is working again.

I'll attach the dmesg in case you're curious.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140213/9a3a0d6b/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #27 from Michael Gulick <mgulick at mathworks.com> ---
Created attachment 94033
  --> https://bugs.freedesktop.org/attachment.cgi?id=94033&action=edit
dmesg - working dp - linux git 0a0afd28 with fixed 4 lanes

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140213/271ee81e/attachment-0001.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #28 from Ilia Mirkin <imirkin at alum.mit.edu> ---
(In reply to comment #26)
> (In reply to comment #25)
> Yes, after making that change, the displayport output is working again.
> 
> I'll attach the dmesg in case you're curious.
Fantastic!

I think what would be interesting would be adding a _ton_ of prints to that
function, basically at every step, and comparing to the old version (which
unfortunately was in a somewhat different place, but look at the diff and it
should be apparent). Reading over the code, the computations should be
identical, but perhaps there's a subtle bug somewhere, or the inputs end up
different.

If you're not up to figuring out how to do this yourself, I can try to write
up
some patches to apply to the old + new versions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140213/18f5225c/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #29 from Ilia Mirkin <imirkin at alum.mit.edu> ---
FWIW in Torsten's logs, he also went from 4x 270000 to 2x 270000. It sounds
like the value of 'bandwidth' is different now, since when forcing 4
lanes,
Michael's logs indicate 4x 162000 (and it otherwise did 2x 270000... so the
'new' bandwidth value is between 540000 and 324000, while before it must
have
been above 648000 [4x 162000]).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140213/e0497186/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #30 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Here's a crazy idea --

in drivers/gpu/drm/nouveau/core/engine/disp/nv50.c:nv50_disp_intr_unk20_2,
change

u32 ctrl = nv_rd32(priv, 0x610798 + soff);

to

u32 ctrl = nv_rd32(priv, 0x610794 + soff);

And obviously get rid of the link_nr = 4 hack.

(I'm basing this on the fact that nv50_disp_intr_unk20_2_dp reads the ctrl
value from there for figuring out the bpp.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140214/e162e19b/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

--- Comment #31 from Ilia Mirkin <imirkin at alum.mit.edu> ---
As per the response to the patch I sent, sounds like things are working for
both Michael and Torsten now:

http://lists.freedesktop.org/archives/nouveau/2014-February/016205.html

[hm, the responses aren't there yet now, but I'm sure someone will push
them
through the moderation queue eventually.]

I'll mark the bug as fixed once this hits upstream.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140214/c2a067f6/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=67628

Ilia Mirkin <imirkin at alum.mit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #32 from Ilia Mirkin <imirkin at alum.mit.edu> ---
The fix should now be upstream and will be included in the next -rc, as well as
various stable kernel trees:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=a7f1c1e65b68e1e1ab70898528d5977ed68a0a7d

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20140219/6fcf0596/attachment.html>