thr3ads.net - Nouveau - [Nouveau] [PATCH] renouveau/nv10: remove duplicate vertex buffer registers [Feb 2010]

If this information is useful, please help other people find it:
Share via:

Luca Barbieri

2010-Feb-26 19:12 UTC

[Nouveau] [PATCH] renouveau/nv10: remove duplicate vertex buffer registers

NV10TCL defines the vertex buffer registers both as arrays and as
individual named registers.

This causes duplicate register definitions and the individual registers
are not used either by the DDX or by the Mesa driver.

Francisco Jerez said to remove them all.

Signed-off-by: Luca Barbieri <luca at luca-barbieri.com>
---
 renouveau.xml |   49 -------------------------------------------------
 1 files changed, 0 insertions(+), 49 deletions(-)

diff --git a/renouveau.xml b/renouveau.xml
index 8fb35a5..3fb9d9a 100644
--- a/renouveau.xml
+++ b/renouveau.xml
@@ -2498,55 +2498,6 @@
       <bitfield name="STRIDE" high="15"
low="8" type="int"/>
       <bitfield name="POS_HOMOGENEOUS" high="24"
low="24" type="boolean"/>
     </reg32>
-
-    <reg32 offset="0x0d00"
name="VERTEX_ARRAY_OFFSET_POS" type="hexa"/>
-    <reg32 offset="0x0d04"
name="VERTEX_ARRAY_FORMAT_POS" type="bitfield">
-      <bitfield name="TYPE" high="3" low="0"
type="int"/>
-      <bitfield name="FIELDS" high="7" low="4"
type="int"/>
-      <bitfield name="STRIDE" high="15"
low="8" type="int"/>
-    </reg32>
-    <reg32 offset="0x0d08"
name="VERTEX_ARRAY_OFFSET_COL" type="hexa"/>
-    <reg32 offset="0x0d0c"
name="VERTEX_ARRAY_FORMAT_COL" type="bitfield">
-      <bitfield name="TYPE" high="3" low="0"
type="int"/>
-      <bitfield name="FIELDS" high="7" low="4"
type="int"/>
-      <bitfield name="STRIDE" high="15"
low="8" type="int"/>
-    </reg32>
-    <reg32 offset="0x0d10"
name="VERTEX_ARRAY_OFFSET_COL2" type="hexa"/>
-    <reg32 offset="0x0d14"
name="VERTEX_ARRAY_FORMAT_COL2" type="bitfield">
-      <bitfield name="TYPE" high="3" low="0"
type="int"/>
-      <bitfield name="FIELDS" high="7" low="4"
type="int"/>
-      <bitfield name="STRIDE" high="15"
low="8" type="int"/>
-    </reg32>
-    <reg32 offset="0x0d18"
name="VERTEX_ARRAY_OFFSET_TX0" type="hexa"/>
-    <reg32 offset="0x0d1c"
name="VERTEX_ARRAY_FORMAT_TX0" type="bitfield">
-      <bitfield name="TYPE" high="3" low="0"
type="int"/>
-      <bitfield name="FIELDS" high="7" low="4"
type="int"/>
-      <bitfield name="STRIDE" high="15"
low="8" type="int"/>
-    </reg32>
-    <reg32 offset="0x0d20"
name="VERTEX_ARRAY_OFFSET_TX1" type="hexa"/>
-    <reg32 offset="0x0d24"
name="VERTEX_ARRAY_FORMAT_TX1" type="bitfield">
-      <bitfield name="TYPE" high="3" low="0"
type="int"/>
-      <bitfield name="FIELDS" high="7" low="4"
type="int"/>
-      <bitfield name="STRIDE" high="15"
low="8" type="int"/>
-    </reg32>
-    <reg32 offset="0x0d28"
name="VERTEX_ARRAY_OFFSET_NOR" type="hexa"/>
-    <reg32 offset="0x0d2c"
name="VERTEX_ARRAY_FORMAT_NOR" type="bitfield">
-      <bitfield name="TYPE" high="3" low="0"
type="int"/>
-      <bitfield name="FIELDS" high="7" low="4"
type="int"/>
-      <bitfield name="STRIDE" high="15"
low="8" type="int"/>
-    </reg32>
-    <reg32 offset="0x0d30"
name="VERTEX_ARRAY_OFFSET_WGH" type="hexa"/>
-    <reg32 offset="0x0d34"
name="VERTEX_ARRAY_FORMAT_WGH" type="bitfield">
-      <bitfield name="TYPE" high="3" low="0"
type="int"/>
-      <bitfield name="FIELDS" high="7" low="4"
type="int"/>
-      <bitfield name="STRIDE" high="15"
low="8" type="int"/>
-    </reg32>
-    <reg32 offset="0x0d38"
name="VERTEX_ARRAY_OFFSET_FOG" type="hexa"/>
-    <reg32 offset="0x0d3c"
name="VERTEX_ARRAY_FORMAT_FOG" type="bitfield">
-      <bitfield name="TYPE" high="3" low="0"
type="int"/>
-      <bitfield name="FIELDS" high="7" low="4"
type="int"/>
-      <bitfield name="STRIDE" high="15"
low="8" type="int"/>
-    </reg32>
     <reg32 offset="0x0dfc" name="VERTEX_BEGIN_END"
type="enum" enum_name="nv10_begin_end"/>
     <reg32 offset="0x0e00" name="VB_ELEMENT_U16"
type="bitfield">
       <bitfield name="I0" high="15" low="0"
type="int"/>
-- 
1.6.6.1.476.g01ddb

Francisco Jerez

2010-Mar-01 01:34 UTC

head link

[Nouveau] [PATCH] renouveau/nv10: remove duplicate vertex buffer registers

Luca Barbieri <luca at luca-barbieri.com> writes:
> NV10TCL defines the vertex buffer registers both as arrays and as
> individual named registers.
>
> This causes duplicate register definitions and the individual registers
> are not used either by the DDX or by the Mesa driver.
>
> Francisco Jerez said to remove them all.
>I forgot to ask: why do they bother you?
> Signed-off-by: Luca Barbieri <luca at luca-barbieri.com>
> ---
>  renouveau.xml |   49 -------------------------------------------------
>  1 files changed, 0 insertions(+), 49 deletions(-)
>
> diff --git a/renouveau.xml b/renouveau.xml
> index 8fb35a5..3fb9d9a 100644
> --- a/renouveau.xml
> +++ b/renouveau.xml
> @@ -2498,55 +2498,6 @@
>        <bitfield name="STRIDE" high="15"
low="8" type="int"/>
>        <bitfield name="POS_HOMOGENEOUS" high="24"
low="24" type="boolean"/>
>      </reg32>
> -
> -    <reg32 offset="0x0d00"
name="VERTEX_ARRAY_OFFSET_POS" type="hexa"/>
> -    <reg32 offset="0x0d04"
name="VERTEX_ARRAY_FORMAT_POS" type="bitfield">
> -      <bitfield name="TYPE" high="3"
low="0" type="int"/>
> -      <bitfield name="FIELDS" high="7"
low="4" type="int"/>
> -      <bitfield name="STRIDE" high="15"
low="8" type="int"/>
> -    </reg32>
> -    <reg32 offset="0x0d08"
name="VERTEX_ARRAY_OFFSET_COL" type="hexa"/>
> -    <reg32 offset="0x0d0c"
name="VERTEX_ARRAY_FORMAT_COL" type="bitfield">
> -      <bitfield name="TYPE" high="3"
low="0" type="int"/>
> -      <bitfield name="FIELDS" high="7"
low="4" type="int"/>
> -      <bitfield name="STRIDE" high="15"
low="8" type="int"/>
> -    </reg32>
> -    <reg32 offset="0x0d10"
name="VERTEX_ARRAY_OFFSET_COL2" type="hexa"/>
> -    <reg32 offset="0x0d14"
name="VERTEX_ARRAY_FORMAT_COL2" type="bitfield">
> -      <bitfield name="TYPE" high="3"
low="0" type="int"/>
> -      <bitfield name="FIELDS" high="7"
low="4" type="int"/>
> -      <bitfield name="STRIDE" high="15"
low="8" type="int"/>
> -    </reg32>
> -    <reg32 offset="0x0d18"
name="VERTEX_ARRAY_OFFSET_TX0" type="hexa"/>
> -    <reg32 offset="0x0d1c"
name="VERTEX_ARRAY_FORMAT_TX0" type="bitfield">
> -      <bitfield name="TYPE" high="3"
low="0" type="int"/>
> -      <bitfield name="FIELDS" high="7"
low="4" type="int"/>
> -      <bitfield name="STRIDE" high="15"
low="8" type="int"/>
> -    </reg32>
> -    <reg32 offset="0x0d20"
name="VERTEX_ARRAY_OFFSET_TX1" type="hexa"/>
> -    <reg32 offset="0x0d24"
name="VERTEX_ARRAY_FORMAT_TX1" type="bitfield">
> -      <bitfield name="TYPE" high="3"
low="0" type="int"/>
> -      <bitfield name="FIELDS" high="7"
low="4" type="int"/>
> -      <bitfield name="STRIDE" high="15"
low="8" type="int"/>
> -    </reg32>
> -    <reg32 offset="0x0d28"
name="VERTEX_ARRAY_OFFSET_NOR" type="hexa"/>
> -    <reg32 offset="0x0d2c"
name="VERTEX_ARRAY_FORMAT_NOR" type="bitfield">
> -      <bitfield name="TYPE" high="3"
low="0" type="int"/>
> -      <bitfield name="FIELDS" high="7"
low="4" type="int"/>
> -      <bitfield name="STRIDE" high="15"
low="8" type="int"/>
> -    </reg32>
> -    <reg32 offset="0x0d30"
name="VERTEX_ARRAY_OFFSET_WGH" type="hexa"/>
> -    <reg32 offset="0x0d34"
name="VERTEX_ARRAY_FORMAT_WGH" type="bitfield">
> -      <bitfield name="TYPE" high="3"
low="0" type="int"/>
> -      <bitfield name="FIELDS" high="7"
low="4" type="int"/>
> -      <bitfield name="STRIDE" high="15"
low="8" type="int"/>
> -    </reg32>
> -    <reg32 offset="0x0d38"
name="VERTEX_ARRAY_OFFSET_FOG" type="hexa"/>
> -    <reg32 offset="0x0d3c"
name="VERTEX_ARRAY_FORMAT_FOG" type="bitfield">
> -      <bitfield name="TYPE" high="3"
low="0" type="int"/>
> -      <bitfield name="FIELDS" high="7"
low="4" type="int"/>
> -      <bitfield name="STRIDE" high="15"
low="8" type="int"/>
> -    </reg32>
>      <reg32 offset="0x0dfc" name="VERTEX_BEGIN_END"
type="enum" enum_name="nv10_begin_end"/>
>      <reg32 offset="0x0e00" name="VB_ELEMENT_U16"
type="bitfield">
>        <bitfield name="I0" high="15"
low="0" type="int"/>-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20100301/e8c6b7dc/attachment.pgp>

Luca Barbieri

2010-Mar-01 13:18 UTC

head link

[Nouveau] [PATCH] renouveau/nv10: remove duplicate vertex buffer registers

On Mon, Mar 1, 2010 at 2:34 AM, Francisco Jerez <currojerez at riseup.net>
wrote:> Luca Barbieri <luca at luca-barbieri.com> writes:
>
>> NV10TCL defines the vertex buffer registers both as arrays and as
>> individual named registers.
>>
>> This causes duplicate register definitions and the individual registers
>> are not used either by the DDX or by the Mesa driver.
>>
>> Francisco Jerez said to remove them all.
>>
> I forgot to ask: why do they bother you?
I am experimenting with rewriting renouveau-gen.c in Python, and
stored registers in a dictionary with the register offset as key.

Having multiple registers at the same offset obviously causes issues
with that, and this is the only instance of that problem, so it seems
better to remove it than adding complexity to tools to handle it.

Possibly Parallel Threads

Search for more apparently analagous threads

Nouveau - Feb 2010 - [PATCH] renouveau/nv10: remove duplicate vertex buffer registers

[Nouveau] [PATCH] renouveau/nv10: remove duplicate vertex buffer registers

[Nouveau] [PATCH] renouveau/nv10: remove duplicate vertex buffer registers

[Nouveau] [PATCH] renouveau/nv10: remove duplicate vertex buffer registers

Possibly Parallel Threads