Nouveau - Aug 2008 - [Bug 16961] New: 3298249d8267c27235653f17379f8c breaks Xv overlay ( display corruption)

http://bugs.freedesktop.org/show_bug.cgi?id=16961

           Summary: 3298249d8267c27235653f17379f8c breaks Xv overlay
                    (display corruption)
           Product: xorg
           Version: unspecified
          Platform: x86 (IA32)
        OS/Version: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Driver/nouveau
        AssignedTo: nouveau at lists.freedesktop.org
        ReportedBy: mathieu.berard at crans.org
         QAContact: xorg-team at lists.x.org


Hi,
Xv overlay has a pretty major display corruption bug which
was bisected down to commit 3298249d8267c27235653f17379f8c
(xv: reformat source so mere mortals can understand it)

Visually I see flashing bands of alternatively greed/purple colors
that seems mixed with the normal image
The corruption the not seems to affect every frame,
It more looks like something like 1 frame over 2 are corrupted, which
visually create a flashing effect.

A (bad) screenshot on a CRT monitor is attached.

The hardware is a NV20 GeForce 2 Ti 500


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=16961





--- Comment #1 from Mathieu B?rard <mathieu.berard at crans.org> 
2008-08-02 10:57:24 PST ---
Created an attachment (id=18082)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=18082)
screenshot


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=16961





--- Comment #2 from Pekka Paalanen <pq at iki.fi>  2008-08-02 12:43:58 PST
---
I have a very similar problem on nv20, but I bisected it to commit
9f53b2a341a81e1bff87fee8bf5c2754cac17849 "xv: remove drawable handling from
hw-specific PutImage.. it's common..."
http://gitweb.freedesktop.org/?p=nouveau/xf86-video-nouveau.git;a=commit;h=9f53b2a341a81e1bff87fee8bf5c2754cac17849

For me it affects only the real overlay. Blitter adapted works fine.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=16961


Mathieu B?rard <mathieu.berard at crans.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.berard at crans.org




--- Comment #3 from Mathieu B?rard <mathieu.berard at crans.org> 
2008-08-02 13:25:14 PST ---
I've checked and I can confirm that:
3298249d8267c27235653f17379f8c~1 is good
3298249d8267c27235653f17379f8c has image corruption

So there might be another bug here

The blitter adapter is also unaffected here, only video overlay


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=16961





--- Comment #4 from Danny <obiwan at mailmij.org>  2008-08-03 22:22:30 PST
---
After my statement on irc friday (as moondrake) I also did a bisect. Same
results Mathieu B?rard. But I noticed while testing that there may be at least
2 issues, so maybe pq is also right:)

Anyway, the commit is rather big, I'll go through it tonight to see what
broke.

Danny


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=16961





--- Comment #5 from Danny <obiwan at mailmij.org>  2008-08-04 06:11:59 PST
---
A brief update: I spotted one error in the xv rework that darktama has now
fixed. However, more issues may remain so it needs some testing (I try to look
into it tonight).


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=16961





--- Comment #6 from Pekka Paalanen <pq at iki.fi>  2008-08-05 05:57:44 PST
---
After darktama's fix in commit 4b24be811b839f9f836b9f8574fc808d2182dd30,
"xv:
fix thinko from when source was reformatted", the overlay now works like it
used to before this latest total breakage. So it was
3298249d8267c27235653f17379f8c after all.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=16961


Mathieu B?rard <mathieu.berard at crans.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #7 from Mathieu B?rard <mathieu.berard at crans.org> 
2008-08-05 14:40:43 PST ---
Indeed this bug is now fixed in latest git.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.