netfilter buglog - Nov 2020 - [Bug 1479] New: seqnum_to_json() is slow

https://bugzilla.netfilter.org/show_bug.cgi?id=1479

            Bug ID: 1479
           Summary: seqnum_to_json() is slow
           Product: nftables
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: nft
          Assignee: pablo at netfilter.org
          Reporter: daiderek at gmail.com

Created attachment 612
  --> https://bugzilla.netfilter.org/attachment.cgi?id=612&action=edit
solve performance issue of seqnum_to_json() by look up table

If there are a lot of command in JSON node, seqnum_to_json() will slow down
application (eg: firewalld) dramatically since it iterate whole command list
every time.

A simple look up table can solve this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20201105/29f6e592/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1479

Phil Sutter <phil at nwl.cc> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |phil at nwl.cc

--- Comment #1 from Phil Sutter <phil at nwl.cc> ---
Hi Derek,

Thanks for your patch! I took it as an example and added a hash table to keep
the json-cmd-assocs in, using seqnum as key. Thanks to include/list.h, this is
pretty simple and doesn't require much code.

Please see for yourself:

https://lore.kernel.org/netfilter-devel/20201120191640.21243-1-phil at nwl.cc/

Please give it a test to see if it resolves the performance issues you're
experiencing.

Thanks, Phil

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20201120/9925f91c/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1479

--- Comment #2 from Derek Dai <daiderek at gmail.com> ---
Hi Phil,

I have tried the patch, the issue is solved with both memory and CPU
efficiency, great job!

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20201122/b9b2136f/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1479

Phil Sutter <phil at nwl.cc> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Phil Sutter <phil at nwl.cc> ---
Fixed in commit 389a0e1edc89a ("json: echo: Speedup seqnum_to_json()")
which
should go into nftables version 0.9.8.

Thanks for the initial patch and the final testing!

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20201122/20896a7f/attachment.html>