netfilter buglog - Nov 2014 - [Bug 986] New: ulogd fails to build against linux headers >= 3.17.0 due to ULOG target removal

https://bugzilla.netfilter.org/show_bug.cgi?id=986

            Bug ID: 986
           Summary: ulogd fails to build against linux headers >= 3.17.0
                    due to ULOG target removal
           Product: ulogd
           Version: SVN (please provide timestamp)
          Hardware: x86_64
                OS: Gentoo
            Status: NEW
          Severity: major
          Priority: P5
         Component: ulogd
          Assignee: netfilter-buglog at lists.netfilter.org
          Reporter: itumaykin at gmail.com

Hello.

ULOG target was removed since 3.17.0 kernel release. See:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=7200135bc1e61f1437dc326ae2ef2f310c50b4eb

Currently, ulogd has no option to be built without ULOG support. This results
in build failures when ulogd is built against linux headers >= 3.17.0.
However,
ulogd built against older linux headers runs fine on >=3.17.0 active kernels.
Stacks that use ULOG target, of course, don't work in this case.

All ulogd2 versions are affected by this issue.

Please make ULOG support optional the same way it is with NFCT, NFLOG and
NFACCT.

Related Gentoo bug report: https://bugs.gentoo.org/show_bug.cgi?id=528310

Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20141107/1c6167cc/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=986

Pablo Neira Ayuso <pablo at netfilter.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pablo at netfilter.org

--- Comment #1 from Pablo Neira Ayuso <pablo at netfilter.org> ---
Created attachment 454
  --> https://bugzilla.netfilter.org/attachment.cgi?id=454&action=edit
fix ulogd2 compilation with >= 3.17 kernels

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20141107/c97e30d9/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=986

Pablo Neira Ayuso <pablo at netfilter.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #2 from Pablo Neira Ayuso <pablo at netfilter.org> ---
Please, give a try to the patch attached, I'll push it to master once you
confirm this resolves the issue. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20141107/0029ad82/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=986

--- Comment #3 from Coacher <itumaykin at gmail.com> ---
(In reply to Pablo Neira Ayuso from comment #2)
> Please, give a try to the patch attached, I'll push it to master once
you
> confirm this resolves the issue. Thanks.
I can confirm that current master (i.e.
4f267553aede76dc91133ba88c69f8b8faf00b72) builds fine against linux headers
3.17 with active kernel 3.17.2. Thanks.

Though ULOG-enabled stacks are not working with message from ulogd:
'<7> ulogd_inppkt_ULOG.c:288 Can't create ULOG handle'.
Certainly, they are not expected to work with kernel >= 3.17.0.
Still, it would be nice to have a possibility to build ulogd without ULOG
support at all.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20141114/9b1aa95e/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=986

--- Comment #4 from Pablo Neira Ayuso <pablo at netfilter.org> ---
(In reply to Coacher from comment #3)
> (In reply to Pablo Neira Ayuso from comment #2)
> > Please, give a try to the patch attached, I'll push it to master
once you
> > confirm this resolves the issue. Thanks.
> 
> I can confirm that current master (i.e.
> 4f267553aede76dc91133ba88c69f8b8faf00b72) builds fine against linux headers
> 3.17 with active kernel 3.17.2. Thanks.
Does this mean my patch solved your problem?

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20141114/b85e3839/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=986

--- Comment #5 from Coacher <itumaykin at gmail.com> ---
(In reply to Pablo Neira Ayuso from comment #4)
> (In reply to Coacher from comment #3)
> > (In reply to Pablo Neira Ayuso from comment #2)
> > > Please, give a try to the patch attached, I'll push it to
master once you
> > > confirm this resolves the issue. Thanks.
> > 
> > I can confirm that current master (i.e.
> > 4f267553aede76dc91133ba88c69f8b8faf00b72) builds fine against linux
headers
> > 3.17 with active kernel 3.17.2. Thanks.
> 
> Does this mean my patch solved your problem?
Yes.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20141114/bd9ad1e1/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=986

Pablo Neira Ayuso <pablo at netfilter.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Pablo Neira Ayuso <pablo at netfilter.org> ---
(In reply to Coacher from comment #5)
> (In reply to Pablo Neira Ayuso from comment #4)
> > (In reply to Coacher from comment #3)
> > > (In reply to Pablo Neira Ayuso from comment #2)
> > > > Please, give a try to the patch attached, I'll push it
to master once you
> > > > confirm this resolves the issue. Thanks.
> > > 
> > > I can confirm that current master (i.e.
> > > 4f267553aede76dc91133ba88c69f8b8faf00b72) builds fine against
linux headers
> > > 3.17 with active kernel 3.17.2. Thanks.
> > 
> > Does this mean my patch solved your problem?
> 
> Yes.
Thank you, pushed mainstream.

I'd appreciate if you can send us a patch to disable ulog support at compile
time to netfilter-devel at vger.kernel.org, no objection to such configure time
option.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20141114/410463c2/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=986

--- Comment #7 from Coacher <itumaykin at gmail.com> ---
(In reply to Pablo Neira Ayuso from comment #6)
> Thank you, pushed mainstream.
Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20141114/b6578592/attachment.html>