Masterview devel - Jun 2006 - Your keyword changes look good, lets commit them Re: What I really want for {template_path} substitution semantics

Sorry I took so long to take a look at your changes, I was preoccupied with
all the mods I was doing.

Your keyword expander changes look good, lets go ahead and turn those on.
Looks like a nice addition. The way you implemented is very clean.

Commit those whenever you are ready. Looking to do a build soon, so
let''s go
ahead and get those in.

Let me know if there are any other things you needed me to look at for this
release. Otherwise I am working on videos and we''ll need to come up
with a
nice release announcement.


On 6/16/06, Jeff Barczewski <jeff.barczewski at gmail.com>
wrote:
>
> I will take a look at your notes and code.
>
> I will make sure things are still working on my end and then test in
> windows too, to see if its one of those types of issues.
>
>
> On 6/16/06, Deb Lewis <djlewis at acm.org> wrote:
> >
> > ... is sketched out in notes and revised code in
> > branches/djl-revised-template-keywords-20060616/keyword_expander.rb
> >
> > aborted attempt to test in my app, however - reparsing/writing
generated
> > files isn''t working this morning, startup trace looks
appropriate but
> > template changes aren''t generating updated output files
> >
> > And template_file_watcher_test - writing test/tmp/views output - where
> > are
> > things going today??!  maybe due to removal of mio root-path
> >
> > ~ Deb
> >
> >
> > _______________________________________________
> > Masterview-devel mailing list
> > Masterview-devel at rubyforge.org
> > http://rubyforge.org/mailman/listinfo/masterview-devel
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://rubyforge.org/pipermail/masterview-devel/attachments/20060618/404cdd61/attachment.htm

>> Your keyword expander changes look good, lets go ahead and turn those
on.
 
ok, I''ll flip the toggle switch over the "new and improved
version" and
clean out the transition kruft when I have time tonight.
 
note to selves: directives.html need a section added to describe this new
keyword expansion feature.
 
one other possible tweak: maybe either a separate flavor of expand_keywords
or a defaulted parm so that the extra checking for whether to automatically
append .rhtml extension is only incurred by directives that need that
functionality?  (i.e., generate/import guys)
 
this would need to be hooked up in the proper places in parser/analyzer, so
I hadn''t pursued that on first round of revision proposal.
 
~ Deb
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://rubyforge.org/pipermail/masterview-devel/attachments/20060619/69d8a24d/attachment.htm

yes I agree, that would be nice for non-generate/import guys to not get the
.rhtml expansion. However I would like to hold on that till after the
release if that is ok since it is internal change.

On 6/19/06, Deb Lewis <djlewis at acm.org> wrote:
>
>  >> Your keyword expander changes look good, lets go ahead and turn
those
> on.
>
> ok, I''ll flip the toggle switch over the "new and improved
version" and
> clean out the transition kruft when I have time tonight.
>
> note to selves: directives.html need a section added to describe this new
> keyword expansion feature.
>
> one other possible tweak: maybe either a separate flavor of
> expand_keywords or a defaulted parm so that the extra checking for whether
> to automatically append .rhtml extension is only incurred by directives
that
> need that functionality?  (i.e., generate/import guys)
>
> this would need to be hooked up in the proper places in parser/analyzer,
> so I hadn''t pursued that on first round of revision proposal.
>
> ~ Deb
>
> _______________________________________________
> Masterview-devel mailing list
> Masterview-devel at rubyforge.org
> http://rubyforge.org/mailman/listinfo/masterview-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://rubyforge.org/pipermail/masterview-devel/attachments/20060619/372dde23/attachment-0001.htm

agree, we can polish that later.  I left us a comment in the code that we
should revisit when the extension-defaulting takes place, but for now
it''s
just always checked.
 
~ Deb

  _____  

From: Jeff Barczewski [mailto:jeff.barczewski at gmail.com] 
Sent: Monday, June 19, 2006 3:22 PM
To: djlewis at acm.org; masterview-devel at rubyforge.org
Subject: Re: [Masterview-devel] Your keyword changes look good, lets commit
them Re: What I really want for {template_path} substitution semantics


yes I agree, that would be nice for non-generate/import guys to not get the
.rhtml expansion. However I would like to hold on that till after the
release if that is ok since it is internal change.

-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://rubyforge.org/pipermail/masterview-devel/attachments/20060620/0b207680/attachment.htm