Your original installation description of gem install say that after installing masterview gem, running the masterview_plugin_generator will "...create a very lightweight plugin instance for this application mainly consisting of an init.rb file which will get loaded at runtime. This init.rb refers to the gem" But... I just ran script/generate masterview_plugin for an install test and it copied in the whole lib directory. I nuked lib, just to verify that it indeed wasn''t needed. So I think this is a bug in the masterview_plugin_generator, yes? Also: mv admin controller is a feature of the main masterview gem, but it''s stylesheets depend on having the mv-generator also installed. Not good, this is essentially an "up-level" dependency (fundamental component shoudn''t depend on something optionally layered on top of it) ~ Deb
Jeff Barczewski
2006-Jun-19 03:31 UTC
[Masterview-devel] Plugin generator for gem installation
The plugin generator shouldn''t have very many files to copy. Are you sure you weren''t running it on an app that already was installed as normal plugin? One would either install as gem and then script/generate the plugin (which is only coded to create a handful of files and directories). It does create a lib/masterview and a few files under there but it shouldn''t be the whole tree. I will double check but that wasn''t what I was seeing happen. I will try to verify. If you can come up with a better way for us to do these cross gem dependencies I am all ears, that was causing headaches from the beginning, I didn''t like it but couldn''t come up with a better way yet. I also didn''t like having to duplicate the files. I looked for a way to do this in svn but didn''t find one yet, so created the rake task to help with it. Would be best if we could find a way to not have those issues. Of course it all gets tricky when being able to do things from straight plugin and via gems, but I really like having both ways to install. Serves more users that way. I would think that eventually plugins will evolve to using gems, not sure why they kind of abandoned them when they were created, there are nice features in gems including versioning and dependencies. Jeff On 6/18/06, Deb Lewis <djlewis at acm.org> wrote:> > Your original installation description of gem install say that after > installing masterview gem, running the masterview_plugin_generator will > "...create a very lightweight plugin instance for this application mainly > consisting of an init.rb file which will get loaded at runtime. This > init.rb > refers to the gem" > > But... I just ran script/generate masterview_plugin for an install test > and > it copied in the whole lib directory. I nuked lib, just to verify that it > indeed wasn''t needed. > > So I think this is a bug in the masterview_plugin_generator, yes? > > Also: mv admin controller is a feature of the main masterview gem, but > it''s > stylesheets depend on having the mv-generator also installed. Not good, > this is essentially an "up-level" dependency (fundamental component > shoudn''t > depend on something optionally layered on top of it) > > ~ Deb > > > _______________________________________________ > Masterview-devel mailing list > Masterview-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/masterview-devel >-------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/masterview-devel/attachments/20060618/4919bcf8/attachment.htm
Jeff Barczewski
2006-Jun-19 04:05 UTC
[Masterview-devel] Plugin generator for gem installation
I just tried the gem plugin generator and it only created the files I would have expected, so can you verify on your end that it is doing something wrong? We do need to update the docs though because it now does add a little more than just the init. It has the default settings files and the admin controller and view files. The reas stays in the gems, but these were exposed since they might need to be changed by the users. On 6/18/06, Jeff Barczewski <jeff.barczewski at gmail.com> wrote:> > The plugin generator shouldn''t have very many files to copy. Are you sure > you weren''t running it on an app that already was installed as normal > plugin? One would either install as gem and then script/generate the plugin > (which is only coded to create a handful of files and directories). It does > create a lib/masterview and a few files under there but it shouldn''t be the > whole tree. I will double check but that wasn''t what I was seeing happen. I > will try to verify. > > > On 6/18/06, Deb Lewis <djlewis at acm.org> wrote: > > > > Your original installation description of gem install say that after > > installing masterview gem, running the masterview_plugin_generator will > > "...create a very lightweight plugin instance for this application > > mainly > > consisting of an init.rb file which will get loaded at runtime. This > > init.rb > > refers to the gem" > > > > But... I just ran script/generate masterview_plugin for an install test > > and > > it copied in the whole lib directory. I nuked lib, just to verify that > > it > > indeed wasn''t needed. > > > > So I think this is a bug in the masterview_plugin_generator, yes? > > > >-------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/masterview-devel/attachments/20060618/8b29c28c/attachment.htm
I just did rebuild of the gems today to test. Take a look at the generator rakefiles - you just changed both of them w/in the past few days to change from explicit masterview-XX-rb to "*.rb" in the include spec. Just finished working through rewrite for new doc/installation.html, after going through all the scenarios and (re)testing all the command descriptions etc. Go over it and make any changes/additions I missed on this pass (or send me reminder of which areas to fix). I don''t think I capture all the recent tweaks about admin stylesheets and auto-install of prototype settings files, we need to pick those up on another pass. Should I go ahead and start breaking up the original top-level index.html into separate doc''s or is that something you want to look at? Suggest a main intro page, stripped down to overview and links to all the key sub-docs: install, config, User''s Guide (doc/guide.html) and Directives Reference (doc/directives.html) ~ Deb _____ From: Jeff Barczewski [mailto:jeff.barczewski at gmail.com] Sent: Sunday, June 18, 2006 9:05 PM To: djlewis at acm.org; masterview-devel at rubyforge.org Subject: Re: [Masterview-devel] Plugin generator for gem installation I just tried the gem plugin generator and it only created the files I would have expected, so can you verify on your end that it is doing something wrong? We do need to update the docs though because it now does add a little more than just the init. It has the default settings files and the admin controller and view files. The reas stays in the gems, but these were exposed since they might need to be changed by the users. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/masterview-devel/attachments/20060618/5e7e41fa/attachment-0001.htm
Jeff Barczewski
2006-Jun-19 13:28 UTC
[Masterview-devel] Plugin generator for gem installation
Good catch! I did change the spec and so it probably does pull too much stuff into each gem, sorry I misunderstood you. I will go correct those specs to be specific again. I will take a look at the install guide. Yes a nice top level index for docs would be great. If you have time and want to start on this then that would be wonderful! I am heads down on videos and after that a start of a release announcement which I will run by you for approval. But you are right in that we need a structured index page for the site for the launch too. If you have time to start breaking up lets go for it. I will help once done with the other parts. Jeff On 6/18/06, Deb Lewis <djlewis at acm.org> wrote:> > I just did rebuild of the gems today to test. Take a look at the > generator rakefiles - you just changed both of them w/in the past few days > to change from explicit masterview-XX-rb to "*.rb" in the include spec. > > Just finished working through rewrite for new doc/installation.html, after > going through all the scenarios and (re)testing all the command descriptions > etc. Go over it and make any changes/additions I missed on this pass (or > send me reminder of which areas to fix). > > I don''t think I capture all the recent tweaks about admin stylesheets and > auto-install of prototype settings files, we need to pick those up on > another pass. > > Should I go ahead and start breaking up the original top-level index.htmlinto separate doc''s or is that something you want to look at? Suggest a > main intro page, stripped down to overview and links to all the key > sub-docs: install, config, User''s Guide (doc/guide.html) and Directives > Reference (doc/directives.html) > > ~ Deb >-------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/masterview-devel/attachments/20060619/9626b16b/attachment.htm