Peter Hawkins
2005-Jan-11 05:03 UTC
[Logcheck-devel] Bug#289801: Logtail should output error messages to stderr, not stdout
Package: logtail Version: 1.2.33 Severity: normal Hi... Logtail should not output error messages to standard output, since this violates the principle of least surprise. In particular, my application was broken by the semantics of logtail changing in version 1.2.21 (when you added switches for the default arguments to logtail). I think this was a bad move -- you broke an interface used by other people for no immediately apparent reason. logtail is _not_ only used by logcheck! Please consider other users of logtail next time you change something. That notwithstanding, since logtail prints its error messages to standard output, the error message about the incorrect argument format is lost. One would expect the normal usage of logtail would have been something like: logtail logfile offsetfile | some_program With the new version of logtail, this produces an error message to standard output, which is then sent to 'some_program'. I would claim that the correct behaviour is to send the message to standard error, so logtail is not silently broken by installing logtail from sarge. =) Peter
Todd Troxell
2005-Jan-11 05:38 UTC
Bug#289801: [Logcheck-devel] Bug#289801: Logtail should output error messages to stderr, not stdout
Hi Peter On Tue, Jan 11, 2005 at 04:03:22PM +1100, Peter Hawkins wrote:> Logtail should not output error messages to standard output, since this > violates the principle of least surprise.Agreed! I'll get a patch in shortly.> In particular, my application was broken by the semantics of logtail changing > in version 1.2.21 (when you added switches for the default arguments to > logtail). I think this was a bad move -- you broke an interface used by other > people for no immediately apparent reason. logtail is _not_ only used by > logcheck! Please consider other users of logtail next time you change > something.Agreed again. I will pay more attention to this in the future. I am not entirely sure why this was changed in the first place. -- [ Todd J. Troxell ,''`. Student, Debian GNU/Linux Developer, SysAdmin, Geek : :' : http://debian.org || http://rapidpacket.com/~xtat `. `' `- ] -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: Digital signature Url : http://lists.alioth.debian.org/pipermail/logcheck-devel/attachments/20050111/82a1a3f9/attachment.pgp
Debian Bug Tracking System
2005-Jan-24 03:18 UTC
[Logcheck-devel] Bug#289801: marked as done (Logtail should output error messages to stderr, not stdout)
Your message dated Sun, 23 Jan 2005 22:02:06 -0500 with message-id <E1CsuUQ-0007Wu-00 at newraff.debian.org> and subject line Bug#289801: fixed in logcheck 1.2.34 has caused the attached Bug report to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what I am talking about this indicates a serious mail system misconfiguration somewhere. Please contact me immediately.) Debian bug tracking system administrator (administrator, Debian Bugs database) -------------------------------------- Received: (at submit) by bugs.debian.org; 11 Jan 2005 05:03:29 +0000>From peter at hawkins.emu.id.au Mon Jan 10 21:03:29 2005Return-path: <peter at hawkins.emu.id.au> Received: from mail-01.iinet.net.au (mail.iinet.net.au) [203.59.3.33] by spohr.debian.org with smtp (Exim 3.35 1 (Debian)) id 1CoEBk-0000Mn-00; Mon, 10 Jan 2005 21:03:28 -0800 Received: (qmail 3477 invoked from network); 11 Jan 2005 05:03:24 -0000 Received: from unknown (HELO ?192.168.0.100?) (203.173.3.100) by mail.iinet.net.au with SMTP; 11 Jan 2005 05:03:24 -0000 From: Peter Hawkins <peter at hawkins.emu.id.au> To: submit at bugs.debian.org Subject: Logtail should output error messages to stderr, not stdout Date: Tue, 11 Jan 2005 16:03:22 +1100 User-Agent: KMail/1.7.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200501111603.22946.peter at hawkins.emu.id.au> Delivered-To: submit at bugs.debian.org X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 (1.212-2003-09-23-exp) on spohr.debian.org X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE autolearn=no version=2.60-bugs.debian.org_2005_01_02 X-Spam-Level: Package: logtail Version: 1.2.33 Severity: normal Hi... Logtail should not output error messages to standard output, since this violates the principle of least surprise. In particular, my application was broken by the semantics of logtail changing in version 1.2.21 (when you added switches for the default arguments to logtail). I think this was a bad move -- you broke an interface used by other people for no immediately apparent reason. logtail is _not_ only used by logcheck! Please consider other users of logtail next time you change something. That notwithstanding, since logtail prints its error messages to standard output, the error message about the incorrect argument format is lost. One would expect the normal usage of logtail would have been something like: logtail logfile offsetfile | some_program With the new version of logtail, this produces an error message to standard output, which is then sent to 'some_program'. I would claim that the correct behaviour is to send the message to standard error, so logtail is not silently broken by installing logtail from sarge. =) Peter --------------------------------------- Received: (at 289801-close) by bugs.debian.org; 24 Jan 2005 03:05:42 +0000>From katie at ftp-master.debian.org Sun Jan 23 19:05:42 2005Return-path: <katie at ftp-master.debian.org> Received: from newraff.debian.org [208.185.25.31] (mail) by spohr.debian.org with esmtp (Exim 3.35 1 (Debian)) id 1CsuXu-0005bh-00; Sun, 23 Jan 2005 19:05:42 -0800 Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian)) id 1CsuUQ-0007Wu-00; Sun, 23 Jan 2005 22:02:06 -0500 From: Todd Troxell <ttroxell at debian.org> To: 289801-close at bugs.debian.org X-Katie: $Revision: 1.55 $ Subject: Bug#289801: fixed in logcheck 1.2.34 Message-Id: <E1CsuUQ-0007Wu-00 at newraff.debian.org> Sender: Archive Administrator <katie at ftp-master.debian.org> Date: Sun, 23 Jan 2005 22:02:06 -0500 Delivered-To: 289801-close at bugs.debian.org X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 (1.212-2003-09-23-exp) on spohr.debian.org X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER autolearn=no version=2.60-bugs.debian.org_2005_01_02 X-Spam-Level: Source: logcheck Source-Version: 1.2.34 We believe that the bug you reported is fixed in the latest version of logcheck, which is due to be installed in the Debian FTP archive: logcheck-database_1.2.34_all.deb to pool/main/l/logcheck/logcheck-database_1.2.34_all.deb logcheck_1.2.34.dsc to pool/main/l/logcheck/logcheck_1.2.34.dsc logcheck_1.2.34.tar.gz to pool/main/l/logcheck/logcheck_1.2.34.tar.gz logcheck_1.2.34_all.deb to pool/main/l/logcheck/logcheck_1.2.34_all.deb logtail_1.2.34_all.deb to pool/main/l/logcheck/logtail_1.2.34_all.deb A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 289801 at bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Todd Troxell <ttroxell at debian.org> (supplier of updated logcheck package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmaster at debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.7 Date: Sunday, 23 Jan 2005 21:31:00 -0500 Source: logcheck Binary: logcheck logtail logcheck-database Architecture: source all Version: 1.2.34 Distribution: unstable Urgency: low Maintainer: Debian logcheck Team <logcheck-devel at lists.alioth.debian.org> Changed-By: Todd Troxell <ttroxell at debian.org> Description: logcheck - Mails anomalies in the system logfiles to the administrator logcheck-database - A database of system log rules for the use of log checkers logtail - Print log file lines that have not been read Closes: 289529 289801 289866 290195 290511 291395 Changes: logcheck (1.2.34) unstable; urgency=low . todd: * Correct "Gandhi" spelling in docs/README.how.to.interpret. Thanks Satya <debbugs at thesatya.com> (closes: #289529) * Set logtail to report errors on stderr instead of stdout. (closes: #289801) * Adjust logcheck to redirect stdout and also stderr when reporting in order to maintain the current behavior of logcheck after the change above. * Change rule directories to setgid for real this time. (closes: #291395) * Update gconf, workstation/kernel rules maks: * Add pdns, fix scponly, fix gconfd SIGHUP rule. * Fix pam_winbind rule at level workstation. (Closes: #289866) * Ignore sudo "command continued" logline. (Closes: #290195) * Add rule for daily sysklogd -r restart at level server. (Closes: #290511) jamie: * Update rules for nagios. Files: 6612f3aae699b008fbbce64951b28d74 703 admin optional logcheck_1.2.34.dsc 1042830c8ae783c69751fc99b588f943 90068 admin optional logcheck_1.2.34.tar.gz 6cd0126e9f140a2dbaf22d28b5ce08d6 42210 admin optional logcheck_1.2.34_all.deb 5fc7d09450a439eb169010993c84ac9b 57956 admin optional logcheck-database_1.2.34_all.deb 2426337abec798ed7a28ee5954f8717c 25770 admin optional logtail_1.2.34_all.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iD8DBQFB9F+E4u3oQ3FHP2YRAvaHAJ95fSajvH++jdpR2UqWiIjk7zXf3QCeJZb1 CdzEyRku0QK3EEeGm27yzUg=ACq6 -----END PGP SIGNATURE-----
Seemingly Similar Threads
- Bug#289529: logcheck: "Ghandi" should be "Gandhi" in README.how.to.interpret
- Bug#290511: logcheck: syslogd restart in cron.daily/sysklogd causes a log message
- Bug#291395: logcheck-database: Rules dirs are setuid, they should be setgid
- Bug#290195: violations.d/sudo and violations.ignore.d/logcheck-sudo missing sudo log entries
- Bug#294950: logcheck: ignore.d.server courier imaplogin: DISCONNECTED not matching