llvm dev - Nov 2021 - Proposal: Make the VE target official

On Mon, 2021-11-29 at 12:55 +0000, Renato Golin wrote:
> On Mon, 29 Nov 2021 at 12:36, Simon Moll <Simon.Moll at emea.nec.com>
> wrote:
> > > > 1. Connect the VE worker to main buildbot instance.
> > > > 2. Add `VE` to the LLVM target list, thereby making it
official
> > > > (D113247).
> > > This will trigger all bots that don't restrict targets to
build
> > > VE,
> > > and you may get some failures here already.
> > I see no harm in moving clang-ve-ninja to main buildbot while we
> > are
> > watching the ramifications play out for all builders. Builders
> > don't
> > interfere with one another. There will only be better coverage.
> > 
> 
> 
> That's not what I mean. I also see no harm in moving the VE bot
> before the move, as it's meant to be passing all the time.
> 
> What I meant is that the move to production (D113247) could break
> other bots that will build VE if they don't have an exclusive list of
> targets to build.
> 
> Not because of the VE backend, we know it's fine (due to VE's own
> buildbot). But because the other bots may have a build
> option/environment that you haven't tested and will need to be sorted
> quickly.
> 
> Most likely nothing will happen, but I'm just making sure we expect a
> potential problem, and perhaps give it a day's worth of waiting after
> moving to production to continue.
Yep. There definitely could be issues on untested build environments.
Waiting for that to play out and patching our way back to green
pastures is the final, 4th step in the plan. Steps 1-3 are all about
adding VE to the official target list and migrating the bot. That's
all. VE is on a feature freeze until all bots appear stable.
> 
> > This only matters for the clang-ve-ninja builder. The llvm-zorg
> > patch
> > moves 'VE' from the experimental target to the
targets_to_build
> > cmake
> > option for clang-ve-ninja and enables reporting on failure. This
> > will
> > not effect other bots.
> > 
> 
> 
> Ack.

On Tue, 30 Nov 2021 at 08:36, Simon Moll <Simon.Moll at emea.nec.com>
wrote:
> Yep. There definitely could be issues on untested build environments.
> Waiting for that to play out and patching our way back to green
> pastures is the final, 4th step in the plan. Steps 1-3 are all about
> adding VE to the official target list and migrating the bot. That's
> all. VE is on a feature freeze until all bots appear stable.
>
I see I misread your first proposal. LGTM, thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20211130/e57fcc90/attachment-0001.html>