Anton Korobeynikov via llvm-dev
2021-Nov-25 10:26 UTC
[llvm-dev] IMPORTANT: LLVM Bugzilla migration
FWIW: I added several workarounds to ensure that all filenames are unique within the single issue. Hopefully this will allow us to circumvent the github bug. On Tue, Nov 23, 2021 at 7:29 PM Anton Korobeynikov <anton at korobeynikov.info> wrote:> > Thanks for the bug report. I double checked all the steps and it looks > like the issue is at the github side. What we provide them is > perfectly fine and a complete dump. > > We have two options here: > > 1. Report the issue to github and wait until the issue is resolved > 2. Ignore the issue > > On Tue, Nov 23, 2021 at 7:03 PM Jessica Clarke <jrtc27 at jrtc27.com> wrote: > > > > Checking through my two open issues, I found a problem with the conversion of one of them, https://github.com/llvm/test8/issues/36461. The original bugzilla bug has two different attachments, one of which was marked obsolete, but both attachments in GitHub link to identical files, which is the obsolete one. So I see three issues with that: > > > > 1. Obsolete status is lost (one of the attachments should be shown as obsolete somehow on GitHub) > > 2. Different attachments are being merged into the same backing file > > 3. If you are going to abandon obsolete attachments, you *must* not lose the *non-obsolete* ones > > > > This seems like a pretty basic thing that should’ve been caught ages ago; the issue in question has two comments and two attachments, it’s hardly unusual. > > > > Jess > > > > > On 23 Nov 2021, at 15:49, Anton Korobeynikov via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > > > > > Dear All, > > > > > > After some heavy lifting we were able to make a repo that could be > > > served as a preview. > > > https://github.com/llvm/test8 is open for everyone with LLVM commit > > > access. The example issue in question is > > > https://github.com/llvm/test8/issues/42401 > > > > > > Please note there is no way we can make it entirely read-only and any > > > changes might trigger notifications. > > > > > > On Tue, Nov 23, 2021 at 7:11 AM Fangrui Song <maskray at google.com> wrote: > > >> > > >> On 2021-11-22, Fangrui Song wrote: > > >>> On 2021-11-22, Anton Korobeynikov via llvm-dev wrote: > > >>>>> If we can attribute it to an anonymous entity, e.g. by putting "Anonymous LLVM Contributor 123 wrote:" at the top of a comment by llvmbot, at least readers can understand whether two comments on a bug are from the same person or from different people, for example. Can we at least do something like that? > > >>>> We do this for issues. They are marked as submitted by "LLVM Bugzilla > > >>>> Contributor". > > >>>> > > >>>>> And, if such a problem exists, I think we ought to address that problem before migration. > > >>>> They had more than half a year to submit a survey and received > > >>>> multiple notifications. We are not going to delay the migration due to > > >>>> this. > > >>>> > > >>>>> I very much doubt it's true that everyone who cares will have filled it out already. I mean, just speaking for myself...I think I filled out the form? But maybe I only intended to, but forgot to get around to it? Who knows. Assuming I actually did, I'm certain there are more people in the same situation who actually did _not_. > > >>>> Well, you can simply go and submit it once again. We will certainly > > >>>> take care of dups. > > >>>> > > >>>>> Some other questions that pop into my mind: > > >>>> Great! Thanks for the questions. Probably they should have asked 2 > > >>>> years ago. You will be able to check the results by yourself after the > > >>>> migration. > > >>>> > > >>> > > >>> Thank for all your hard work! This issue tracker system has been a pain > > >>> for so many people for years. > > >>> > > >>> I think having a small-scale review of the post-migration github > > >>> repository can be very useful. It can be 1% (or larger?) of the current > > >>> ~53000 issues. People will have some idea what the repository will look > > >>> like, e.g. what portion of issues are anonymous. > > >> > > >> Extra points that a preview will be useful. We can know: > > >> (use https://bugs.llvm.org/show_bug.cgi?id=42401 as an example) > > >> > > >> * How "Status: RESOLVED DUPLICATE of bug 40482" is rendered. > > >> * How "Bug 40482" (there are various forms, e.g. "bug 40482", "PR40482") is rendered. In Bugzilla this translates to https://llvm.org/PR40482 > > >> * How Product/Component map to GitHub tags. > > >> * How attachments are rendered. In Bugzilla "Created attachment 22156 [details]" is a hyperlink. I assume that the attachments will just point back to bugs.llvm.org, which will become a static content website in the future. > > >> * How anonymous contributors are suffixed with unique numbers. > > >> > > >>>> James: I imagine it'd be pretty easy for folks to forget that they didn't fill out the sheet, since there's no way to verify whether you did or not." > > >>> > > >>> Agree. Deep Majumder asked the requestion in the thread. A colleague of > > >>> mine asked the same question. > > >>> > > >>> I just visited the Bugzilla / GitHub username mapping form and re-submitted my mapping > > >>> https://docs.google.com/forms/d/e/1FAIpQLSdUSCK-Rgl9H-8Ua0yat1KL1yELChxkJk15SfhnwPnIexTQUw/viewform > > >>> There is no email confirmation. > > >>> > > >>> A contributor may have multiple email addresses. They may not submit > > >>> their bugzilla email address or they may miss the notification to their > > >>> not-regularly-used email address (possible due to closed registration for > > >>> a long time). > > >>> > > >>> Yesterday I read > > >>> https://blog.llvm.org/posts/2021-11-18-relicensing-update/ and notified > > >>> 3 friends who were on the long-tail spreadsheet. Two of them are still > > >>> contributing and told me that they missed the email notification because they > > >>> had changed their primary email address. I am going to ask them whether > > >>> they have submitted the mapping form... > > >>> > > >>> > > >>> I think bugs.llvm.org has a local patch to display the banner: > > >>> "New user self-registration is disabled due to spam. For an account please email bugs-admin at lists.llvm.org with your e-mail address and full name." > > >>> > > >>> Could the banner be toggled a bit to remind the user and show the Bugzilla / GitHub usernam mapping if submitted? > > > > > > > > > > > > -- > > > With best regards, Anton Korobeynikov > > > Department of Statistical Modelling, Saint Petersburg State University > > > _______________________________________________ > > > LLVM Developers mailing list > > > llvm-dev at lists.llvm.org > > > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > > > > > -- > With best regards, Anton Korobeynikov > Department of Statistical Modelling, Saint Petersburg State University-- With best regards, Anton Korobeynikov Department of Statistical Modelling, Saint Petersburg State University
Anton Korobeynikov via llvm-dev
2021-Nov-28 15:17 UTC
[llvm-dev] IMPORTANT: LLVM Bugzilla migration
Hello I double checked and the workaround worked. Now attachments are different (in the final migration) On Thu, Nov 25, 2021 at 1:26 PM Anton Korobeynikov <anton at korobeynikov.info> wrote:> > FWIW: I added several workarounds to ensure that all filenames are > unique within the single issue. Hopefully this will allow us to > circumvent the github bug. > > > On Tue, Nov 23, 2021 at 7:29 PM Anton Korobeynikov > <anton at korobeynikov.info> wrote: > > > > Thanks for the bug report. I double checked all the steps and it looks > > like the issue is at the github side. What we provide them is > > perfectly fine and a complete dump. > > > > We have two options here: > > > > 1. Report the issue to github and wait until the issue is resolved > > 2. Ignore the issue > > > > On Tue, Nov 23, 2021 at 7:03 PM Jessica Clarke <jrtc27 at jrtc27.com> wrote: > > > > > > Checking through my two open issues, I found a problem with the conversion of one of them, https://github.com/llvm/test8/issues/36461. The original bugzilla bug has two different attachments, one of which was marked obsolete, but both attachments in GitHub link to identical files, which is the obsolete one. So I see three issues with that: > > > > > > 1. Obsolete status is lost (one of the attachments should be shown as obsolete somehow on GitHub) > > > 2. Different attachments are being merged into the same backing file > > > 3. If you are going to abandon obsolete attachments, you *must* not lose the *non-obsolete* ones > > > > > > This seems like a pretty basic thing that should’ve been caught ages ago; the issue in question has two comments and two attachments, it’s hardly unusual. > > > > > > Jess > > > > > > > On 23 Nov 2021, at 15:49, Anton Korobeynikov via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > > > > > > > Dear All, > > > > > > > > After some heavy lifting we were able to make a repo that could be > > > > served as a preview. > > > > https://github.com/llvm/test8 is open for everyone with LLVM commit > > > > access. The example issue in question is > > > > https://github.com/llvm/test8/issues/42401 > > > > > > > > Please note there is no way we can make it entirely read-only and any > > > > changes might trigger notifications. > > > > > > > > On Tue, Nov 23, 2021 at 7:11 AM Fangrui Song <maskray at google.com> wrote: > > > >> > > > >> On 2021-11-22, Fangrui Song wrote: > > > >>> On 2021-11-22, Anton Korobeynikov via llvm-dev wrote: > > > >>>>> If we can attribute it to an anonymous entity, e.g. by putting "Anonymous LLVM Contributor 123 wrote:" at the top of a comment by llvmbot, at least readers can understand whether two comments on a bug are from the same person or from different people, for example. Can we at least do something like that? > > > >>>> We do this for issues. They are marked as submitted by "LLVM Bugzilla > > > >>>> Contributor". > > > >>>> > > > >>>>> And, if such a problem exists, I think we ought to address that problem before migration. > > > >>>> They had more than half a year to submit a survey and received > > > >>>> multiple notifications. We are not going to delay the migration due to > > > >>>> this. > > > >>>> > > > >>>>> I very much doubt it's true that everyone who cares will have filled it out already. I mean, just speaking for myself...I think I filled out the form? But maybe I only intended to, but forgot to get around to it? Who knows. Assuming I actually did, I'm certain there are more people in the same situation who actually did _not_. > > > >>>> Well, you can simply go and submit it once again. We will certainly > > > >>>> take care of dups. > > > >>>> > > > >>>>> Some other questions that pop into my mind: > > > >>>> Great! Thanks for the questions. Probably they should have asked 2 > > > >>>> years ago. You will be able to check the results by yourself after the > > > >>>> migration. > > > >>>> > > > >>> > > > >>> Thank for all your hard work! This issue tracker system has been a pain > > > >>> for so many people for years. > > > >>> > > > >>> I think having a small-scale review of the post-migration github > > > >>> repository can be very useful. It can be 1% (or larger?) of the current > > > >>> ~53000 issues. People will have some idea what the repository will look > > > >>> like, e.g. what portion of issues are anonymous. > > > >> > > > >> Extra points that a preview will be useful. We can know: > > > >> (use https://bugs.llvm.org/show_bug.cgi?id=42401 as an example) > > > >> > > > >> * How "Status: RESOLVED DUPLICATE of bug 40482" is rendered. > > > >> * How "Bug 40482" (there are various forms, e.g. "bug 40482", "PR40482") is rendered. In Bugzilla this translates to https://llvm.org/PR40482 > > > >> * How Product/Component map to GitHub tags. > > > >> * How attachments are rendered. In Bugzilla "Created attachment 22156 [details]" is a hyperlink. I assume that the attachments will just point back to bugs.llvm.org, which will become a static content website in the future. > > > >> * How anonymous contributors are suffixed with unique numbers. > > > >> > > > >>>> James: I imagine it'd be pretty easy for folks to forget that they didn't fill out the sheet, since there's no way to verify whether you did or not." > > > >>> > > > >>> Agree. Deep Majumder asked the requestion in the thread. A colleague of > > > >>> mine asked the same question. > > > >>> > > > >>> I just visited the Bugzilla / GitHub username mapping form and re-submitted my mapping > > > >>> https://docs.google.com/forms/d/e/1FAIpQLSdUSCK-Rgl9H-8Ua0yat1KL1yELChxkJk15SfhnwPnIexTQUw/viewform > > > >>> There is no email confirmation. > > > >>> > > > >>> A contributor may have multiple email addresses. They may not submit > > > >>> their bugzilla email address or they may miss the notification to their > > > >>> not-regularly-used email address (possible due to closed registration for > > > >>> a long time). > > > >>> > > > >>> Yesterday I read > > > >>> https://blog.llvm.org/posts/2021-11-18-relicensing-update/ and notified > > > >>> 3 friends who were on the long-tail spreadsheet. Two of them are still > > > >>> contributing and told me that they missed the email notification because they > > > >>> had changed their primary email address. I am going to ask them whether > > > >>> they have submitted the mapping form... > > > >>> > > > >>> > > > >>> I think bugs.llvm.org has a local patch to display the banner: > > > >>> "New user self-registration is disabled due to spam. For an account please email bugs-admin at lists.llvm.org with your e-mail address and full name." > > > >>> > > > >>> Could the banner be toggled a bit to remind the user and show the Bugzilla / GitHub usernam mapping if submitted? > > > > > > > > > > > > > > > > -- > > > > With best regards, Anton Korobeynikov > > > > Department of Statistical Modelling, Saint Petersburg State University > > > > _______________________________________________ > > > > LLVM Developers mailing list > > > > llvm-dev at lists.llvm.org > > > > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > > > > > > > > > -- > > With best regards, Anton Korobeynikov > > Department of Statistical Modelling, Saint Petersburg State University > > > > -- > With best regards, Anton Korobeynikov > Department of Statistical Modelling, Saint Petersburg State University-- With best regards, Anton Korobeynikov Department of Statistical Modelling, Saint Petersburg State University