llvm dev - Nov 2021 - clang-tidy pre-merge checks in Phabricator not working?

Did you have clang-format in your path when you committed your patch to
Phabricator? I've observed no Lint remarks in Phabricator reviews if I
didn’t set the path.

Thanks
Phoebe (Pengfei)

From: llvm-dev <llvm-dev-bounces at lists.llvm.org> On Behalf Of James
Henderson via llvm-dev
Sent: Monday, November 22, 2021 5:06 PM
To: llvm-dev <llvm-dev at lists.llvm.org>
Subject: [llvm-dev] clang-tidy pre-merge checks in Phabricator not working?

Hi,

No idea who to direct this towards, but we at one point had clang-tidy linter
remarks in Phabricator reviews, just like we have clang-format notes. However,
I've seen several cases in recent reviews where clang-tidy hasn't
complained about violations (specifically to do with function and variable name
casing). Has this been disabled deliberately or is it supposed to be working,
but isn't for some reason?

James
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20211122/50db6a34/attachment.html>

This isn't in reviews I've been uploading, but rather reviews that
I've
been reviewing. I was under the impression that this was done on
Phabricator's end - I use the web UI to upload patches, and don't have
clang-format (or clang-tidy) in my path, but I've seen clang-format linter
remarks at least on patches I've uploaded.

On Mon, 22 Nov 2021 at 09:28, Wang, Pengfei <pengfei.wang at intel.com>
wrote:
> Did you have clang-format in your path when you committed your patch to
> Phabricator? I've observed no Lint remarks in Phabricator reviews if I
> didn’t set the path.
>
>
>
> Thanks
>
> Phoebe (Pengfei)
>
>
>
> *From:* llvm-dev <llvm-dev-bounces at lists.llvm.org> *On Behalf Of
*James
> Henderson via llvm-dev
> *Sent:* Monday, November 22, 2021 5:06 PM
> *To:* llvm-dev <llvm-dev at lists.llvm.org>
> *Subject:* [llvm-dev] clang-tidy pre-merge checks in Phabricator not
> working?
>
>
>
> Hi,
>
>
>
> No idea who to direct this towards, but we at one point had clang-tidy
> linter remarks in Phabricator reviews, just like we have clang-format
> notes. However, I've seen several cases in recent reviews where
clang-tidy
> hasn't complained about violations (specifically to do with function
and
> variable name casing). Has this been disabled deliberately or is it
> supposed to be working, but isn't for some reason?
>
>
>
> James
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20211122/c65c2997/attachment.html>