llvm dev - Nov 2021 - Accidental Remote Branches Created on Github

This happening was actually a big fear for me when I got commit access,
especially since I'm working on a fork for my hobby osdev project, not at
all ready for upstreaming it - one wrong git push away

Seeing this happening to other people is a bit of a relief 

Is it possible to configure GitHub to forbid that? Like everything except the
normal branches being protected from pushes?

Mara

Am 6. November 2021 00:48:49 UTC schrieb Luke Benes via llvm-dev <llvm-dev at
lists.llvm.org>:
>A branch containing the D112590 patch was accidentally pushed to GitHub:
https://github.com/llvm/llvm-project/tree/efb284c07e
>
>In the past couple of weeks, this also happened for 
>https://reviews.llvm.org/D107347
>and 
>https://reviews.llvm.org/D108319
>
>This seems to be happening a lot recently. Is there a problem with the
instructions to commit patches?
>
>_______________________________________________
>LLVM Developers mailing list
>llvm-dev at lists.llvm.org
>https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
-- 
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

I've done this once or twice accidentally in the past (and noticed
immediately/deleted). It is very easy to do :/

On Fri, Nov 5, 2021, 5:56 PM Mara Sophie Grosch via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
> This happening was actually a big fear for me when I got commit access,
> especially since I'm working on a fork for my hobby osdev project, not
at
> all ready for upstreaming it - one wrong git push away
>
> Seeing this happening to other people is a bit of a relief
>
> Is it possible to configure GitHub to forbid that? Like everything except
> the normal branches being protected from pushes?
>
> Mara
>
> Am 6. November 2021 00:48:49 UTC schrieb Luke Benes via llvm-dev <
> llvm-dev at lists.llvm.org>:
> >A branch containing the D112590 patch was accidentally pushed to
GitHub:
> https://github.com/llvm/llvm-project/tree/efb284c07e
> >
> >In the past couple of weeks, this also happened for
> >https://reviews.llvm.org/D107347
> >and
> >https://reviews.llvm.org/D108319
> >
> >This seems to be happening a lot recently. Is there a problem with the
> instructions to commit patches?
> >
> >_______________________________________________
> >LLVM Developers mailing list
> >llvm-dev at lists.llvm.org
> >https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
> --
> Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20211105/888b1d2e/attachment.html>

On Fri, Nov 5, 2021 at 5:56 PM Mara Sophie Grosch via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
> This happening was actually a big fear for me when I got commit access,
> especially since I'm working on a fork for my hobby osdev project, not
at
> all ready for upstreaming it - one wrong git push away
>
> Seeing this happening to other people is a bit of a relief
>
> Is it possible to configure GitHub to forbid that? Like everything except
> the normal branches being protected from pushes?
>
Unfortunately not: there is a "branch protection" mechanism on GitHub
but
it applies only to branches after they are created as far as I know.

Pushing a random branch has little consequence, it is easy to delete:
pushing the wrong kind of things to the main branch would be more annoying
and hard-to-impossible to recover from.

Cheers,

-- 
Mehdi


>
> Mara
>
> Am 6. November 2021 00:48:49 UTC schrieb Luke Benes via llvm-dev <
> llvm-dev at lists.llvm.org>:
> >A branch containing the D112590 patch was accidentally pushed to
GitHub:
> https://github.com/llvm/llvm-project/tree/efb284c07e
> >
> >In the past couple of weeks, this also happened for
> >https://reviews.llvm.org/D107347
> >and
> >https://reviews.llvm.org/D108319
> >
> >This seems to be happening a lot recently. Is there a problem with the
> instructions to commit patches?
> >
> >_______________________________________________
> >LLVM Developers mailing list
> >llvm-dev at lists.llvm.org
> >https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
> --
> Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20211105/573af6cb/attachment.html>

Unfortunately, GitHub does not allow this kind of "protection". Only
existing branches can be protected from pushes.
We already had such issues in the past when the outdated "master"
branch was pushed into the repo after the "master => main"
transition.
We reported the issue to GitHub ~year ago, but this might be included
into their roadmap for 2023 or so.

We've been told that the "workaround" is an action that removes
all
non-known branches, however, I'm a little bit hesitant on having such
kind of powerful automation, that could remove something from the
repo.

On Sat, Nov 6, 2021 at 3:56 AM Mara Sophie Grosch via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
>
> This happening was actually a big fear for me when I got commit access,
especially since I'm working on a fork for my hobby osdev project, not at
all ready for upstreaming it - one wrong git push away
>
> Seeing this happening to other people is a bit of a relief
>
> Is it possible to configure GitHub to forbid that? Like everything except
the normal branches being protected from pushes?
>
> Mara
>
> Am 6. November 2021 00:48:49 UTC schrieb Luke Benes via llvm-dev
<llvm-dev at lists.llvm.org>:
> >A branch containing the D112590 patch was accidentally pushed to
GitHub: https://github.com/llvm/llvm-project/tree/efb284c07e
> >
> >In the past couple of weeks, this also happened for
> >https://reviews.llvm.org/D107347
> >and
> >https://reviews.llvm.org/D108319
> >
> >This seems to be happening a lot recently. Is there a problem with the
instructions to commit patches?
> >
> >_______________________________________________
> >LLVM Developers mailing list
> >llvm-dev at lists.llvm.org
> >https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
> --
> Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev


--
With best regards, Anton Korobeynikov
Department of Statistical Modelling, Saint Petersburg State University